Golden Code Redmine

11/22/2024

03:09 AM Database Bug #7496: finish support for query:forward-only attribute

I've tested 7496c/15558 using the unit tests of a large customer and did not find any regressions. Dănuț Filimon

11/21/2024

05:03 AM Database Bug #7496 (Review): finish support for query:forward-only attribute

*Committed 7496c/15558*. When the delegate of ProgressiveResults closes, the AdaptiveQuery.resultsCached should be se... Dănuț Filimon

04:11 AM Database Bug #7496: finish support for query:forward-only attribute

Dănuț Filimon wrote:
> I am now thinking on how to _notify_ the AdaptiveQuery that it's results (ProgressiveResults)... Dănuț Filimon

11/20/2024

09:31 AM Database Bug #7496: finish support for query:forward-only attribute

Dănuț Filimon wrote:
> The strangest part now, I'd expect a rollback / the transaction to be committed (the TRANSACT... Dănuț Filimon

05:00 AM Database Bug #7496: finish support for query:forward-only attribute

I've tracked the issue and found the following:
* In @ProgressiveResults.moveTo()@, the @position@ is @236@, it scro... Dănuț Filimon

11/15/2024

07:26 AM Database Bug #9078: emit FindQuery as (reused) variables

#9078-63 can be ignored, after looking into the structure of the table there is an additional field similar to @field... Dănuț Filimon

06:40 AM Database Bug #9078: emit FindQuery as (reused) variables

I think I might have been chasing a totally different bug in a customer application (a bit weird), the following quer... Dănuț Filimon

02:14 AM Database Bug #7496 (WIP): finish support for query:forward-only attribute

From Constantin in #7143-1302:
> There is a regression in trunk rev 15530 when running ETF test:
> ... Dănuț Filimon

11/13/2024

05:06 AM Database Bug #9078: emit FindQuery as (reused) variables

Constantin, do you have any test case where the bound buffers can differ? I tried getting a snippet from a customer a... Dănuț Filimon

11/07/2024

07:29 AM Database Bug #7737 (Test): QueryWrapper should either show or throw errors depending on the query type

Matching status with #7496, the changes reached trunk/15530 as part of the 7496a branch. Dănuț Filimon

07:28 AM Database Bug #7737 (Internal Test): QueryWrapper should either show or throw errors depending on the query...

Dănuț Filimon

01:31 AM Database Bug #9078: emit FindQuery as (reused) variables

One thing that I want to mention is that there were no @error: code too large@ problems and an ongoing "issue". You c... Dănuț Filimon

01:18 AM Database Bug #9078: emit FindQuery as (reused) variables

I managed to successfully convert a large customer application and after looking a bit of the sources I did not notic... Dănuț Filimon

11/06/2024

09:31 AM Database Bug #9078: emit FindQuery as (reused) variables

Committed *9078a/15541*. Reinitialize the query when the bound buffers are different.
Left 20% for making adjustm... Dănuț Filimon

07:34 AM Database Bug #9078: emit FindQuery as (reused) variables

Constantin Asofiei wrote:
> Dănuț Filimon wrote:
> > Constantin Asofiei wrote:
> > > The only way to initialize th... Dănuț Filimon

07:25 AM Database Bug #9078: emit FindQuery as (reused) variables

Constantin Asofiei wrote:
> The only way to initialize the FIND is via @FindQuery.initialize@, right?
Not quite, th... Dănuț Filimon

07:00 AM Database Bug #9078: emit FindQuery as (reused) variables

Constantin Asofiei wrote:
> See the AdaptiveFind issue: a buffer can switch its bound buffer at any time. But other... Dănuț Filimon

11/05/2024

07:23 AM Database Bug #9078: emit FindQuery as (reused) variables

Fixed an action and removed the check in *9078a/15540*. Dănuț Filimon

07:10 AM Database Bug #9078: emit FindQuery as (reused) variables

Committed *9078a/15539*. Addressed #9078-47.
I think something like ... Dănuț Filimon

03:18 AM Database Bug #9078: emit FindQuery as (reused) variables

Alexandru Lungu wrote:
> > From my understanding, there are no longer queries without a name. Each FindQuery will ha... Dănuț Filimon

03:05 AM Database Bug #9078 (WIP): emit FindQuery as (reused) variables

Constantin Asofiei wrote:
> Review of 9078a/15537:
> ** is it ever possible for @<rule>toplvlref != null and toplvl... Dănuț Filimon

11/04/2024

09:46 AM Database Bug #9078: emit FindQuery as (reused) variables

Committed *9078a/15538*.
* Extended field initialization in FindQuery to support the new conversion changes. Field... Dănuț Filimon

04:27 AM Database Bug #7496 (Test): finish support for query:forward-only attribute

Branch 7496a was merged into trunk as rev. 15530 and archived. Dănuț Filimon

11/01/2024

09:53 AM Database Bug #9078 (Review): emit FindQuery as (reused) variables

Constantin, as discussed, please review the changes when you have time. Dănuț Filimon

07:06 AM Database Bug #9078: emit FindQuery as (reused) variables

Committed *9078a/15537*. Fixed wrong order of emitted FindQuery variable. Dănuț Filimon

05:57 AM Database Bug #9078: emit FindQuery as (reused) variables

Committed *9078a/15536*.
* Only emit a FindQuery as a variable for looping inner blocks.
* Fixed #9032-42.
* Cl... Dănuț Filimon

10/31/2024

11:02 AM Database Bug #9078: emit FindQuery as (reused) variables

I've managed to get a stable conversion with the new changes, but I found this case that needs to be investigated:
<... Dănuț Filimon

03:15 AM Base Language Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

Constantin, please review. Dănuț Filimon

10/30/2024

10:15 AM Database Bug #9078: emit FindQuery as (reused) variables

Constantin Asofiei wrote:
> Danut, the @FindQuery@ var def should be similar to the @OPEN QUERY@ var def - see @con... Dănuț Filimon

06:06 AM Database Bug #9078: emit FindQuery as (reused) variables

Constantin Asofiei wrote:
> Dănuț Filimon wrote:
> > Constantin, at this point the conversion changes for #9032-2 a... Dănuț Filimon

05:37 AM Database Bug #9078: emit FindQuery as (reused) variables

Rebased *9078a* with *trunk/15526*, the branch is now at revision *15535*. Dănuț Filimon

05:25 AM Database Bug #9078: emit FindQuery as (reused) variables

Committed *9078a/15525*.
* FIND statements are annotated using "fqryname" annotation instead of "qryname". Because t... Dănuț Filimon

10/29/2024

07:34 AM Database Bug #9078: emit FindQuery as (reused) variables

Fixed #9078-33 in *9078a/15524*. Dănuț Filimon

05:00 AM Database Bug #9078: emit FindQuery as (reused) variables

Committed *9078a/15523*. Added the fix mentioned in #9078-32. Dănuț Filimon

04:46 AM Database Bug #9078: emit FindQuery as (reused) variables

This one also:... Dănuț Filimon

04:42 AM Database Bug #9078: emit FindQuery as (reused) variables

I found a new fix for #9078-28, after converting hotel_gui and comparing the old and new conversions, I found the fol... Dănuț Filimon

03:16 AM Database Bug #9078: emit FindQuery as (reused) variables

Dănuț Filimon wrote:
> 9078a/15521 commit reverts most of the effort done for 9078a. I will have to think of another... Dănuț Filimon

10/28/2024

10:08 AM Database Bug #9078: emit FindQuery as (reused) variables

9078a/15521 commit reverts most of the effort done for 9078a. I will have to think of another solution. Dănuț Filimon

09:44 AM Database Bug #9078: emit FindQuery as (reused) variables

Dănuț Filimon wrote:
> Dănuț Filimon wrote:
> > I discovered a new conversion issue while testing hotel_gui so I am... Dănuț Filimon

06:51 AM Database Bug #9078: emit FindQuery as (reused) variables

Dănuț Filimon wrote:
> I discovered a new conversion issue while testing hotel_gui so I am currently investigating i... Dănuț Filimon

06:41 AM Database Bug #9078: emit FindQuery as (reused) variables

Committed *9078a/15520*. Modified CAN-FIND conversion to match the FIND statement conversion.
I discovered a new c... Dănuț Filimon

04:12 AM Database Bug #9078: emit FindQuery as (reused) variables

Committed *9078a/15519*. Support FindQuery constructor conversion as a variable scoped to the top level block.
TOD... Dănuț Filimon

03:06 AM Database Bug #7496: finish support for query:forward-only attribute

*7496a* can be merged. Dănuț Filimon

10/25/2024

09:49 AM Database Bug #7496: finish support for query:forward-only attribute

Rebased *7496a* with *trunk/rev.15523*. *7496a* is now at revision *15534*. Dănuț Filimon

08:59 AM Database Bug #7496: finish support for query:forward-only attribute

I updated the test plan status from #7496-76 with the latest results. The test plan was completed and there were no r... Dănuț Filimon

03:58 AM Database Bug #7496: finish support for query:forward-only attribute

Ioana-Cristina Prioteasa wrote:
> Applied 7496 changes over 7156c. The total time for a performance round has gone f... Dănuț Filimon

08:03 AM Database Bug #9078: emit FindQuery as (reused) variables

I've managed to find a fix for #9078-22, it involved searching for a top level block that has a top level ancestor an... Dănuț Filimon

07:17 AM Database Bug #9078: emit FindQuery as (reused) variables

I've managed to fix #9078-21, there was another rule whre the FindQuery constructor was created so I had to change it... Dănuț Filimon

03:01 AM Database Bug #9078: emit FindQuery as (reused) variables

I have trouble differentiating between the top block execute method and top block class method. Because of #9078-20 a... Dănuț Filimon