Golden Code Redmine

12/20/2024

05:02 AM Database Bug #9078: emit FindQuery as (reused) variables

Committed *9078b/15623*. Fix an infinite loop by making arguments part of the condition for reinitialization, some ar... Dănuț Filimon

12/19/2024

09:46 AM Database Bug #9078: emit FindQuery as (reused) variables

Example of the problem:... Dănuț Filimon

08:53 AM Database Bug #9078: emit FindQuery as (reused) variables

Dănuț Filimon wrote:
> Solution:
> * Reinitialize the query when the arguments do not match.
I found that even i... Dănuț Filimon

06:04 AM Database Bug #9078: emit FindQuery as (reused) variables

The following FindQuery extracted from ETF (slightly modified table/field names):... Dănuț Filimon

02:26 AM Database Bug #9383 (WIP): Cache only the current delegate on transaction commit if a ProgressiveResults is...

Alexandru Lungu wrote:
> I think there is a flaw in 9383a:
> * in case of a @ProgressiveQuery@, only the current br... Dănuț Filimon

12/18/2024

07:20 AM Database Bug #9078: emit FindQuery as (reused) variables

Committed *9078b/15622*. This branch contains the changes from 9078a, with the database_access.rules adjusted to comp... Dănuț Filimon

02:48 AM Database Bug #9078: emit FindQuery as (reused) variables

I will have to rework almost all the changes from database_access.rules because the constructor is no longer generati... Dănuț Filimon

12:56 AM Database Bug #9078: emit FindQuery as (reused) variables

I created *9078b* from *trunk/15621*, after making a patch of 9078a on top of that branch I found conversion issues u... Dănuț Filimon

12/17/2024

04:02 AM Database Bug #9078: emit FindQuery as (reused) variables

I've converted ETF with 9078a but all tests fail due to @Cannot create temp table field for "BATCHACTION"@. I've also... Dănuț Filimon

12/16/2024

05:44 AM Database Bug #9318: Make record nursery visible on removeRecords

Rebased *9318a* to latest *trunk/15616*, the branch is now at revision *15618*. Dănuț Filimon

05:38 AM Database Bug #9383: Cache only the current delegate on transaction commit if a ProgressiveResults is used

Rebased *9383a* to latest *trunk/15616*, the branch is now at revision *15617*. Dănuț Filimon

12/12/2024

04:29 AM Base Language Bug #9396: Improve Incompatible data types in expression or assignment. (223) error handling

I thought about this and found that we have a map storing function definitions in @SignatureHelper@ (@map_func@), thi... Dănuț Filimon

03:27 AM Database Bug #9383 (Review): Cache only the current delegate on transaction commit if a ProgressiveResults...

Harness and reports passed.
Alexandru, please review. Dănuț Filimon

12/11/2024

10:10 AM Database Bug #9383: Cache only the current delegate on transaction commit if a ProgressiveResults is used

Created *9383a* from *trunk/15611* and committed *9383a/15612*. @cacheResults()@ call from the notified TRANSACTION_C... Dănuț Filimon

12/10/2024

08:51 AM Database Bug #9383: Cache only the current delegate on transaction commit if a ProgressiveResults is used

Alexandru Lungu wrote:
> > I will try to find a test case from a customer application scenario and an analysis of ho... Dănuț Filimon

06:41 AM Database Bug #9383: Cache only the current delegate on transaction commit if a ProgressiveResults is used

Alexandru Lungu wrote:
>If the results are progressive, then an optimization would be to only cache the current dele... Dănuț Filimon

12/09/2024

08:10 AM Database Bug #9426: Failed to UPDATE when flushing an INVALID dmo

After setting up an instance with the proper version and testing the test mentioned in #9416, the issue can't be repr... Dănuț Filimon

04:09 AM Database Bug #9383 (WIP): Cache only the current delegate on transaction commit if a ProgressiveResults is...

Dănuț Filimon

12/06/2024

09:21 AM Database Bug #9426: Failed to UPDATE when flushing an INVALID dmo

The stack trace:... Dănuț Filimon

09:11 AM Database Bug #9426 (Rejected): Failed to UPDATE when flushing an INVALID dmo

Dănuț Filimon

08:42 AM Database Bug #9318: Make record nursery visible on removeRecords

Latest implementation was committed to *9318a/15588* Dănuț Filimon

08:01 AM Database Bug #9318 (Review): Make record nursery visible on removeRecords

@Buffer.delete()@ is used for temporary tables because there is no order by clause generated at conversion, but a @re... Dănuț Filimon

12/05/2024

06:50 AM Database Bug #9318: Make record nursery visible on removeRecords

My point for #9318-10 is that we do not need a deleteAll(deleteIndex), we only need to make the distinction between d... Dănuț Filimon

06:30 AM Database Bug #9318: Make record nursery visible on removeRecords

Currently:
* EMPTY TEMP-TABLE should honor all indices;
* FOR EACH tt1. DELETE tt1. END. should honor the primary i... Dănuț Filimon

05:34 AM Base Language Bug #9396: Improve Incompatible data types in expression or assignment. (223) error handling

Alexandru Lungu wrote:
> Danut, I am trying to drag the discussion to the point where proving that the error occurs ... Dănuț Filimon

03:55 AM Base Language Bug #9396: Improve Incompatible data types in expression or assignment. (223) error handling

Alexandru Lungu wrote:
> Please investigate why @tt.f1 = LENGTH('abc')@ is hitting the switch-case, making @var4glTy... Dănuț Filimon

03:20 AM Base Language Bug #9396 (WIP): Improve Incompatible data types in expression or assignment. (223) error handling

Resuming work for #9396-25. Dănuț Filimon

04:42 AM Database Bug #7496 (Test): finish support for query:forward-only attribute

Branch 7496c was merged into trunk as rev. 15596 and archived. Dănuț Filimon

12/03/2024

08:49 AM Base Language Bug #9396 (Review): Improve Incompatible data types in expression or assignment. (223) error hand...

Committed the changes to *9396a/15588*. Partially reverted changes from 15583 and 15584 revisions.
Please review.
... Dănuț Filimon

07:58 AM Base Language Bug #9396: Improve Incompatible data types in expression or assignment. (223) error handling

Alexandru Lungu wrote:
> > 528 - 4359 times (ProgressParserTokenTypes.KW_AND)
>
> I wonder if this is something l... Dănuț Filimon

06:59 AM Base Language Bug #9396: Improve Incompatible data types in expression or assignment. (223) error handling

Alexandru Lungu wrote:
> Can you check what the construct is in that case? I expect to see UPPER(RTRIM()) kind of co... Dănuț Filimon

06:12 AM Base Language Bug #9396: Improve Incompatible data types in expression or assignment. (223) error handling

I've run the analysis on how often we get @FUNCTION(literal)@ constructs (the scenario involves the extended performa... Dănuț Filimon

04:47 AM Base Language Bug #9396: Improve Incompatible data types in expression or assignment. (223) error handling

I also committed the logical(int) constructor change to *9396a/15586*.
Adjusted Done%. Dănuț Filimon

04:45 AM Base Language Bug #9396: Improve Incompatible data types in expression or assignment. (223) error handling

Alexandru Lungu wrote:
> Danut, lets go for to the more evident fix of not allowing the literals to be extracted in ... Dănuț Filimon

04:33 AM Base Language Bug #9396: Improve Incompatible data types in expression or assignment. (223) error handling

Alexandru, you are right. The problem also happens with other functions, the example:... Dănuț Filimon

03:51 AM Base Language Bug #9396: Improve Incompatible data types in expression or assignment. (223) error handling

Somehow I modified this, sorry. Dănuț Filimon

03:47 AM Base Language Bug #9396: Improve Incompatible data types in expression or assignment. (223) error handling

> where the injected variable is actually a CHARACTER but the conversion should fail because of the datetime function... Dănuț Filimon

08:08 AM Database Bug #7496: finish support for query:forward-only attribute

ChUI regression tests passed. l.e. updated #7496-102
*7496c* can be merged. Dănuț Filimon

12/02/2024

04:03 AM Database Bug #9318: Make record nursery visible on removeRecords

Alexandru Lungu wrote:
> I meant making the existing @deleteAll()@ call the @deleteAll(deleteIndex)@ with @null@ and... Dănuț Filimon

03:50 AM Database Bug #9318: Make record nursery visible on removeRecords

Created *9318a* from *trunk/15586* and committed an initial implementation on *9318a/15587*. Allows to make a distinc... Dănuț Filimon

03:48 AM Database Bug #7496: finish support for query:forward-only attribute

Alexandru Lungu wrote:
> Danut, what is the status of 7496c? What testing is left?
*7496c* has be queued for ChUI r... Dănuț Filimon

11/29/2024

09:35 AM Base Language Bug #9396 (Review): Improve Incompatible data types in expression or assignment. (223) error hand...

Committed *9396a/15585*. Added logical(int) constructor to fix #9396-7.
All written tests passed (tests cover dyna... Dănuț Filimon

09:13 AM Base Language Bug #9396: Improve Incompatible data types in expression or assignment. (223) error handling

Found the following test:... Dănuț Filimon

07:01 AM Base Language Bug #9396: Improve Incompatible data types in expression or assignment. (223) error handling

Dănuț Filimon wrote:
> This turns out to be more complicated for certain cast functions, for example you can have @D... Dănuț Filimon

03:43 AM Base Language Bug #9396: Improve Incompatible data types in expression or assignment. (223) error handling

This turns out to be more complicated for certain cast functions, for example you can have @DATETIME(DATE(3,3,2001), ... Dănuț Filimon

11/28/2024

07:08 AM Base Language Bug #9396: Improve Incompatible data types in expression or assignment. (223) error handling

*Committed 9396a/15583*. This commit fixes all of my testcases related to #9396-2 table (except the 3rd bullet point)... Dănuț Filimon

06:42 AM Base Language Bug #9396: Improve Incompatible data types in expression or assignment. (223) error handling

The third bullet point is a regression added in trunk/15456, @recordOrShowError@ throws a @DeferredLegacyErrorExcepti... Dănuț Filimon

06:10 AM Base Language Bug #9396 (WIP): Improve Incompatible data types in expression or assignment. (223) error handling

From #9377-8:
I've created unit tests for testing the behavior of *temp-tables* fields and literals:
|_. Field ty... Dănuț Filimon

06:04 AM Base Language Bug #9396 (WIP): Improve Incompatible data types in expression or assignment. (223) error handling

Dănuț Filimon

11/27/2024

05:34 AM Database Bug #7496: finish support for query:forward-only attribute

Rebased *7496c* to latest *trunk/15578* and the branch is now at revision *7496c/15579*. Dănuț Filimon

05:24 AM Database Bug #7496: finish support for query:forward-only attribute

Test plan:
* large customer application harness and run some reports. (Harness passed, tested 4 reports and those al... Dănuț Filimon

03:29 AM Database Bug #7496: finish support for query:forward-only attribute

Committed *xfer testcases/1655*:
* adaptive scrolling tests in @fwd_tests/persist/queries/@
* forward-only tests ... Dănuț Filimon

11/26/2024

07:27 AM Database Bug #7496: finish support for query:forward-only attribute

Alexandru Lungu wrote:
> adaptive_scrolling should clearly go into fwd_tests (maybe persist/queries folder?).
I was... Dănuț Filimon

06:04 AM Database Bug #7496: finish support for query:forward-only attribute

Alexandru Lungu wrote:
> Also please extend xfer 4GL unit test suite with your examples.
Should I commit the adap... Dănuț Filimon

11/25/2024

08:52 AM Database Bug #9318: Make record nursery visible on removeRecords

From #8959-19:
> The only limitation is that deleteIndex should come from the converted code and requires conversion... Dănuț Filimon

07:42 AM Database Bug #9318 (WIP): Make record nursery visible on removeRecords

Dănuț Filimon