Golden Code Redmine

03/25/2025

04:19 AM Base Language Bug #9060: Cache oftenly used values that are immutable

The changes in rev 15771 should solve the immutable types problem... Artur Școlnic

03/24/2025

10:09 AM Base Language Bug #9060 (Review): Cache oftenly used values that are immutable

I committed 9060b/15771, it contains fixes for issues from the review, constant type registering throughout the proje... Artur Școlnic

03/18/2025

12:58 PM Base Language Bug #9060: Cache oftenly used values that are immutable

This is different, for example:... Artur Școlnic

11:03 AM Base Language Bug #9060: Cache oftenly used values that are immutable

I started a more extensive testing process, hundreds of unit tests are failing because of assign style methods being ... Artur Școlnic

09:45 AM Base Language Bug #9060: Cache oftenly used values that are immutable

@decimal.compareTo@ uses @BigDecimal.compareTo@ which checks the scale, so I think we are safe. Artur Școlnic

09:23 AM Base Language Bug #9060: Cache oftenly used values that are immutable

Alexandru Lungu wrote:
> Oh, sorry for the confusion. I meant @cachedInstance.value.equals(value)@ or something like... Artur Școlnic

09:15 AM Base Language Bug #9060 (WIP): Cache oftenly used values that are immutable

Alexandru Lungu wrote:
> # why?
Isn't this expected? Comparing a decimalConstant with a BigDecimal using equals s... Artur Școlnic

09:00 AM Base Language Bug #9060: Cache oftenly used values that are immutable

Alexandru Lungu wrote:
> * I am quite nervous with comparing @double@ values with @==@: @cachedInstance.doubleValue(... Artur Școlnic

08:55 AM Base Language Bug #9060: Cache oftenly used values that are immutable

Artur Școlnic wrote:
> that would be the next step, which I already partly implemented, but for now we need to wrap... Artur Școlnic

08:44 AM Base Language Bug #9060: Cache oftenly used values that are immutable

Constantin Asofiei wrote:
> You mean @Can not compare character with characer constant!@?
Yes.
Artur Școlnic

08:17 AM Base Language Bug #9060: Cache oftenly used values that are immutable

Constantin Asofiei wrote:
> Review for 9060b rev 15768:
> * in @database_references.rules@, I think you need to che... Artur Școlnic

03/17/2025

04:58 AM Base Language Bug #9060 (Review): Cache oftenly used values that are immutable

I committed the conversion change to rev 15768, Constantin, please take a look. I converted hotel and there were no c... Artur Școlnic

03/14/2025

06:15 AM Base Language Bug #9060: Cache oftenly used values that are immutable

I had a talk with Constantin, the conclusion was that we need to wrap in mutable instances the constant types for eve... Artur Școlnic

04:39 AM Base Language Bug #9060: Cache oftenly used values that are immutable

Of course I will try to limit the changes to be applied only in the field access scenario. Artur Școlnic

04:34 AM Base Language Bug #9060: Cache oftenly used values that are immutable

Here are my proposals for solving the @replace@ issue:... Artur Școlnic

03:51 AM Base Language Bug #9060 (WIP): Cache oftenly used values that are immutable

I will bring the branch to a stable state by solving the issue described in #9060-85 and any other that pop out durin... Artur Școlnic

03/13/2025

11:12 AM Base Language Bug #9060: Cache oftenly used values that are immutable

Replacing @new date@ with @date.of@ throughout the project means there are going to be a lot of overloads for the @of... Artur Școlnic

09:44 AM Base Language Bug #9060: Cache oftenly used values that are immutable

... Artur Școlnic

09:37 AM Base Language Bug #9060: Cache oftenly used values that are immutable

The issue seem to originate from @BaseDataType.sameType@, it returns false for date and constant. Does it make sens t... Artur Școlnic

09:28 AM Base Language Bug #9060: Cache oftenly used values that are immutable

It seems so, I am getting errors in the @SharedVariableManager@ because @dateConstants@ are used. Artur Școlnic

09:12 AM Base Language Bug #9060: Cache oftenly used values that are immutable

I suppose @BaseDataTypeFactory.instantiate@ and any BDT generation method should return a mutable instance. Artur Școlnic

08:53 AM Base Language Bug #9060: Cache oftenly used values that are immutable

I am trying to replace all @date@ instance creation in the project with the @date.of@. Naturally this breaks everythi... Artur Școlnic

08:14 AM Base Language Bug #9060: Cache oftenly used values that are immutable

Constantin Asofiei wrote:
> Test the cache directly in Java - create the datetime-tz strings (what is @odt@ in your ... Artur Școlnic

07:34 AM Base Language Bug #9060: Cache oftenly used values that are immutable

... Artur Școlnic

06:04 AM Base Language Bug #9060: Cache oftenly used values that are immutable

After running 106 FWDTests, these are the results of the dynamic cache usage:... Artur Școlnic

03/12/2025

09:17 AM Base Language Bug #9060: Cache oftenly used values that are immutable

I encountered a few issued when using constant character, one of them leaves some tests in a perpetual wait state, a ... Artur Școlnic

03/11/2025

08:50 AM Base Language Bug #9060: Cache oftenly used values that are immutable

Alexandru suggested that at some point we should create new mutable instances and return them in the case of @InputOu... Artur Școlnic

08:16 AM Base Language Bug #9060: Cache oftenly used values that are immutable

Constantin Asofiei wrote:
> And also for InoutOutputField?
It is possible, so far I have been solving issues as t... Artur Școlnic

07:55 AM Base Language Bug #9060: Cache oftenly used values that are immutable

Artur Școlnic wrote:
> Maybe we can cast the constant types to normal ones in @FieldReference.getObject@?
Or pass... Artur Școlnic

07:48 AM Base Language Bug #9060: Cache oftenly used values that are immutable

Maybe we can cast the constant types to normal ones in @FieldReference.getObject@? Artur Școlnic

07:23 AM Base Language Bug #9060: Cache oftenly used values that are immutable

Currently I am trying to solve this issue:... Artur Școlnic

06:48 AM Base Language Bug #9060: Cache oftenly used values that are immutable

At this point, no. I am working on it. Artur Școlnic

05:55 AM Base Language Bug #9060: Cache oftenly used values that are immutable

Memory profiling with the changes in 9060b results for BDT instances (large application FWDtest that uses a lot of CR... Artur Școlnic

03/10/2025

11:07 AM Base Language Bug #9060: Cache oftenly used values that are immutable

I did a memory profiling on a large application FWDTest and saw that the most instantiated BDTs are @unknown@, and th... Artur Școlnic

05:45 AM Base Language Bug #9060: Cache oftenly used values that are immutable

The general idea is that the least used entries will always change, but the most used one will always be "in the top"... Artur Școlnic

05:40 AM Base Language Bug #9060: Cache oftenly used values that are immutable

This is the most efficient implementation I found:
Key Data Structures:
* HashMap<K, V>: Stores the actual cache ... Artur Școlnic

05:24 AM Base Language Bug #9060: Cache oftenly used values that are immutable

Clearly a LRU cache is not a good idea for caching the BDT constants, but what about a Most Frequently Used (MFU) cac... Artur Școlnic

03/07/2025

09:34 AM Base Language Bug #9060 (Review): Cache oftenly used values that are immutable

9060b/15764 is ready for review. Artur Școlnic

07:54 AM Base Language Bug #9060 (WIP): Cache oftenly used values that are immutable

Constantin Asofiei wrote:
> Please provide some examples.
What I meant is that it cannot be private or protected,... Artur Școlnic

07:33 AM Base Language Bug #9060: Cache oftenly used values that are immutable

Constantin Asofiei wrote:
> Review for 9060b/15755:
> * why the access mode change for some methods in i.e. @dateti... Artur Școlnic

05:46 AM Base Language Bug #9060 (Review): Cache oftenly used values that are immutable

I added the immutable types and used them in Record getters, so far it seems to work fine. The code is in 9060b/15755... Artur Școlnic

03/04/2025

09:39 AM Base Language Bug #9060: Cache oftenly used values that are immutable

Immutable objects can't be changed at all, unmodifiable objects can't be change externally, but their state can be mo... Artur Școlnic

09:33 AM Base Language Bug #9060: Cache oftenly used values that are immutable

What I meant is that we only use one or two constructor overloads in @Record@ for each BDT, so it makes sense to have... Artur Școlnic

09:25 AM Base Language Bug #9060: Cache oftenly used values that are immutable

Should every constructor for a BDT have an equivalent @immutable()@ overload? Artur Școlnic

08:01 AM Base Language Bug #9060: Cache oftenly used values that are immutable

I added support for Constant BDTs for getters in @Record@. There was an issue with the type resolving in @FuzzyMethod... Artur Școlnic

03/03/2025

08:53 AM Database Bug #9683: CompoundQuery is doing extra hydration attempts

I committed rev 15726. It contains a new interface and a few implementing classes. Artur Școlnic

02/27/2025

07:08 AM Database Bug #9669: Optimize RecordMeta.applyInitialValues

Branch 9669a was merged to trunk as rev.15743 and archived. Artur Școlnic

06:13 AM Database Bug #9669: Optimize RecordMeta.applyInitialValues

FwdTests passed. Artur Școlnic

05:13 AM Database Bug #9669: Optimize RecordMeta.applyInitialValues

Removed getProperties in rev 15722. Artur Școlnic

05:00 AM Database Bug #9669 (Review): Optimize RecordMeta.applyInitialValues

I committed the latest changes to rev 15721.
Artur Școlnic

02:34 AM Database Bug #9669: Optimize RecordMeta.applyInitialValues

Alexandru Lungu wrote:
> ** Anyway, I think this approach is not completely right because you presume that the @dyna... Artur Școlnic