Golden Code Redmine

06/20/2025

05:45 AM Database Bug #9078: emit FindQuery as (reused) variables

The solution would be to move @fqueryArray[0] = new FindQuery();@ in the @body()@, emit the FindQuery normally withou... Dănuț Filimon

05:37 AM Database Bug #9078: emit FindQuery as (reused) variables

The following test:... Dănuț Filimon

04:09 AM Conversion Tools Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

Greg, all regression testing passed. 5586a can be merged. Dănuț Filimon

06/19/2025

07:33 AM Database Bug #9078: emit FindQuery as (reused) variables

The following template worked:... Dănuț Filimon

07:20 AM Database Bug #9078: emit FindQuery as (reused) variables

I've adjusted the template in the following way:... Dănuț Filimon

07:06 AM Database Bug #9078: emit FindQuery as (reused) variables

I found the @named_array@ template in @java_templates.tpl@ and managed to generate something like:... Dănuț Filimon

05:58 AM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows

I added a comment in *9863a/15984*. Dănuț Filimon

04:34 AM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows

I committed *9863a/15983*. Moved normalizeFilePath() to Utils, removed the unnecessary endsWith() call. Dănuț Filimon

02:00 AM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows

Greg Shah wrote:
> Code Review Task Branch 9863a Revisions 15980 through 15982
>
> The changes are good.
>
> 1... Dănuț Filimon

06/18/2025

09:50 AM Conversion Tools Feature #6256: improved profile support

Committed *6256a/15945*. Fixed the two issues I found when converting hotel using multiple profiles. Dănuț Filimon

09:18 AM Conversion Tools Bug #9917: Fileset not ignoring case

Greg Shah wrote:
> Code Review Task Branch 9917a Revisions 15969 through 15971
>
> Overall, the changes seem reas... Dănuț Filimon

02:47 AM Conversion Tools Bug #9917: Fileset not ignoring case

Dănuț Filimon wrote:
> I will be running a conversion today with the same customer application that failed previousl... Dănuț Filimon

06/17/2025

08:35 AM Conversion Tools Feature #6256: improved profile support

I fixed the problem by removing the bit of code that checks for @isMultiProfile()@, this was added in:... Dănuț Filimon

06:01 AM Conversion Tools Feature #6256: improved profile support

The issue is related to @TransformDriver.createDatabaseList()@ where the "standard" namespace is not taken into consi... Dănuț Filimon

05:21 AM Database Bug #10080: Temp-table records are leaking in can-find statements

Eduard, 8308f wasn't backed out from 7156c/e. Please commit the necessary changes from 10080a to 7156c and 7156e. Dănuț Filimon

02:54 AM Conversion Tools Bug #9917: Fileset not ignoring case

I will be running a conversion today with the same customer application that failed previously. Dănuț Filimon

02:36 AM Conversion Tools Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

The project was converted and built successfully. Dănuț Filimon

06/16/2025

06:24 AM Conversion Tools Feature #6256: improved profile support

The issue is that there are three profiles and the two profiles that do not define a namespace for the hotel, do not ... Dănuț Filimon

06:18 AM Conversion Tools Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

Stefan, is there anything else you need to add to the branch? I want to pick this up and run a customer conversion. Dănuț Filimon

04:37 AM Conversion Tools Bug #9863 (Review): Fileset eXclude broken on native Windows

I created a @FileListFactory.normalizeFilePath()@ method and tested the following:
# @D ./abl/tmp/ *.p@ => @abl/tmp@... Dănuț Filimon

06/13/2025

08:08 AM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows

Greg Shah wrote:
> > I'm also wondering if we should account for @..@ in the filters?
>
> Canonicalization whould... Dănuț Filimon

07:57 AM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows

Dănuț Filimon wrote:
> Some cases I tested/will test:
> # @D ./abl/tmp/@ : at row 1 in file zfile_set.txt is malfor... Dănuț Filimon

07:56 AM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows

Committed *9863a/15981*. Summary of the changes:
* Paths should replace "\\" with "/" before any processing is done,... Dănuț Filimon

06:51 AM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows

Greg Shah wrote:
> > Currently @X ./abl/tmp/@ does nothing. It will not exclude any files from the specified folder ... Dănuț Filimon

06:08 AM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows

Currently @X ./abl/tmp/@ does nothing. It will not exclude any files from the specified folder since the pattern will... Dănuț Filimon

06:07 AM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows

Greg Shah wrote:
> Dănuț Filimon wrote:
> > Greg Shah wrote:
> > > > I am sure we do not want to add a feature whi... Dănuț Filimon

06:02 AM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows

Greg Shah wrote:
> > I am sure we do not want to add a feature which didn't exist before.
>
> Is it a new feature... Dănuț Filimon

03:27 AM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows

Dănuț Filimon wrote:
> Additional note for #9863-43, @Utils.canonicalizePath()@ doesn't work for @.//abl//tmp//*@ bu... Dănuț Filimon

06:10 AM Conversion Tools Feature #6256: improved profile support

Greg Shah wrote:
> > I don't think two profiles should have the same namespace defined (with the same name).
>
> ... Dănuț Filimon

05:47 AM Conversion Tools Feature #6256: improved profile support

Greg, the issue with #6256-84 is that I've defined the following namespace for both profiles:... Dănuț Filimon

04:38 AM Conversion Tools Feature #6256: improved profile support

Committed *6256a/15944*. Added PROFILE mode.
Currently looking into the error from #6256-84. Dănuț Filimon

06/12/2025

09:26 AM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows

Greg Shah wrote:
> > If I replace the '\\' with '/', the only problem will be the pattern because the files in Windo... Dănuț Filimon

09:01 AM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows

Greg Shah wrote:
> Normally, we use things like @Utils.canonicalizePath()@ to eliminate the excess nonsense like @so... Dănuț Filimon

09:00 AM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows

Greg Shah wrote:
> > If I replace the '\\' with '/', the only problem will be the pattern because the files in Windo... Dănuț Filimon

08:29 AM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows

Dănuț Filimon wrote:
> Greg, is the scenario [...] something that should be supported? Using a single \ instead of \... Dănuț Filimon

07:58 AM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows

Greg, is the scenario ... Dănuț Filimon

07:03 AM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows

If I replace the '\\' with '/', the only problem will be the pattern because the files in Windows will be using '\' a... Dănuț Filimon

03:04 AM Conversion Tools Bug #9863 (WIP): Fileset eXclude broken on native Windows

I'll work on #9863-33 to #9863-35. Dănuț Filimon

03:23 AM Base Language Bug #9996: Object references should be decremented at the nearest block instead of the top-level ...

I rebased *9538d* to latest *trunk/15980*, the branch is now at revision *15985*. Dănuț Filimon

03:03 AM Conversion Tools Feature #6256 (WIP): improved profile support

Greg Shah wrote:
> > These profiles can only be used in the default @ConversionDriver@ mode which is @ListType.CMD_L... Dănuț Filimon

02:24 AM Database Bug #9078: emit FindQuery as (reused) variables

Alexandru Lungu wrote:
> Dănuț Filimon wrote:
> > I did not take into account that there might be a limitation to t... Dănuț Filimon

06/11/2025

09:14 AM Database Bug #9078: emit FindQuery as (reused) variables

I did not take into account that there might be a limitation to the number of local variables that can be defined in ... Dănuț Filimon

08:36 AM Database Bug #9078: emit FindQuery as (reused) variables

I discussed with Artur and took time to take a look at all find queries from the problematic class. I took each one a... Dănuț Filimon

03:45 AM Conversion Tools Bug #9863 (Review): Fileset eXclude broken on native Windows

Created *9863a* from latest *trunk/15978* and committed *9863a/15979*. The commit contains the fix for fileset eXclud... Dănuț Filimon

06/10/2025

08:47 AM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows

On Windows, even if the path is ./abl/, it will make it into @.\abl@ when calling @new File(path)@, disregarding the ... Dănuț Filimon

07:05 AM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows

Greg Shah wrote:
> The patterns should not be file-system specific. In fact, we should only support the @/@ as the ... Dănuț Filimon

05:54 AM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows

Replacing the "/" with the file separator in step 2 will make the filter match the ".\" (@./abl/fwd-embedded-driver.p... Dănuț Filimon

05:18 AM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows

I used the following zset:... Dănuț Filimon

06:39 AM Database Bug #9078: emit FindQuery as (reused) variables

Artur ran a conversion for a customer application and found a conversion issue. I plan to work with Artur to identify... Dănuț Filimon

06/06/2025

07:15 AM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows

I managed to setup the w11 vm and reproduce the issue. Currently investigating. Dănuț Filimon

04:54 AM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows

Șerban Bursuc wrote:
> Dănuț Filimon wrote:
> > Roger, is there a minimal requirement for the w11 vm? I've made min... Dănuț Filimon

04:45 AM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows

Roger, is there a minimal requirement for the w11 vm? I've made mine with 4gb base memory and 2 processors and it han... Dănuț Filimon

02:49 AM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows

Roger Borrello wrote:
> Dănuț Filimon wrote:
> > Hi Roger, I am trying to setup a Windows11 instance to start worki... Dănuț Filimon

06/05/2025

09:15 AM Database Bug #9078: emit FindQuery as (reused) variables

Rebased *9078b* to latest *trunk/15969*, the branch is now at revision *15973*. Dănuț Filimon

08:40 AM Conversion Tools Bug #9917 (Review): Fileset not ignoring case

Committed *9917a/14971*. Use Set instead of List for listImpl() and sortFiles() + a few small changes. Dănuț Filimon

08:00 AM Conversion Tools Bug #9917: Fileset not ignoring case

I rebased *9917a* to latest *trunk/15967*, the branch is now at revision *15970*.
I plan to commit the change for... Dănuț Filimon

04:22 AM Conversion Tools Bug #9917: Fileset not ignoring case

I committed *9917a/15947*. This only contains changes for the frame and menu issue, the idea is that in @convertSourc... Dănuț Filimon

08:26 AM Conversion Tools Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

Stefan, I mentioned in our weekly meeting that I plan to run a conversion on a customer project. At the moment, the i... Dănuț Filimon

06:17 AM Conversion Tools Bug #9863: Fileset eXclude broken on native Windows

Hi Roger, I am trying to setup a Windows11 instance to start working on this issue and have been meeting with some is... Dănuț Filimon

06/04/2025

09:30 AM Conversion Tools Bug #9917: Fileset not ignoring case

... Dănuț Filimon

08:10 AM Conversion Tools Bug #9917 (WIP): Fileset not ignoring case

Dănuț Filimon wrote:
> I think the naming convention for frames should be changed. When handling a frame with the na... Dănuț Filimon

03:59 AM Conversion Tools Bug #9917: Fileset not ignoring case

I think the naming convention for frames should be changed. When handling a frame with the name @test-form@, the name... Dănuț Filimon

03:33 AM Conversion Tools Bug #9917: Fileset not ignoring case

I ran a conversion for a customer application that uses case-sensitive = false and it failed.
The scenario:
* 715... Dănuț Filimon

06/03/2025

08:56 AM Conversion Tools Feature #6256: improved profile support

Greg Shah wrote:
> Are you sure that the requirements of #6256-47 and #6256-50 are already handled? I didn't think ... Dănuț Filimon

07:53 AM Conversion Tools Feature #6256 (Review): improved profile support

Indeed, BarTest.cls is added during the @Scanning Progress Source (preprocessor, lexer, parser, persist ASTs)@ step.
... Dănuț Filimon

03:23 AM Conversion Tools Feature #6256: improved profile support

A breakdown of the remaining parameters:
* includeRemap: #6256-76 is really helpful, I also found that the tag is no... Dănuț Filimon

06:56 AM Base Language Bug #9996: Object references should be decremented at the nearest block instead of the top-level ...

I rebased *9538d* to latest *trunk/15960*, the branch is now at revision *15965*.
I will create a test plan and em... Dănuț Filimon

05:33 AM Base Language Bug #9996 (Review): Object references should be decremented at the nearest block instead of the t...

I committed *9538d/15911*, now scopeStart and scopeFinished will handle internalDefinitions for all blocks and the re... Dănuț Filimon

06/02/2025

09:34 AM Conversion Tools Feature #6256: improved profile support

Dănuț Filimon wrote:
> I also want to add the following scenario:
> * When there is a *default* profile defined, bu... Dănuț Filimon

07:55 AM Conversion Tools Feature #6256: improved profile support

I updated https://proj.goldencode.com/projects/p2j/wiki/Chapter_6_Project_Setup#Profiles, but I am not sure how to de... Dănuț Filimon

06:43 AM Conversion Tools Feature #6256: improved profile support

Constantin Asofiei wrote:
> If profiles are used, then:
> * if the profile has a fileset, then that is used
> * if... Dănuț Filimon

06:12 AM Conversion Tools Feature #6256: improved profile support

I committed *6256a/15492*. Ignore the -z fileset, but only when there's a profile fileset specified. Dănuț Filimon

09:16 AM Database Bug #10080: Temp-table records are leaking in can-find statements

Original test case can be found in #8308-505. There are also more tests committed in xfer testcases/1753.
The chan... Dănuț Filimon

09:13 AM Database Bug #10080 (Test): Temp-table records are leaking in can-find statements

Dănuț Filimon

05/29/2025

07:05 AM Conversion Tools Feature #6256: improved profile support

The ProfileConfig is created when the p2j.cfg.xml is read (Configuration.loadXml()), the following properties must be... Dănuț Filimon

06:10 AM Conversion Tools Feature #6256: improved profile support

Greg Shah wrote:
> Please plan to make additions to our documentation to explain this syntax.
I will do so in thi... Dănuț Filimon

06:06 AM Conversion Tools Bug #9917: Fileset not ignoring case

I tested and didn't find a scenario where this breaks. The customer application I'm working on uses uses the default ... Dănuț Filimon

02:50 AM Conversion Tools Bug #9917: Fileset not ignoring case

I committed 9917a/15946 to address #9917-7. I will do a few more tests. Dănuț Filimon

05/28/2025

09:03 AM Conversion Tools Feature #6256: improved profile support

I've experimented and the following worked:... Dănuț Filimon

08:46 AM Conversion Tools Feature #6256: improved profile support

Dănuț Filimon wrote:
> Dănuț Filimon wrote:
> > I am trying to understand how p2j.cfg.xml is used in this context, ... Dănuț Filimon

08:29 AM Conversion Tools Feature #6256: improved profile support

Dănuț Filimon wrote:
> I am trying to understand how p2j.cfg.xml is used in this context, I've found the following d... Dănuț Filimon

05:31 AM Conversion Tools Feature #6256: improved profile support

I am trying to understand how p2j.cfg.xml is used in this context, I've found the following documentation https://pro... Dănuț Filimon

04:26 AM Conversion Tools Feature #6256: improved profile support

For #6256-53, I think the fix needs to involve the p2j.cfg.xml (the propath and basepath parameters). In @FileListFac... Dănuț Filimon

07:56 AM Conversion Tools Bug #9917 (Review): Fileset not ignoring case

I confirmed that the scenario doesn't work. About #9917-2, the compare method is not what I expect to use in this cas... Dănuț Filimon

05/27/2025

09:47 AM Conversion Tools Feature #6256: improved profile support

Constantin Asofiei wrote:
> There is a problem when the 'exclude' filter is used to not add files to conversion. Du... Dănuț Filimon

07:45 AM Conversion Tools Feature #6256: improved profile support

Created task branch *6256a* from latest *trunk/15941*. Dănuț Filimon

04:04 AM Conversion Tools Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

Committed *7180a/15952*. Simplified transformArtifactNames() and removed containsArtifact() from ArtifactManager.
... Dănuț Filimon

03:57 AM Base Language Bug #9996 (WIP): Object references should be decremented at the nearest block instead of the top-...

Constantin Asofiei wrote:
> Danut, some notes:
> * now we register ObjectOps as 'block-scopeable' instead of 'top-... Dănuț Filimon

05/26/2025

07:39 AM Conversion Tools Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

I decided that I will hold off the changes to UastHints due to #7180-163, I shifted my focus to getting rid of the Fi... Dănuț Filimon

05/23/2025

07:49 AM Conversion Tools Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

One issue with using artifacts in UastHints which is problematic. The example is @AstGenerator.processFile()@ where w... Dănuț Filimon

06:14 AM Conversion Tools Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

I was going into the customer rules for the ChUI project and noticed a @getSourceFor()@ call which returns a filename... Dănuț Filimon

05:53 AM Conversion Tools Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

Rebased *7180a* to latest *trunk/15932*, the branch is now at revision *15951*. Dănuț Filimon