Golden Code Redmine

12/17/2025

10:34 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

Greg Shah wrote:
> Paula Păstrăguș wrote:
> > I also identified another significant issue related to the k = 4 sett... Paula Păstrăguș

09:18 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

Paula Păstrăguș wrote:
> I didn’t actually apply the settings from there directly.
In @generate_preproc_output.p@... Paula Păstrăguș

09:09 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

I also identified another significant issue related to the k = 4 setting. For example, given the input:... Paula Păstrăguș

09:02 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

Greg Shah wrote:
> Our ANTLR2 tests are run with a full toolset (preprocessor etc...). I think we may be adding an ... Paula Păstrăguș

09:00 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

Greg Shah wrote:
> Where are the @.lexer@ baselines in the testcases project? I don't see them.
Same here. Anywa... Paula Păstrăguș

07:53 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

Should invalid test cases also be expected to produce matching results...? For example, consider the invalid input @*... Paula Păstrăguș

06:57 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

The first difference appears in the @symbol_backslash.p@ test case, whose content is:... Paula Păstrăguș

06:39 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

I used the test suite located in @testcases/tests/conversion/lexer/4gl_testcases@ to evaluate areas where the current... Paula Păstrăguș

07:10 AM Conversion Tools Feature #10190: Prototype the changes to the build to add ANTLR v4

Here are the logs for @ant jar --verbose@:
{{collapse... Paula Păstrăguș

04:03 AM Conversion Tools Feature #10190: Prototype the changes to the build to add ANTLR v4

I completed a full conversion of a large GUI application, and it passed successfully. I also performed smoke testing,... Paula Păstrăguș

12/16/2025

07:43 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

I think I’ve found a workaround for the DSTRING lexer rule, although it requires changing the original structure a bi... Paula Păstrăguș

06:09 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

Just a quick update on this issue. At the moment, I’m investigating a memory leak in the lexer. Using the following t... Paula Păstrăguș

12/12/2025

08:39 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

Greg Shah wrote:
> FYI, the testcase should have @.@ instead of @;@ at the end of the first line.
Good catch! Paula Păstrăguș

08:35 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

With a little bit of fine tuning, the test output in this moment looks like this:... Paula Păstrăguș

08:14 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

I think I am making some progress with the lexer. I managed to set up a small test project, and I am actually quite h... Paula Păstrăguș

12/10/2025

08:31 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

Paula Păstrăguș wrote:
> Things are getting more complicated: ANTLR4 does not allow action blocks inside fragment ru... Paula Păstrăguș

04:35 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

I’ll rename @SchemaLexer@ to @ProgressLexer@ (+ I'll keep the same structure of the progress.g grammar lexer into the... Paula Păstrăguș

04:30 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

Paula Păstrăguș wrote:
> Paula Păstrăguș wrote:
> > * Fragment rules were introduced in ANTLR4. I haven’t yet creat... Paula Păstrăguș

04:17 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

Another aspect we need to clarify is the equivalent for ANTLR2’s @LA() lookahead@ function. At the moment, I used @_i... Paula Păstrăguș

04:08 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

We will need a mechanism to replicate the old ANTLR2 @append()@ behavior and the @!@ operator when migrating to ANTLR... Paula Păstrăguș

04:00 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

Paula Păstrăguș wrote:
> * Fragment rules were introduced in ANTLR4. I haven’t yet created any, but they can be used... Paula Păstrăguș

01:42 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

You're right, this options block did the trick:... Paula Păstrăguș

12/09/2025

09:18 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

Hm, into the @SchemaLexer.tokens@, the value of @HEX_LITERAL@ is @1@, and into the @SchemaParser.tokens@, the value o... Paula Păstrăguș

09:01 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

Kind of, we need that token for both, the parser and the lexer. But the int values will be different, depending on ho... Paula Păstrăguș

08:33 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

As a side note, I feel that rewriting the grammar was actually the easy part, what comes next is where the real compl... Paula Păstrăguș

08:21 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

Greg, I'm a bit confused... I initially thought that splitting the grammar would solve this issue. Let me explain the... Paula Păstrăguș

07:31 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

* The next step is to split the grammar into @SchemaParser.g4@ and @SchemaLexer.g4@. I realize the schema grammar nor... Paula Păstrăguș

04:21 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

Committed the grammar as rev @16006@. Paula Păstrăguș

02:40 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

Greg Shah wrote:
> For the Progress lexer, I'd like to see the standalone @.g4@ file for it. It is hard for me to g... Paula Păstrăguș

08:35 AM Conversion Tools Feature #10190: Prototype the changes to the build to add ANTLR v4

Updated the antlr4 version to @4.13.2@ in rev @16005@. Paula Păstrăguș

06:50 AM Conversion Tools Feature #10190: Prototype the changes to the build to add ANTLR v4

I tested the build changes and everything appears to be in order. The only missing piece is the @src/com/goldencode/p... Paula Păstrăguș

12/08/2025

09:54 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

Today I worked on the lexer rules and tokens, which are the final missing piece of the schema migration puzzle.
Here... Paula Păstrăguș

09:29 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

Greg Shah wrote:
> What do you mean by "lookahead hooks"? In both ANTLR2 and ANTLR4 we can use @LT()@ to lookahead ... Paula Păstrăguș

12/05/2025

10:42 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

I have some good news: I’m very close to finishing the rewrite of the schema file. The remaining work is mainly to re... Paula Păstrăguș

12/04/2025

07:20 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

Greg Shah wrote:
> 3. We need to discuss the tree building. I think the idea of returning the created subtree from... Paula Păstrăguș

12/03/2025

10:02 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

Greg, I’ve attached the current @Schema.g4@ grammar. There are only a few rules implemented so far, but if you have s... Paula Păstrăguș

03:34 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

Just a quick note regarding my next steps: I’ll begin modifying the @schema.g@ file to migrate it to ANTLR4. Working ... Paula Păstrăguș

11/28/2025

08:15 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

Thank you, Ovidiu. I asked this because we need to create @helper methods@ that allow us to build the AST directly fr... Paula Păstrăguș

04:15 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

I have a question regarding artificial nodes. These are the nodes that the grammar creates manually, for example usin... Paula Păstrăguș

03:21 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

Regarding the shadow nodes: the @left@ and @right@ IDs are used to locate the nearest AST node for each shadow node, ... Paula Păstrăguș

03:16 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

Ovidiu Maxiniuc wrote:
> I do not think we should use @left@ and @right@. The resulting tree is not always binary.
... Paula Păstrăguș

11/27/2025

04:51 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

Another thing I noticed: I added the shadows nodes to the list after the @left@ and @right@ IDs were populated, which... Paula Păstrăguș

04:24 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

During testing, I realized I forgot to assign the @parent AST@ to the shadow nodes. Right now, they’re orphans:), so ... Paula Păstrăguș

11/26/2025

10:08 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

Thanks, Greg, I had misunderstood that part. I’ve been working on adapting the @TreeLocal@, the @ShadowNode@, and the... Paula Păstrăguș

11/25/2025

05:54 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

Greg, I reviewed the @hidden@ field, the @ShadowNode@ structure, and the entire @TreeLocal@ mechanism. The conclusion... Paula Păstrăguș

11/24/2025

10:34 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

Aaand this is the output of a @dumpTree(true)@ for this input: @"1 + 2 * 3 + 4 * 5"@
Related java testing code:
<pr... Paula Păstrăguș

10:31 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

Greg, I've pushed a new version of @10804a@. You should now be able to see the new classes. I've fully separated the ... Paula Păstrăguș

11/21/2025

10:20 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

Greg, I updated the wiki and pushed the new interface and implementation to 10804a. You should now be able to access ... Paula Păstrăguș

08:06 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

Yes, you’re right! I’ll take care of it. Really appreciate the detailed guidance. Paula Păstrăguș

05:06 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

My suggestion is to wait until the end of the day, so I can finish covering most of the methods, prepare the comparis... Paula Păstrăguș

04:49 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

I think creating a table will help clarify things for both of us. At this point, I’ve gone through the ascent/descent... Paula Păstrăguș

03:12 AM Conversion Tools Feature #10804 (WIP): create replacement AST implementation for use with ANTLR 4

Greg, I attached the ZIP containing the test project. Inside you will find both approaches: the visitor-based impleme... Paula Păstrăguș

11/19/2025

11:24 AM Deployment Support #10905: Questions for an end user when something unexpected happens

There are a few additional considerations: in some extreme scenarios the UI may become completely unresponsive, or a ... Paula Păstrăguș

10:54 AM Deployment Support #10905: Questions for an end user when something unexpected happens

Radu, task #10451 is designed to log all relevant events, giving deeper insights into the user journey. It only requi... Paula Păstrăguș

11:06 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4

Greg, I’m still a bit unclear on how to properly test these changes. I created a small separate project with a simple... Paula Păstrăguș