Sergey Ivanovskiy's activity
From 04/23/2026 to 05/22/2026
05/22/2026
- 05:31 PM User Interface Bug #10915 (Review): ugly dialogs
- ...
- 04:40 PM User Interface Bug #10915: ugly dialogs
- OK. Committed revision 16629 (10915a) has opened major issues that can be fixed later in the different tasks.
Runnin... - 04:23 PM User Interface Bug #10915: ugly dialogs
- This issue can be discussed. It relates to dialog messages used as translation keys and read from the directory. I po...
- 01:38 PM User Interface Bug #10915: ugly dialogs
- Committed rev 16628 got this result...
- 11:00 AM User Interface Bug #10915: ugly dialogs
- Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > OK. Please look at this issue that is not related to my diff.
>... - 08:15 AM User Interface Bug #10915: ugly dialogs
- Also I tested these changes with testcases.
- 08:12 AM User Interface Bug #10915: ugly dialogs
- Committed revision 16626 (10915a) is a good candidate for the review. Applied almost patches and running the review now.
- 07:43 AM User Interface Bug #10915: ugly dialogs
- This issue can be discussed. Hynek, please look at this change. I would apply it too.
- 06:30 AM User Interface Bug #10915: ugly dialogs
- I like this proposal.
- 06:26 AM User Interface Bug #10915: ugly dialogs
- OK. Please look at this issue that is not related to my diff.
- 05:28 AM User Interface Bug #10915: ugly dialogs
- The results look interesting. Can they be posted? I would apply some of them because their looks are reasonable.
- 05:22 AM User Interface Bug #10915: ugly dialogs
- I asked to prepare proposed solutions to each of the reported issues in the separated file corresponding each major i...
- 05:19 AM User Interface Bug #10915: ugly dialogs
- OK. I am trying to pass this review as soon as possible due to incoming bugs #11412 and #11485 that were fixed in 109...
- 04:03 AM User Interface Bug #10915: ugly dialogs
- Committed rev 16625. There are edge cases that still not fixed.
- 04:02 AM User Interface Bug #10915: ugly dialogs
- I ran several rounds of the review. The process yielded highly useful insights because the codebase is both asynchron...
- 01:45 AM User Interface Bug #10915: ugly dialogs
- I have these critical issues rooted in the legacy code. Could those be fixed in new optimization task?
* *[CRITICA... - 03:59 PM Runtime Infrastructure Bug #11494: AI spotted security issue VirtualDesktopWebHandler.handleSsoReauth
- I will delegate this issue to this task.
- 03:56 PM Runtime Infrastructure Bug #11494: AI spotted security issue VirtualDesktopWebHandler.handleSsoReauth
- New issue that can be fixed in this task too.
- 11:11 AM Runtime Infrastructure Bug #11494: AI spotted security issue VirtualDesktopWebHandler.handleSsoReauth
- Please check if it is a real issue.
- 11:10 AM Runtime Infrastructure Bug #11494 (New): AI spotted security issue VirtualDesktopWebHandler.handleSsoReauth
05/21/2026
- 12:13 PM User Interface Bug #10915: ugly dialogs
- I committed rev 16661 (10915a) and started code review. I did not do anything with these issues: issue 6, 8, 9.
- 11:54 AM User Interface Bug #10915: ugly dialogs
- >I do not know how to do it because the cursor must be controlled by the business logic. This part is not elaborated....
- 11:40 AM User Interface Bug #10915: ugly dialogs
- Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Th 8-th issue should be discussed because we should not need to ... - 11:33 AM User Interface Bug #10915: ugly dialogs
- Sergey Ivanovskiy wrote:
> The second issue is really came from my changes in which I did the dialog without closed ... - 10:56 AM User Interface Bug #10915: ugly dialogs
- OK. I will leave this and remove p2j.lyra guard.
- 10:45 AM User Interface Bug #10915: ugly dialogs
- The 9-th issue is quite clear.
>[MAJOR] functional EmbeddedWebHandler.<init>: Still constructs new DojoToolkitHandle... - 10:43 AM User Interface Bug #10915: ugly dialogs
- Th 8-th issue should be discussed because we should not need to send mouse and key events to the business layer. It i...
- 10:28 AM User Interface Bug #10915: ugly dialogs
- At least we need to add comments before @evt.key = undefined || evt.key "Unidentified" || evt.key ""@
- 10:25 AM User Interface Bug #10915: ugly dialogs
- The 7th issue is due to unclear code that was from Playwright and Lyra. I proposed to add the guard here. If this one...
- 10:22 AM User Interface Bug #10915: ugly dialogs
- The 6th issue must be discussed because I do not know why it should be consumed.
>[MAJOR] functional CHUIKeyboardRea... - 10:14 AM User Interface Bug #10915: ugly dialogs
- This one is simple but should be discussed, The proposed solution is to remove title.
>[MAJOR] functional ssoReauth.... - 10:13 AM User Interface Bug #10915: ugly dialogs
- The 4th issue is similar to 3d.
>[MAJOR] functional ssoReauth.handleSsoReauth: reauthDialog.show() is asynchronous (... - 10:11 AM User Interface Bug #10915: ugly dialogs
- The third issue looks bad because adding @await@ requires to add @async@ marker the hosted function.
>[MAJOR] funct... - 10:03 AM User Interface Bug #10915: ugly dialogs
- The second issue is really came from my changes in which I did the dialog without closed button x but forgot to remov...
- 10:00 AM User Interface Bug #10915: ugly dialogs
- The first issue I should discuss here...
- 09:58 AM User Interface Bug #10915: ugly dialogs
- OK. Thank you. I see.
- 09:49 AM User Interface Bug #10915 (WIP): ugly dialogs
- 09:49 AM User Interface Bug #10915: ugly dialogs
- Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > These issues are shuffled from AI review to another one. Could y... - 09:31 AM User Interface Bug #10915 (Review): ugly dialogs
- 09:20 AM User Interface Bug #10915: ugly dialogs
- I would reject them all.
- 09:19 AM User Interface Bug #10915: ugly dialogs
- These issues are shuffled from AI review to another one. Could you select the ones that can be fixed?
- 08:21 AM User Interface Bug #10915: ugly dialogs
- OK. I added the guide for this code. Could you review the last code rev 16620. I tried to fix the most issues.
05/19/2026
- 06:15 AM User Interface Bug #10915 (Review): ugly dialogs
- Please review the last fixes rev. 16605 (10915a).
- 06:14 AM User Interface Bug #10915 (WIP): ugly dialogs
05/15/2026
- 09:07 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- Due to #11401 I should include a hot patch into @9709e@ that removes @deleteAuthCookie(request, response);@ logic fro...
- 09:03 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- Hynek Cihlar wrote:
> Sergey, when you do review for yourself please don't post it here. It adds a lot of noise and ... - 07:39 AM User Interface Bug #10915: ugly dialogs
- Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Hynek, what was the reason that this code was placed at the top ... - 07:36 AM User Interface Bug #10915: ugly dialogs
- Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Hynek, what was the reason that this code was placed at the top ... - 04:22 AM User Interface Bug #10915 (Feedback): ugly dialogs
- Hynek, we need to discuss #10915-178 before I finalized the code for the review.
05/14/2026
- 03:57 PM User Interface Bug #10915: ugly dialogs
- Committed rev 16603(10915a) should fix most found issues (those that can be fixed) except
* *[MAJOR]* _functional... - 12:03 PM User Interface Bug #10915: ugly dialogs
- Hynek, what was the reason that this code was placed at the top before logKeyEvent(evt, "keypress"); and guards?
<pr... - 07:41 AM User Interface Bug #10915: ugly dialogs
- Committed revision 16600 (10915a) fixed
*[MAJOR]* functional startupServer (EmbeddedWebServerImpl): When DOJO... - 09:30 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- I got this result that can be considered for the review. These functional MAJORS are from 9709e changes that we discu...
- 07:49 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- h1. FWD Code Review — Branch 9709e (revs 16563..16579, round 3)
h2. Previously fixed (verified)
* *[MAJOR]* _fu... - 06:53 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- h1. FWD Code Review — Branch 9709e (revs 16563..16578, round 2)
h2. Previously fixed (verified)
* *[MAJOR]* _fu... - 05:57 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- h1. FWD Code Review — Branch 9709e (revs 16563..16576)
h2. Findings
* *[MAJOR]* _functional_ @WebClientsManager... - 04:57 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- Sergey Ivanovskiy wrote:
> I rebased 9709e and committed ClientsToPortsGenerator patch rev 16576 (9709e) to resolve ... - 04:45 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- These settings are not supported it is probably came from 9709a branch that are discussed with you but they are not a...
05/13/2026
- 03:18 PM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- I rebased 9709e and committed ClientsToPortsGenerator patch rev 16576 (9709e) to resolve client host number part of t...
- 01:55 PM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- >However, I should only need to contact cact_server directly from my laptop, because the server and brokers are conne...
- 01:51 PM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- Please correct the issue that I tried to describe that the server container on vm is accessed by the browser running ...
- 01:06 PM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- This message is confusing. cact_broker1 is a host that runs @BrokerCore@ client. cact_server is the application serve...
- 01:02 PM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- Roger, what is the code that produces this "cact_broker1’s server IP address could not be found."?
- 12:07 PM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- I did not test your configuration and tested the configuration that should prove that the web client spawned by the b...
- 10:00 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- Yes, two sections can be merged, xml configuration looks correct.
- 01:12 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- #9709-113 refers to the trunk code but 9709e gets rid of @remote@ nodes.
- 01:08 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- Roger, what version do you use for this test? If you are using the trunk version, then @remote@ node is still present...
- 07:05 AM User Interface Bug #10915: ugly dialogs
- I think that false options can be omitted so...
- 07:02 AM User Interface Bug #10915: ugly dialogs
- To remove the dialog title bar we need to set this option value @noTitle : true@...
- 06:54 AM User Interface Bug #10915: ugly dialogs
- Stefanel, thank you for help with this dialog checking! If we require Close dialog button (X) and the title, then
<... - 04:47 AM User Interface Bug #10915: ugly dialogs
- If it is important for the caller of @ModalDialog@ to wait until its method is completed, then @await@ construction s...
- 04:43 AM User Interface Bug #10915: ugly dialogs
- This one
*[MAJOR]* functional doRedirectToLogoutPage: In the window.fetch(logoutPage).catch(...) branch the new co... - 04:01 AM User Interface Bug #10915: ugly dialogs
- Yes, the current code looks suitable but there can be issues with ModalDialog usages that needs to be checked. Actual...
05/12/2026
- 02:01 PM User Interface Bug #10915: ugly dialogs
- This one
* *[MAJOR]* _functional_ @p2j.mouse.js@.@processMouseMove@: @isDialogDisplayed()@ guard at line 362 fire... - 01:40 PM User Interface Bug #10915: ugly dialogs
- Yes, this one @restoreConnectionDialog.setTitle(p2j.i18n.gettext("Server Unavailable"));@ can be removed because the ...
- 12:37 PM User Interface Bug #10915: ugly dialogs
- At the moment of writing the code this part was intentional:
*[MAJOR]* functional ModalDialog.close: Bypasses hide... - 12:35 PM User Interface Bug #10915: ugly dialogs
- h1. FWD Code Review — Curated Findings
h2. Summary
20 files modified (2957 line diff). The prior CRITICAL findi... - 11:36 AM User Interface Bug #10915: ugly dialogs
- Finally I realized that @onHide@ and @onClose@ listeners should be protected and do not send any key and mouse events...
- 11:19 AM User Interface Bug #10915: ugly dialogs
- The current rev 16593 has this report
h1. FWD Code Review — Curated Findings
h2. Summary
This diff spans 20 ... - 10:47 AM User Interface Bug #10915: ugly dialogs
- Stefanel, could you help with the test case to check the reauth dialog style from @p2j.sso_reauth.js@?
- 09:58 AM User Interface Bug #10915: ugly dialogs
- Committed revision 16592 (10915a) fixed most of minor issues and I run new code review to collect what was left or ig...
- 05:38 AM User Interface Bug #10915: ugly dialogs
- Committed revision 16591.(10915a). Fixed critical and major issues found in the AI review (#10915a-155).
- 04:38 AM User Interface Bug #10915: ugly dialogs
- No, this is related to the dojo code. ...
- 04:28 AM User Interface Bug #10915: ugly dialogs
- I tested repeatedly the direct upload web functionality and found that buttons do not trigger actions if Enter was pr...
05/11/2026
- 11:32 AM User Interface Bug #10915 (WIP): ugly dialogs
- Some of those issues can be fixed. So I will change to WIP.
- 11:20 AM User Interface Bug #10915: ugly dialogs
- Running fwd-code-review reported these issues:
h1. FWD Code Review — Curated Findings
h2. Summary
The diff m... - 09:47 AM User Interface Bug #10915: ugly dialogs
- Committed revision 16588 (10915a) minor changes found by the gcd-code-style review.
- 07:53 AM User Interface Bug #10915: ugly dialogs
- Each time AI assistant based on Claude Code finds new issues. I rebased this branch 10915a up to rev 16587.
05/08/2026
- 03:43 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- I rebased 9709e up to rev 16571 to get new updates.
05/07/2026
- 12:02 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- Could you run only VM with one broker client container while the server and the database containers are hosted on you...
- 11:54 PM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- Roger, your client log messages look normal. My last messages for the locally installed application are similar, exce...
05/06/2026
- 05:11 PM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- Roger, I will be online within two hours.
- 05:02 PM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- !ScreenshotCookiesToCheckVersion.png!
- 03:33 PM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- OK, I will attach to your meeting room within 5 minutes. I should watch the video first.
- 02:17 PM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- We can schedule the Google meeting later this day to find root cause of this issue.
- 02:15 PM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- What is the log of the broker client that should be run on cactbrk1? Do you have the server log that this broker is r...
- 02:07 PM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- Please check using Chrome Web Developer Tools the root cause of 401. For doing this please check cookie, request, res...
- 02:01 PM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- Did you try https://cactbrk1:7449/index.html?token=a5df4a81146dcec130e8b9b28326ea8e in new tab?
- 01:23 PM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- Please post the jconsole, 401 code means unauthorized access to the resources.
- 01:18 PM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- Do you use 9709e?
- 01:55 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- This is the client settings related to the debug agent ports if the remote debug is needed:...
- 01:28 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- Roger Borrello wrote:
> Should my configuration work any better (or worse) with *trunk_16543*?
What do you mean? 97... - 12:55 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- Roger, please look at your directory settings (#9709-889) and check the access to your certificates in the client xml...
05/05/2026
- 01:09 PM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- 9709b should be moved to the dead branches because it was never merged into the trunk and should not.
- 01:05 PM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- This file shows the changes needed to work with 9709e and ...
05/01/2026
- 02:51 PM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- Sorry for my late response, I should rebuild FWD certificates and tested the broker setup and the broker setup with t...
- 08:47 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- I did not test broker setup.
- 08:29 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- Greg Shah wrote:
> Constantin Asofiei wrote:
> > Sergey Ivanovskiy wrote:
> > > Thank you! Yes, I asked for help w... - 08:22 AM User Interface Bug #10915 (Review): ugly dialogs
04/30/2026
- 04:03 PM User Interface Bug #10915: ugly dialogs
- Committed revision 16570 (10915a) should fix the most issues except
>*[MINOR]* performance @ModalDialog.createDojoDi... - 02:44 PM User Interface Bug #10915: ugly dialogs
- >*[MINOR]* performance @p2j.dialogs Set@: Now stores dialog ID strings rather than DOM nodes. If two @ModalDialog@ in...
- 02:41 PM User Interface Bug #10915: ugly dialogs
- >*[MINOR]* functional @ModalDialog@: @this.removeTrigger = removeTrigger;@ was removed but @this.addTrigger@ remains....
- 07:57 AM User Interface Bug #10915: ugly dialogs
- >*[MAJOR]* functional @ModalDialog.doDialogLayout@: Interleaves DOM writes and reads in a way that forces layout thra...
- 07:12 AM User Interface Bug #10915: ugly dialogs
- >@[MINOR]@ functional @ModalDialog.show@: When @show()@ is called while @isVisible()@ is already true, the new code c...
- 06:41 AM User Interface Bug #10915: ugly dialogs
- >*[MAJOR]* functional @chooseFiles@: The new @dojo.connect(u, "onProgress", ...)@ handler unconditionally calls @acti...
- 06:34 AM User Interface Bug #10915: ugly dialogs
- >*[MAJOR]* functional @onKeyDown@: Moving the @p2j.isDialogDisplayed()@ early-return to the start of @keydown@ skips ...
- 06:02 AM User Interface Bug #10915: ugly dialogs
- Hynek Cihlar wrote:
> *Code review 10915a revisions 16537..16564*
>
> * *[CRITICAL]* _functional_ @ModalDialog@.@...
04/27/2026
- 02:06 PM User Interface Bug #10915: ugly dialogs
- Rebased rev. 16564 (10915a).
04/25/2026
- 01:47 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- I tested a standalone direct file upload testcase with the current trunk and did not find a regression. All web clien...
- 11:58 PM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- Eugenie Lyzenko wrote:
> Sergey Ivanovskiy wrote:
> > 9709d has been merged into the trunk as rev 16534. 9709d will...
04/24/2026
- 08:03 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- 9709d has been merged into the trunk as rev 16534. 9709d will be archived.
- 08:02 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- Thank you! Yes, I asked for help with 9709e testing and waiting approvals for this commit (#9709-846).
- 04:31 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- Constantin, I accidentally missed Roger's commit, so we need to wait until Roger will commit the fix. I guess we shou...
- 04:27 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- Roger Borrello wrote:
> Constantin Asofiei wrote:
> > I think the 2 fail cases need to be fixed.
>
> Fixes in re... - 04:17 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- 9709d is ready, the current rev. 16559.
- 03:20 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- Constantin Asofiei wrote:
> 9709d can be merged after 9709e (or before if 9709e takes some more time).
OK. Updating... - 02:48 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- Eugenie Lyzenko wrote:
> Sergey,
>
> What troubles you have with M to use? May be I missed some tests in my smoke...
04/23/2026
- 02:37 PM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- Eugenie, 9709e is based on rev 16533.
- 02:36 PM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- 9709e was updated up to rev 16545 over the current trunk rev 16533.
- 12:56 PM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- Should I rebase 9709e?
- 12:49 PM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- OK, I will fix this in the documentation. I have strange issues in my local system and would like that 9709e will be ...
- 12:40 PM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- Greg Shah wrote:
> Sergey: Have you completed the documentation changes in item 1 from #9709-807?
Yes, I added one ... - 11:20 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- Yes, 9709e should not affect any existing configurations. I tested Hotel_Gui and the customer application.
- 07:32 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- Greg, I have system issues because for Ubuntu 24.04 virtual environment SSO plugin works properly with 9709e. Thus, 9...
- 03:08 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- Thank you, Nginx does not matter. It means that I have local issues.
- 12:09 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server
- Sergey Ivanovskiy wrote:
> According to spawn error *The spawn process failed with 149 error.* the spawn code was fa...
Also available in: Atom