=== modified file 'src/com/goldencode/p2j/ui/chui/ThinClient.java' --- old/src/com/goldencode/p2j/ui/chui/ThinClient.java 2025-08-27 08:21:49 +0000 +++ new/src/com/goldencode/p2j/ui/chui/ThinClient.java 2025-09-08 08:09:30 +0000 @@ -3122,6 +3122,7 @@ ** server context. ** Updated error output to allow client-side code to be executed in server context. ** 1050 SB 20250718 Do not resolve the focus when the focus frame gets hidden for GUI. Refs #10273. +** 1051 PMP 20250908 Added finest logging for tab and return key input events. */ /* @@ -22109,6 +22110,20 @@ int key = (evt == null ? KeyInput.CHAR_UNDEFINED : evt.keyCode()); int keyState = (evt == null ? 0 : evt.getKeyState()); int action = (evt == null ? KeyInput.CHAR_UNDEFINED : evt.actionCode()); + + if (action == Keyboard.KA_TAB) + { + LOG.finest("TAB key dispatched for source = " + src); + } + else if (action == Keyboard.KA_RETURN) + { + LOG.finest("Return key dispatched for source = " + src); + } + else if (action == Keyboard.SE_CHOOSE) + { + LOG.finest("Choose key dispatched for source = " + src); + } + // skip developer events U1-U10 if (!Keyboard.isDevEvent(action)) === modified file 'src/com/goldencode/p2j/ui/client/WindowManager.java' --- old/src/com/goldencode/p2j/ui/client/WindowManager.java 2025-09-01 07:32:45 +0000 +++ new/src/com/goldencode/p2j/ui/client/WindowManager.java 2025-09-08 07:15:07 +0000 @@ -156,8 +156,6 @@ ** 076 AI 20250603 Changed forceActivateWindow to use gd.moveToTop instead of wm.moveToTop. ** 077 HC 20250606 ACTIVE-WINDOW can only hold WINDOW widget instances. ** 078 PMP 20250721 Added isMenuDisplayed method. -** 079 PMP 20250828 Added finest level logging when windows are opened and closed, excluding tooltips. -** PMP 20250901 Updated CentralLogger initialization to use getName, instead of getSimpleName. */ /* ** This program is free software: you can redistribute it and/or modify @@ -239,7 +237,7 @@ public class WindowManager { /** The logger */ - private static final CentralLogger LOG = CentralLogger.get(WindowManager.class.getName()); + private static final CentralLogger LOG = CentralLogger.get(WindowManager.class.getSimpleName()); /** Stores context-local state variables. */ private static final ContextLocal work = @@ -395,12 +393,6 @@ wa.windowIDs.put(widInt, window); wa.windowIDSet.add(widInt); } - - if (!(window instanceof OverlayWindow && - ((OverlayWindow) window).getRelativeTo() == WidgetLocationRef.RELATIVE_TO_CURSOR)) - { - LOG.finest(window + " opened."); - } } } } @@ -1333,12 +1325,6 @@ window.destroy(); removeNoDestroy(window); - - if (!(window instanceof OverlayWindow && - ((OverlayWindow) window).getRelativeTo() == WidgetLocationRef.RELATIVE_TO_CURSOR)) - { - LOG.finest(window + " closed."); - } } /** === modified file 'src/com/goldencode/p2j/ui/client/event/EventManager.java' --- old/src/com/goldencode/p2j/ui/client/event/EventManager.java 2025-09-01 07:32:45 +0000 +++ new/src/com/goldencode/p2j/ui/client/event/EventManager.java 2025-09-08 07:15:07 +0000 @@ -65,7 +65,6 @@ ** 031 SBI 20250317 Applied new KeyInput constructor. ** 032 SBI 20250515 Applied KeyCode.isPrintableCodePoint() to provide data for KeyInput event ** to support unicode characters. -** 033 PMP 20250901 Added finest logging for tab and enter key input events. */ /* ** This program is free software: you can redistribute it and/or modify @@ -444,19 +443,6 @@ } wa.queue.post(event); - - if (event instanceof KeyInput) - { - int action = ((KeyInput) event).actionCode(); - if (action == Keyboard.KA_TAB) - { - LOG.finest("TAB key input event received."); - } - else if (action == Keyboard.KA_RETURN) - { - LOG.finest("RETURN key input event received."); - } - } } } === modified file 'src/com/goldencode/p2j/ui/client/gui/ButtonListGuiImpl.java' --- old/src/com/goldencode/p2j/ui/client/gui/ButtonListGuiImpl.java 2025-08-28 10:31:21 +0000 +++ new/src/com/goldencode/p2j/ui/client/gui/ButtonListGuiImpl.java 2025-09-08 07:09:42 +0000 @@ -2630,7 +2630,7 @@ @Override public String toString() { - return "Item{" + String.valueOf(getId()) + ", \"" + textWidget.getText() + "\"}"; + return "Item [id=" + String.valueOf(getId()) + ", title=" + textWidget.getText() + "]"; } } } === modified file 'src/com/goldencode/p2j/ui/client/gui/ModalWindow.java' --- old/src/com/goldencode/p2j/ui/client/gui/ModalWindow.java 2025-06-18 13:51:23 +0000 +++ new/src/com/goldencode/p2j/ui/client/gui/ModalWindow.java 2025-09-08 08:10:12 +0000 @@ -2,7 +2,7 @@ ** Module : ModalWindow.java ** Abstract : Base class for modal windows ** -** Copyright (c) 2015-2024, Golden Code Development Corporation. +** Copyright (c) 2015-2025, Golden Code Development Corporation. ** ** -#- -I- --Date-- ---------------------------------Description---------------------------------- ** 001 HC 20150612 Initial version. @@ -82,6 +82,7 @@ ** 043 HC 20240806 Added support for displaying frame widget in an overlay window. ** 044 PMP 20240826 Implemented getRelativeTo method. ** 045 AI 20240925 Added catch of WindowEmulatorNotFoundException in processEvents. +** 046 PMP 20250908 Added finest logging when a modal window is shown. */ /* ** This program is free software: you can redistribute it and/or modify @@ -480,6 +481,7 @@ if (isVisible()) return; + LOG.finest("Window " + this + " was shown."); // to preserve the assigned modal window owner TopLevelWindow owner = getOwner(); @@ -559,7 +561,7 @@ { if (!isVisible()) return; - + // The order of super.hide() and GuiWindowCommons.hide(this) is important, otherwise // an incorrect window will be activated by GuiWindowCommons.hide(this). super.hide(); === modified file 'src/com/goldencode/p2j/ui/client/widget/TitledWindow.java' --- old/src/com/goldencode/p2j/ui/client/widget/TitledWindow.java 2024-01-25 14:28:48 +0000 +++ new/src/com/goldencode/p2j/ui/client/widget/TitledWindow.java 2025-09-08 08:05:35 +0000 @@ -2,7 +2,7 @@ ** Module : TitledWindow.java ** Abstract : Window with title. ** -** Copyright (c) 2010-2022, Golden Code Development Corporation. +** Copyright (c) 2010-2025, Golden Code Development Corporation. ** ** -#- -I- --Date-- ---------------------------------Description---------------------------------- ** 001 SIY 20100629 Created initial version @@ -59,6 +59,7 @@ ** 035 VVT 20220202 findMouseSource(MouseEvt) removed. See #6013. ** VVT 20220215 Change 13474 for #6013 temporary reverted (caused multiple regressions, ** need to be completed). +** 036 PMP 20250908 Added finest logging when showing / hiding the window. */ /* ** This program is free software: you can redistribute it and/or modify @@ -119,8 +120,10 @@ import com.goldencode.p2j.ui.chui.ThinClient; import com.goldencode.p2j.ui.client.*; import com.goldencode.p2j.ui.client.event.*; +import com.goldencode.p2j.ui.client.gui.OverlayWindow; import com.goldencode.p2j.ui.client.layout.*; import com.goldencode.p2j.util.*; +import com.goldencode.p2j.util.logging.CentralLogger; /** * Simple window with title. @@ -132,6 +135,9 @@ { /** Window title. */ private String title; + + /** Logger. */ + private static final CentralLogger LOG = CentralLogger.get(TitledWindow.class); /** * Constructor. @@ -197,6 +203,11 @@ // window no longer exists. for it to be removed, it must be destroyed forceVisibility(false); + if (!(this instanceof OverlayWindow && + ((OverlayWindow) this).getRelativeTo() == WidgetLocationRef.RELATIVE_TO_CURSOR)) + { + LOG.finest("Window " + this + " was hidden."); + } } /** @@ -343,6 +354,12 @@ return; } + if (!(this instanceof OverlayWindow && + ((OverlayWindow) this).getRelativeTo() == WidgetLocationRef.RELATIVE_TO_CURSOR)) + { + LOG.finest("Window " + this + " was shown."); + } + super.show(); WindowManager.addWindow(this);