Bug #10104
Analyze performance drop after rev. 15963
Status:
New
Priority:
Normal
Assignee:
-
Target version:
-
Start date:
Due date:
% Done:
0%
billable:
No
vendor_id:
GCD
case_num:
version_reported:
version_resolved:
reviewer:
production:
No
env_name:
topics:
History
#1 Updated by Andrei Iacob about 1 year ago
This task aims to analyze the performance drop of trunk rev 15963.
In one of our testing, a performance decrease of 1.6% and 2% was identified.
From Alexandru:
I suppose this comes from the extra context look-ups that should be done to retrieve the cache. The execution paths until this place (FqlPreprocessor creation) do not store any context-local object, so we can't cache this earlier ... I think we need to pay the price of "identifying the context" at least once.
Suggest caching the context somewhere upstream, so we don't call context.get() each time we need a FqlPreprocessor. BTW: I wonder if the implementation calls context.get() twice (once for cache with args and one for cache without args). We can continue discussion in that task.