Project

General

Profile

Bug #10518

Property getter call is ignored from conversion

Added by Paul Bodale 11 months ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Paul Bodale
Target version:
-
Start date:
Due date:
% Done:

100%

billable:
No
vendor_id:
GCD
case_num:
version_reported:
version_resolved:
production:
No
env_name:
topics:

History

#1 Updated by Paul Bodale 11 months ago

  • Assignee set to Paul Bodale

The test case:

CLASS task.PlayCls:

    DEFINE PUBLIC PROPERTY prop AS CHARACTER INITIAL "NO EFFECT" NO-UNDO
      GET. SET.

   DEFINE PRIVATE PROPERTY c AS CHARACTER NO-UNDO
      GET:
         prop = "UPDATED".
         RETURN c.
      END.
      PRIVATE SET.

   METHOD PUBLIC CHARACTER test():
      c. //This instruction is ignored
      RETURN prop.
   END.

END CLASS.

The test method converts to this:

@LegacySignature(type = Type.METHOD, name = "test", returns = "CHARACTER")
   public character test()
   {
      return function(PlayCls.class, this, "test", character.class, new Block((Body) () -> 
      {
         storeReturnValue(getProp());
      }));
   }

The first instruction of this method is disregarded. The method returns "NO EFFECT".

#2 Updated by Paul Bodale 11 months ago

  • Subject changed from Property getter is ignored from conversion to Property getter call is ignored from conversion

#3 Updated by Paul Bodale 11 months ago

  • Status changed from New to WIP
  • % Done changed from 0 to 100
  • reviewer Constantin Asofiei added

Created task branch 10518a and committed rev. 16148 that fixes this issue.

#4 Updated by Paul Bodale 11 months ago

  • Status changed from WIP to Review

I checked and this solves the initial issue for which this task has been opened.

Standing by for review.

#5 Updated by Constantin Asofiei 11 months ago

  • Status changed from Review to Internal Test

I'm OK with the changes. Nice find.

Please run conversion with a small project which has OO and if it works, lets merge it.

#6 Updated by Paul Bodale 11 months ago

I ran conversion testing on a customer application and it showed no differences between converting with this branch and with trunk rev 16147.

#8 Updated by Constantin Asofiei 10 months ago

  • Status changed from Internal Test to Merge Pending

Please merge to trunk now.

#9 Updated by Paul Bodale 10 months ago

  • Status changed from Merge Pending to Internal Test

Branch 10518a was merged into trunk as rev. 16181 and archived.

#10 Updated by Paul Bodale 10 months ago

  • Status changed from Internal Test to Test

#11 Updated by Constantin Asofiei 6 months ago

  • Status changed from Test to Closed

Also available in: Atom PDF