Project

General

Profile

Bug #11114

« Previous | Next »

NPE when redirecting terminal

Added by Razvan-Nicolae Chichirau 6 months ago. Updated 4 months ago.

Status:
Test
Priority:
Normal
Assignee:
Razvan-Nicolae Chichirau
Target version:
-
Start date:
Due date:
% Done:

100%

billable:
No
vendor_id:
GCD
case_num:
version_reported:
version_resolved:
reviewer:
Constantin Asofiei
production:
No
env_name:
topics:

History

#1 Updated by Razvan-Nicolae Chichirau 6 months ago

The following testcase generates an NPE with trunk/rev. 16338.

session:system-alert-boxes = false.
def var h as handle.

output to "a.txt".
h = h:next-sibling.
output close.

#2 Updated by Razvan-Nicolae Chichirau 4 months ago

  • Status changed from New to WIP
  • Assignee set to Razvan-Nicolae Chichirau
  • % Done changed from 0 to 100
  • reviewer Constantin Asofiei added

When an error message was displayed in redirected mode, without ALERT-BOX, the request was sent to the legacy message workflow instead of the current stream.

Constantin: Please review 11114a/rev. 16469.

#3 Updated by Razvan-Nicolae Chichirau 4 months ago

  • Status changed from WIP to Review

#4 Updated by Constantin Asofiei 4 months ago

In ChUI, the message also appears at the terminal/message area. In GUI, it does not appear in message area. This is in OpenEdge.

Did you test with ChUI in OpenEdge and FWD?

#5 Updated by Razvan-Nicolae Chichirau 4 months ago

Yes. In ChUI, Window.message() is invoked which sends the text to both the terminal and stream:

// in redirected mode we output to both the terminal and to the stream
// (except for batch clients that output only to the stream), but we output
// the unmodified text, not the text that may have been truncated above
if (switched)
{
   redir = tc.sendToStream(original);
}
...
displayMessage(...)

This was also with trunk, since changes from 11114a affect only GUI clients.

#6 Updated by Constantin Asofiei 4 months ago

  • Status changed from Review to Internal Test

Thanks, please put it in test.

#7 Updated by Razvan-Nicolae Chichirau 4 months ago

Testing that passed:
  • multiple tests with redirected terminal
  • Smoke-tests on 2 customer apps
  • unit tests from a customer app

No ChUI regression testing needed as above the modified code there is:

if (isChui())
{
   ...
   return;
}

If this is enough, 11114a should be merged.

#8 Updated by Radu Apetrii 4 months ago

  • Status changed from Internal Test to Merge Pending

Looks good from my point of view. 11114a can be merged right now.

#9 Updated by Razvan-Nicolae Chichirau 4 months ago

  • Status changed from Merge Pending to Test

Branch 11114a was merged into trunk as rev. 16503 and archived.

Also available in: Atom PDF