FWD » Core Development » User Interface

The issue is described in #11545-13.

Created task branch 11592a from FWD trunk revision 16634.

Code review 11592a revisions 16634..16635

I didn't test, but worth to check:

• [MAJOR] functional BrowseGuiImpl.rowClickSecondPart: The deferred toggle block can dereference a null editor. When currColumn toggleColumn, switchToggle stays true and getActiveToggleBox() (which is return (ToggleBox) activeEditor) is called with no isEditorActive()/null guard, so toggle.getValue() throws an NPE if the editor was torn down. Concrete trigger: user first-clicks a toggle-box cell in a not-currently-edited row; startEdit() returns true (editor active), the else if (toggleClicked) branch records toggleColumn = currColumn, then the guard at line 5770 fires invokeRowEntryTrigger(oldFocusId) — a synchronous ROW-ENTRY dispatch via ThinClient.invokeTriggers. If the application ROW-ENTRY trigger ends browse editing without changing the column (e.g. APPLY "ENTRY" TO a widget outside the browse), finishStopEdit() sets activeEditor = null but leaves currColumn unchanged. Control then reaches the deferred block with currColumn toggleColumn, the inner if is skipped, and getActiveToggleBox() returns null → NPE. Because the NPE is not a BrowseException, the method's catch does not swallow it and the click handler crashes. This window is new: the pre-change code flipped the toggle in the else if branch before the triggers ran, when activeEditor was freshly non-null. Note the asymmetry — the currColumn != toggleColumn path re-guards via switchToggle = startEdit(), and every other getActiveToggleBox() call site in Browse/BrowseGuiImpl is guarded by isEditorToggleBox()/isEditorActive(), but the equal-column path here is not. Fix: gate the equal-column flip on isEditorActive() (or null-check getActiveToggleBox()) as well. [verdict: CONFIRMED]

Hynek, I've added a guard condition in 11592a rev 16636, please review.

Stanislav Lomany wrote:

Hynek, I've added a guard condition in 11592a rev 16636, please review.

Code review. It looks good.