Project

General

Profile

Bug #11914

function udf.todate(timestamp with time zone) does not exist

Added by Alexandru Lungu 15 days ago. Updated 1 day ago.

Status:
Test
Priority:
Normal
Assignee:
Stefanel Pezamosca
Target version:
-
Start date:
Due date:
% Done:

100%

billable:
No
vendor_id:
GCD
case_num:
version_reported:
version_resolved:
reviewer:
Alexandru Lungu
production:
No
env_name:
topics:

History

#1 Updated by Alexandru Lungu 15 days ago

  • Assignee set to Stefanel Pezamosca

There is no toDate UDF (for PostgreSQL at least) that is compatible with a DB level field that is defined as timestamp with timezone. There is only one variant with timestamp without timezone.

#2 Updated by Stefanel Pezamosca 15 days ago

  • Status changed from New to WIP
  • % Done changed from 0 to 90
  • reviewer Alexandru Lungu added

There is a udf.todate(timestamp without timezone) and a udf.todate(timestamp which is just the same. timestamp without timezone == timestamp.

It will not be enough to just add the right overload with timestamp with timezone, it needs to read the _offset column to make sure it gives the correct result.

#3 Updated by Stefanel Pezamosca 15 days ago

  • % Done changed from 90 to 50

#4 Updated by Stefanel Pezamosca 15 days ago

  • Status changed from WIP to Review
  • % Done changed from 50 to 100

11914a branch was created from trunk 16771:

Committed to 11914a revision 16772:
  • Fixed udf.todate(ts) for datetime-tz to take timestamp with time zone (was timestamp). Added udf.todate(ts, tz), which returns the date in the datetime-tz offset.

#5 Updated by Alexandru Lungu 5 days ago

  • Status changed from Review to Internal Test
  • [MINOR] style udfs.sql todate: history entry 014 says the 1-arg udf.todate now takes timestamp with time zone and that there is a new 2-arg overload. It doesn't say the 1-arg version changed from IMMUTABLE STRICT to STABLE STRICT. Add that to the entry.

Otherwise, changes are good. Please proceed with testing.

#6 Updated by Stefanel Pezamosca 1 day ago

Please see 11914a revision 16773.
Otherwise, testing passed on my side. Are there any other tests you'd like to run?

#7 Updated by Alexandru Lungu 1 day ago

  • Status changed from Internal Test to Merge Pending

Please merge 11914a to trunk now.

#8 Updated by Stefanel Pezamosca 1 day ago

  • Status changed from Merge Pending to Test

Branch 11914a was merged into trunk as rev. 16798 and archived.

Also available in: Atom PDF