Project

General

Profile

Bug #5068

error-status:error is invalid

Added by Stanislav Lomany over 3 years ago. Updated over 3 years ago.

Status:
WIP
Priority:
Normal
Assignee:
Stanislav Lomany
Target version:
-
Start date:
01/06/2021
Due date:
% Done:

0%

billable:
No
vendor_id:
GCD
case_num:

no-error.p Magnifier (2.69 KB) Stanislav Lomany, 01/07/2021 07:23 AM

History

#1 Updated by Stanislav Lomany over 3 years ago

  • File no-error.p added

Testcase attached. As far as I tested, 4GL error-status:error is true only when an error is raised rather displayed. FWD behavior differs from case to case (i.e. error number) so I'll fix the cases I have found.

#2 Updated by Stanislav Lomany over 3 years ago

  • File deleted (no-error.p)

#3 Updated by Stanislav Lomany over 3 years ago

I found two issues:
  1. If an error is displayed using ErrorManager.displayError and silent mode is active, then the error should be added to ERROR-STATUS, but not displayed.
    === modified file 'src/com/goldencode/p2j/util/ErrorManager.java'
--- src/com/goldencode/p2j/util/ErrorManager.java    2020-09-13 21:45:15 +0000
+++ src/com/goldencode/p2j/util/ErrorManager.java    2021-01-07 11:34:36 +0000
@@ -2322,8 +2322,15 @@
     */
    public static void displayError(int num, String msg, boolean prefix)
    {
-      displayError(buildErrorText(num, msg, prefix));
-      addRaisedCondition(new int[] {num});
+      if (isSilent())
+      {
+         recordOrShowError(num, msg, false, prefix, false);
+      }
+      else
+      {
+         displayError(buildErrorText(num, msg, prefix));
+         addRaisedCondition(new int[]{num});
+      }
    }

    /**

    Does the code look good to you?
  2. On per-case basis isError parameter of ErrorManager.recordOrShowError should be fixed for some cases:
    === modified file 'src/com/goldencode/p2j/ui/BrowseWidget.java'
--- src/com/goldencode/p2j/ui/BrowseWidget.java    2021-01-04 16:55:11 +0000
+++ src/com/goldencode/p2j/ui/BrowseWidget.java    2021-01-07 11:24:57 +0000
@@ -8027,7 +8027,7 @@
       ErrorManager.recordOrShowError(4053,
             String.format("**Unable to set %s because the BROWSE widget has been realised",
                           attributeName),
-            false, false);
+            false, false, false);
    }

    /**

=== modified file 'src/com/goldencode/p2j/util/handle.java'
--- src/com/goldencode/p2j/util/handle.java    2020-12-25 16:37:53 +0000
+++ src/com/goldencode/p2j/util/handle.java    2021-01-07 11:00:30 +0000
@@ -766,7 +766,7 @@

          String type = h.unwrapType().getResourceType().toStringMessage();
          String msg = String.format(errMsg, attr, type);
-         ErrorManager.recordOrShowError(errNum, msg, false, true);
+         ErrorManager.recordOrShowError(errNum, msg, false, true, false);
       }
    }

Also available in: Atom PDF