Project

General

Profile

Bug #5371

All aspects from p2j.jar applied to project builds indiscriminately

Added by Roger Borrello about 5 years ago. Updated about 5 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Target version:
-
Start date:
Due date:
% Done:

0%

billable:
No
vendor_id:
GCD
case_num:
version_reported:
version_resolved:
reviewer:
production:
No
env_name:
topics:

History

#1 Updated by Roger Borrello about 5 years ago

At least when I build my testcases, I get the following:

compile-aspectj:
     [iajc] warning at /home/rfb/projects/fwd/3821c_dev/build/lib/p2j.jar!com/goldencode/p2j/aspects/ui/ConfigFieldSetterAspect.class::0 advice defined in com.goldencode.p2j.aspects.ui.ConfigFieldSetterAspect has not been applied [Xlint:adviceDidNotMatch]
     [iajc] warning at /home/rfb/projects/fwd/3821c_dev/build/lib/p2j.jar!com/goldencode/p2j/aspects/ui/LocationCacheAspect.class::0 advice defined in com.goldencode.p2j.aspects.ui.LocationCacheAspect has not been applied [Xlint:adviceDidNotMatch]
     [iajc] warning at /home/rfb/projects/fwd/3821c_dev/build/lib/p2j.jar!com/goldencode/p2j/aspects/ui/SyncCoordinatesAspect.class::0 advice defined in com.goldencode.p2j.aspects.ui.SyncCoordinatesAspect has not been applied [Xlint:adviceDidNotMatch]
     [iajc] warning at /home/rfb/projects/fwd/3821c_dev/build/lib/p2j.jar!com/goldencode/p2j/aspects/ui/UIStatementsAspect.class::0 advice defined in com.goldencode.p2j.aspects.ui.UIStatementsAspect has not been applied [Xlint:adviceDidNotMatch]
     [iajc] warning at /home/rfb/projects/fwd/3821c_dev/build/lib/p2j.jar!com/goldencode/util/LoggingAspect.class::0 advice defined in com.goldencode.util.LoggingAspect has not been applied [Xlint:adviceDidNotMatch]
     [iajc] warning at /home/rfb/projects/fwd/3821c_dev/build/lib/p2j.jar!com/goldencode/p2j/aspects/LoadLegacyClassAspect.class::0 advice defined in com.goldencode.p2j.aspects.LoadLegacyClassAspect has not been applied [Xlint:adviceDidNotMatch]
     [iajc] warning at /home/rfb/projects/fwd/3821c_dev/build/lib/p2j.jar!com/goldencode/p2j/ui/client/widgetbrowser/WidgetBrowserAspect.class::0 advice defined in com.goldencode.p2j.ui.client.widgetbrowser.WidgetBrowserAspect has not been applied [Xlint:adviceDidNotMatch]
     [iajc] warning at /home/rfb/projects/fwd/3821c_dev/build/lib/p2j.jar!com/goldencode/p2j/aspects/ui/SyncConfigChangesAspect.class::0 advice defined in com.goldencode.p2j.aspects.ui.SyncConfigChangesAspect has not been applied [Xlint:adviceDidNotMatch]

The target (and other tidbits) from my build.xml:

   <!-- path for aspect compilation -->
   <path id="aspectjCompile.classpath">
      <fileset dir="${p2jlib.home}">
        <include name="aspectjtools*.jar"/>
     </fileset>
   </path>

   <!-- path used when compiling Java classes -->
   <path id="compile.classpath">
      <fileset dir="${p2jlib.home}">
        <include name="*.jar"/>
     </fileset>
   </path>

   <path id="aspect.path">
      <fileset dir="${p2jlib.home}">
        <include name="p2j.jar"/>
     </fileset>
   </path>

   <!-- compile aspects -->
   <target name="compile-aspectj" depends="compile">

      <taskdef resource="org/aspectj/tools/ant/taskdefs/aspectjTaskdefs.properties">
          <classpath> 
            <path refid="aspectjCompile.classpath"/>
          </classpath>
      </taskdef> 

      <iajc destDir="${build.home}/classes.aop" 
            source="1.7" 
            target="1.7" 
            verbose="false" 
            showweaveinfo="false">
         <inpath>
            <pathelement location="${build.home}/classes" /> 
         </inpath>
         <aspectPath refid="aspect.path"/>
         <classpath>
            <path refid="compile.classpath"/>
            <path refid="aspectjCompile.classpath"/>
         </classpath>
      </iajc>

   </target>

There are also a couple of warnings when building 3821c:

> Task :ant-aspectj
[ant:iajc] warning at /home/rfb/projects/fwd/3821c_dev/build/classes!com/goldencode/util/LoggingAspect.class::0 advice defined in com.goldencode.util.LoggingAspect has not been applied [Xlint:adviceDidNotMatch]
[ant:iajc] warning at /home/rfb/projects/fwd/3821c_dev/build/classes!com/goldencode/p2j/aspects/LoadLegacyClassAspect.class::0 advice defined in com.goldencode.p2j.aspects.LoadLegacyClassAspect has not been applied [Xlint:adviceDidNotMatch]

Also available in: Atom PDF