Bug #6383
TAB-ITEM issues
90%
History
#1 Updated by Vladimir Tsichevski about 2 years ago
- File fix.diff
added
There are a number of known issues related to tab item list and related 4gl calls. This issue is to post these problems here.
Originally, I discovered most of these issues while working on #6305.
Problem 1¶
For unrealized frames:
- In OE the tab-stop-related attributes can be read and written,
NUM-TAB
attribute always returns the correct number of tab-stoppable widgets. - In FWD, tab-stop reading functions (
FIRST-TAB-ITEM
andLAST-TAB-ITEM
) returnunknown
, andNUM-TAB
always returns 0 .
Problem 2¶
Using a widget with TAB-STOP = FALSE
as the anchor in invalid for any 4gl method in OE, and should raise the error 4062.
The idea behind the fix: the FieldGroup.tabItems must always contain all and only field group member widgets, which have the TAB-STOP = TRUE. So:
- widgets must be filtered on that condition before they are placed in the list
- when the widget TAB-STOP attribute changes, the list must be updated accordingly
- no check for
TAB-STOP
attribute value is necessary for items in the list anymore.
Another difference: when a frame is realized, the tab order must reset back to the widget order in the frame definition. The task #6374 is created for this problem.
Problem 3¶
The Java method naming in inconsistent: moveAfterTab
, but moveBeforeTabItem
. Methods should better be renamed. These changes require re-conversion.
Problem 4¶
Errors 4083, 4078, 4062, 4077 should be reported with recordOrShowError
, not recordOrThrowError
.
The fix is attached as fix.diff
.
#2 Updated by Vladimir Tsichevski about 2 years ago
- File fix-method-names-inconsistency.diff
added
Vladimir Tsichevski wrote:
Problem 3¶
The Java method naming in inconsistent:
moveAfterTab
, butmoveBeforeTabItem
. Methods should better be renamed. These changes require re-conversion.
The fix is attached as fix-method-names-inconsistency.diff
.
#4 Updated by Vladimir Tsichevski about 2 years ago
- % Done changed from 0 to 80
#5 Updated by Vladimir Tsichevski about 2 years ago
- % Done changed from 80 to 90
Vladimir Tsichevski wrote:
Vladimir Tsichevski wrote:
Problem 3¶
The Java method naming in inconsistent:
moveAfterTab
, butmoveBeforeTabItem
. Methods should better be renamed. These changes require re-conversion.The fix is attached as
fix-method-names-inconsistency.diff
.
The fix committed as 3821c/13920.