FWD » Core Development » Base Language

From #8237-30:

There is a bug in LOG-MANAGER which isn't a show-stopper. See this test:

message "not for log-manager".

log-manager:logfile-name = "test1.log".
log-manager:write-message("test1").
log-manager:close-log().

// this error message is sent via ThinClient.applyChanges to logManagerService.write(sstate.logManagerRecords);
// why is not LegacyLogManagerImpl.resetEnabled called when the 'close-log' is called?
// this ends writing lots of "No file open. LOG-MANAGER logs discarded." warnings in the FWD client's STDERR
def var h as handle.
h:name = "aaa".

I've missed that close modifies logFile and isEnabled should be updated. Can you add this new line isEnabled.set(false); to LegacyLogManagerImpl in another branch, or we need a new branch?

   @Override
   public synchronized logical close(boolean isProcedureCall, boolean closeWriteExecutor)
   {
      isEnabled.set(false);
      if (isAppserver && isProcedureCall)
      {

I've tested it and it works fine with the change.

I think isEnabled.set(false); needs to be after if (isAppserver && isProcedureCall), correct? I'll use 8237a.

You're right, put it after that.