Project

General

Profile

Bug #9016

Improve performance in FQLPreprocessor by using astCache

Added by Dănuț Filimon almost 2 years ago. Updated 10 months ago.

Status:
Test
Priority:
Normal
Target version:
-
Start date:
Due date:
% Done:

100%

billable:
No
vendor_id:
GCD
case_num:
version_reported:
version_resolved:
trunk/16162
production:
No
env_name:
topics:

Related issues

Related to Database - Bug #7731: performance improvements for FQLPreprocessor Closed
Related to Base Language - Bug #10362: FastFindCache.L2Key uses the buffer alias in the FQL WIP

History

#1 Updated by Dănuț Filimon almost 2 years ago

  • Related to Bug #7731: performance improvements for FQLPreprocessor added

#2 Updated by Dănuț Filimon almost 2 years ago

The astCache added in #7731 is only used in FqlPreprocessor.parse(), but it can also be used in

private FQLPreprocessor(List<RecordBuffer> bound, List<RecordBuffer> definition, String where, boolean singleBuffer)

#3 Updated by Dănuț Filimon about 1 year ago

  • Status changed from New to WIP
  • Assignee set to Dănuț Filimon

Had a discussion with Artur and this task was mentioned. However, this might not improve the performance in his scenario.

#4 Updated by Dănuț Filimon about 1 year ago

  • % Done changed from 0 to 100
  • Status changed from WIP to Review
  • reviewer Alexandru Lungu added

Committed 9016a/15919. Added astCache to FQLPreprocessor().

Alexandru, please review.

#5 Updated by Alexandru Lungu 11 months ago

  • Related to Bug #10362: FastFindCache.L2Key uses the buffer alias in the FQL added

#6 Updated by Dănuț Filimon 11 months ago

Rebased 9016a to latest trunk/16114, the branch is now at revision 16115.

#7 Updated by Dănuț Filimon 11 months ago

Alexandru, let me know if you have any plans to review 9016a or add it directly to the work from #10362.

#8 Updated by Alexandru Lungu 11 months ago

  • Status changed from Review to Internal Test

I am ok with 9016a. Please proceed with testing.

#9 Updated by Dănuț Filimon 11 months ago

All regression tests passed, 9016a can be merged.

#10 Updated by Dănuț Filimon 10 months ago

  • Status changed from Internal Test to Merge Pending

I'll be merging 9016a now.

#11 Updated by Dănuț Filimon 10 months ago

  • version_resolved set to trunk/16162

Branch 9016a was merged into trunk as revision 16162 and archived.

#12 Updated by Dănuț Filimon 10 months ago

  • Status changed from Merge Pending to Test

Also available in: Atom PDF