Project

General

Profile

Bug #9873

FILL-IN: client crashes on CTRL-SHIFT-LEFT or CTRL-SHIFT-RIGHT

Added by Vladimir Tsichevski over 1 year ago. Updated about 1 year ago.

Status:
Test
Priority:
Normal
Assignee:
Vladimir Tsichevski
Target version:
-
Start date:
Due date:
% Done:

100%

billable:
No
vendor_id:
GCD
case_num:
version_reported:
15497
version_resolved:
reviewer:
Hynek Cihlar
production:
No
env_name:
topics:

History

#1 Updated by Vladimir Tsichevski over 1 year ago

  • reviewer Hynek Cihlar added

Support for these key combinations was introduced in revision 15947. These operations modify the caret position, which is stored in the local offset variable (FillInGuiImpl.processKeyEvent method), but the code does not update this cached value.

#2 Updated by Vladimir Tsichevski over 1 year ago

  • Status changed from New to WIP

#3 Updated by Vladimir Tsichevski over 1 year ago

  • Status changed from WIP to Review
  • % Done changed from 0 to 100

Fixed in 9873a rev. 15843. Please, review.

#4 Updated by Vladimir Tsichevski over 1 year ago

  • % Done changed from 100 to 90
  • Status changed from Review to WIP

Same issue for the CUT operation.

#5 Updated by Vladimir Tsichevski over 1 year ago

  • Status changed from WIP to Review
  • % Done changed from 90 to 100

Vladimir Tsichevski wrote:

Same issue for the CUT operation.

Fixed in rev. 15844. Please, review.

#6 Updated by Hynek Cihlar about 1 year ago

  • Status changed from Review to Internal Test

Code review 9873a. The changes look good.

What testing needs to be done?

#7 Updated by Hynek Cihlar about 1 year ago

+Hynek

#8 Updated by Vladimir Tsichevski about 1 year ago

Hynek Cihlar wrote:

Code review 9873a. The changes look good.

What testing needs to be done?

I think, none. ChUI is not related to the change.
I've rebased the branch to the latest trunk and re-tested. The fix still works.

#9 Updated by Hynek Cihlar about 1 year ago

  • Status changed from Internal Test to Merge Pending

Please merge 9873a to trunk.

#10 Updated by Alexandru Lungu about 1 year ago

Please also merge 9873a change to 8755c and updated #8755.

#11 Updated by Vladimir Tsichevski about 1 year ago

Hynek Cihlar wrote:

Please merge 9873a to trunk.

Done. Trunk rev. is now 16058.

#12 Updated by Alexandru Lungu about 1 year ago

  • Status changed from Merge Pending to Test

#13 Updated by Vladimir Tsichevski about 1 year ago

Alexandru Lungu wrote:

Please also merge 9873a change to 8755c and updated #8755.

Do you mean I shall apply the change without rebasing?

#14 Updated by Vladimir Tsichevski about 1 year ago

Alexandru Lungu wrote:

Please also merge 9873a change to 8755c and updated #8755.

Done.

Also available in: Atom PDF