Project

General

Profile

Activity

From 05/04/2026 to 06/02/2026

05/29/2026

01:09 AM Bug #11191 (Internal Test): ChUI: COMBO-BOX raises error 4058 on valid SCREEN-VALUE assignment
*Code review 11191a revisions 16548..16550*
The changes look good. Please go ahead with regression testing. Also run...
Hynek Cihlar

05/28/2026

10:55 AM Bug #11211: Improve source detection when dispatching mouse wheel events
Razvan-Nicolae Chichirau wrote:
> The idea behind @Addressed review from ...@ was that, since reviews have become mu...
Hynek Cihlar
06:17 AM Bug #11211: Improve source detection when dispatching mouse wheel events
Hynek Cihlar wrote:
> Btw., use more descriptive commit messages. @Addressed review from #1234-12@ requires addition...
Razvan-Nicolae Chichirau
06:04 AM Bug #11211 (Internal Test): Improve source detection when dispatching mouse wheel events
Hynek Cihlar
06:04 AM Bug #11211: Improve source detection when dispatching mouse wheel events
Razvan-Nicolae Chichirau wrote:
> Please check 11211a/rev. 16518.
The changes look good. Please go ahead with reg...
Hynek Cihlar
08:17 AM Bug #11343 (Review): Alert-box suddenly disppears when a specific item is selected from a drop-do...
*Hynek*: Please review 11343a/rev. 16576. Razvan-Nicolae Chichirau
03:26 AM Bug #11498: NPE during browse ADD-LIKE-COLUMN()
Testcase:... Razvan-Nicolae Chichirau
03:20 AM Bug #11498 (Test): NPE during browse ADD-LIKE-COLUMN()
Razvan-Nicolae Chichirau
02:53 AM Bug #11170 (Internal Test): The caret position is initially wrong for DECIMAL/INTEGER FILL-IN wi...
Razvan-Nicolae Chichirau wrote:
> Please check rev. 16565.
It's good, please go ahead with regression testing. Ch...
Hynek Cihlar

05/27/2026

02:50 PM Bug #11326: Reduce memory consumption of FWD clients
It is hard to provide an answer. What I know is that the server image spawns FWD client instances (so it should have ... Teodor Gorghe
01:17 PM Bug #11326: Reduce memory consumption of FWD clients
I know that all the thinning down that Teodor has done for this task is good... I could use some thinning myself! But... Roger Borrello
01:05 PM Bug #11326: Reduce memory consumption of FWD clients
Teodor Gorghe wrote:
> Committed the changes into *hotel_gui* revision *454*.
I made matching changes in *hotel* ...
Roger Borrello
12:33 PM Bug #10915 (Test): ugly dialogs
10915a was merged into the trunk as rev 16585 and then archived. Sergey Ivanovskiy
11:56 AM Bug #10915 (Merge Pending): ugly dialogs
Sergey Ivanovskiy wrote:
> Yes, I tested rev 16644 (10915a) but as rev 16645 is only a cleanup, then it seems done.
...
Hynek Cihlar
11:47 AM Bug #10915: ugly dialogs
Yes, I tested rev 16644 (10915a) but as rev 16645 is only a cleanup, then it seems done. Sergey Ivanovskiy
11:41 AM Bug #10915: ugly dialogs
No more testing planned? Hynek Cihlar
11:37 AM Bug #10915: ugly dialogs
Yes, Hotel, Hotel_GUI, the customers applications and testcases. Committed rev 16645 (10915a) removed commented code. Sergey Ivanovskiy
11:14 AM Bug #10915: ugly dialogs
Sergey Ivanovskiy wrote:
> OK. I tested manually all dialogs and Stefanel reviewed/tested Oidc dialogs. CHUI regress...
Hynek Cihlar
11:11 AM Bug #10915: ugly dialogs
OK. I tested manually all dialogs and Stefanel reviewed/tested Oidc dialogs. CHUI regression tests are passed. Sergey Ivanovskiy
10:56 AM Bug #10915: ugly dialogs
Sergey Ivanovskiy wrote:
> Sergey Ivanovskiy wrote:
> > I finished manual GUI testing of rev 16644 (10915a). The re...
Hynek Cihlar
09:15 AM Bug #10915 (Review): ugly dialogs
Sergey Ivanovskiy
09:13 AM Bug #10915: ugly dialogs
This is my last review for rev 16444(10915a)
*Modified areas:* com.goldencode.p2j.main (4 files), com.goldencode.p...
Sergey Ivanovskiy
09:09 AM Bug #10915: ugly dialogs
Sergey Ivanovskiy wrote:
> I finished manual GUI testing of rev 16644 (10915a). The rest tasks are CHUI regression t...
Sergey Ivanovskiy
09:03 AM Bug #10915: ugly dialogs
>CRITICAL] functional ModalDialog.close: When a `documentListener` keydown trigger handler awaits `dialog.close()`, t... Sergey Ivanovskiy
04:48 AM Bug #10915 (WIP): ugly dialogs
*Code review 10915a revisions 16580..16639*
Please check the following points. The critical one should be easy to ch...
Hynek Cihlar
04:16 AM Bug #10915: ugly dialogs
Thus 10915a passed ctrl_c regression tests and main regression tests with 3 failed. For the trunk I got the same resu... Sergey Ivanovskiy
09:05 PM Bug #10915: ugly dialogs
Sergey Ivanovskiy wrote:
> The first round of the main regression tests completed with 3 failed tests #7143-1937.
T...
Sergey Ivanovskiy
06:30 AM Bug #10938 (Review): Date FILL-IN: Incorrect SCREEN-VALUE after widget enablement
Hynek Cihlar wrote:
> *Code review 10938a revisions 16514..16518*
>
> Javadoc for @FillIn.shouldDisplayBlanks@ me...
Razvan-Nicolae Chichirau
04:33 AM Bug #11170 (Review): The caret position is initially wrong for DECIMAL/INTEGER FILL-IN widgets
Please check rev. 16565. Razvan-Nicolae Chichirau

05/26/2026

03:25 PM Bug #11170 (WIP): The caret position is initially wrong for DECIMAL/INTEGER FILL-IN widgets
*Code review 11170a revisions 16561..16564*
* *[MINOR]* _style_ @NumberBufGui@.@deleteRegion@: Javadoc @@param@ tags...
Hynek Cihlar
03:09 PM Bug #10915: ugly dialogs
The first round of the main regression tests completed with 3 failed tests #7143-1937. Sergey Ivanovskiy
07:54 AM Bug #10915: ugly dialogs
Stefanel, thank you for the review. Sergey Ivanovskiy
07:51 AM Bug #10915: ugly dialogs
I tested the changes related to @p2j.sso_reauth.js@, and they look good and work well for me.
Stefanel Pezamosca
06:19 AM Bug #10915: ugly dialogs
Sergey Ivanovskiy wrote:
> Thank you. Are there any simulations for Oidc provider for testing?
I use this: docker...
Stefanel Pezamosca
06:16 AM Bug #10915: ugly dialogs
Thank you. Are there any simulations for Oidc provider for testing? Sergey Ivanovskiy
06:13 AM Bug #10915: ugly dialogs
Sergey Ivanovskiy wrote:
> Stefanel, could you give me instructions to test Hotel Gui and @p2j_sso_reauth.js@ change...
Stefanel Pezamosca
06:02 AM Bug #10915: ugly dialogs
I finished manual GUI testing of rev 16644 (10915a). The rest tasks are CHUI regression testing and review/testing @p... Sergey Ivanovskiy
11:37 AM Bug #10938 (WIP): Date FILL-IN: Incorrect SCREEN-VALUE after widget enablement
*Code review 10938a revisions 16514..16518*
Javadoc for @FillIn.shouldDisplayBlanks@ mentions the method is only int...
Hynek Cihlar

05/25/2026

03:00 PM Bug #10915: ugly dialogs
OK. The current code @p2j.ModalDialog@ is over complicated. I was confused by AI review at some moment. Please review... Sergey Ivanovskiy
02:15 PM Bug #10915: ugly dialogs
Sergey Ivanovskiy wrote:
> It seems that 10915a doesn't have CHUI changes. Should I run CHUI regression tests?
Th...
Hynek Cihlar
12:23 PM Bug #10915: ugly dialogs
It seems that 10915a doesn't have CHUI changes. Should I run CHUI regression tests? Sergey Ivanovskiy
11:51 AM Bug #10915: ugly dialogs
Hynek, I found several regressions in the code. Please review the committed revision 16639 (10915a).
Stefanel, p...
Sergey Ivanovskiy
10:16 AM Bug #11495: FRAME/BROWSE is moving down
Testcase:
{{Collapse(browse_helper.p)...
Teodor Gorghe
09:04 AM Bug #11495 (New): FRAME/BROWSE is moving down
Teodor Gorghe
04:23 AM Bug #11211 (Review): Improve source detection when dispatching mouse wheel events
Please check 11211a/rev. 16518. Razvan-Nicolae Chichirau
03:38 AM Bug #11191 (Review): ChUI: COMBO-BOX raises error 4058 on valid SCREEN-VALUE assignment
Hynek Cihlar wrote:
> *Code review 11191a revisions 16548..16549*
>
> * *[CRITICAL]* _style_ @RadioSetWidget@: Co...
Razvan-Nicolae Chichirau

05/23/2026

02:58 PM Bug #11191 (WIP): ChUI: COMBO-BOX raises error 4058 on valid SCREEN-VALUE assignment
*Code review 11191a revisions 16548..16549*
* *[CRITICAL]* _style_ @RadioSetWidget@: Copyright year in the file head...
Hynek Cihlar
02:27 PM Bug #11211 (WIP): Improve source detection when dispatching mouse wheel events
*Code review 11211a revisions 16514..16517*
Two minor points, otherwise the changes look good. The functional point ...
Hynek Cihlar
02:35 AM Bug #10915 (Internal Test): ugly dialogs
*Code review 10915a revisions 16573..16629*
The changes look good. Please go ahead with regression testing, ideally ...
Hynek Cihlar

05/22/2026

05:31 PM Bug #10915 (Review): ugly dialogs
... Sergey Ivanovskiy
04:40 PM Bug #10915: ugly dialogs
OK. Committed revision 16629 (10915a) has opened major issues that can be fixed later in the different tasks.
Runnin...
Sergey Ivanovskiy
04:35 PM Bug #10915: ugly dialogs
Sergey Ivanovskiy wrote:
> This issue can be discussed. It relates to dialog messages used as translation keys and r...
Hynek Cihlar
04:23 PM Bug #10915: ugly dialogs
This issue can be discussed. It relates to dialog messages used as translation keys and read from the directory. I po... Sergey Ivanovskiy
01:38 PM Bug #10915: ugly dialogs
Committed rev 16628 got this result... Sergey Ivanovskiy
11:05 AM Bug #10915: ugly dialogs
Sergey Ivanovskiy wrote:
> > If it is not related to your changes and also present in trunk, please create new Redmi...
Hynek Cihlar
11:00 AM Bug #10915: ugly dialogs
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > OK. Please look at this issue that is not related to my diff.
>...
Sergey Ivanovskiy
10:35 AM Bug #10915: ugly dialogs
Sergey Ivanovskiy wrote:
> OK. Please look at this issue that is not related to my diff.
If it is not related to ...
Hynek Cihlar
08:15 AM Bug #10915: ugly dialogs
Also I tested these changes with testcases. Sergey Ivanovskiy
08:12 AM Bug #10915: ugly dialogs
Committed revision 16626 (10915a) is a good candidate for the review. Applied almost patches and running the review now. Sergey Ivanovskiy
07:43 AM Bug #10915: ugly dialogs
This issue can be discussed. Hynek, please look at this change. I would apply it too. Sergey Ivanovskiy
06:30 AM Bug #10915: ugly dialogs
I like this proposal. Sergey Ivanovskiy
06:26 AM Bug #10915: ugly dialogs
OK. Please look at this issue that is not related to my diff. Sergey Ivanovskiy
06:24 AM Bug #10915: ugly dialogs
Sergey Ivanovskiy wrote:
> Frankly, this process became exhausting due to the immense cognitive load required to tra...
Hynek Cihlar
05:28 AM Bug #10915: ugly dialogs
The results look interesting. Can they be posted? I would apply some of them because their looks are reasonable. Sergey Ivanovskiy
05:22 AM Bug #10915: ugly dialogs
I asked to prepare proposed solutions to each of the reported issues in the separated file corresponding each major i... Sergey Ivanovskiy
05:19 AM Bug #10915: ugly dialogs
OK. I am trying to pass this review as soon as possible due to incoming bugs #11412 and #11485 that were fixed in 109... Sergey Ivanovskiy
05:18 AM Bug #10915: ugly dialogs
Sergey Ivanovskiy wrote:
> I have these critical issues rooted in the legacy code. Could those be fixed in new optim...
Teodor Gorghe
04:03 AM Bug #10915: ugly dialogs
Committed rev 16625. There are edge cases that still not fixed. Sergey Ivanovskiy
04:02 AM Bug #10915: ugly dialogs
I ran several rounds of the review. The process yielded highly useful insights because the codebase is both asynchron... Sergey Ivanovskiy
01:45 AM Bug #10915: ugly dialogs
I have these critical issues rooted in the legacy code. Could those be fixed in new optimization task?
* *[CRITICA...
Sergey Ivanovskiy

05/21/2026

01:44 PM Bug #10915: ugly dialogs
Sergey Ivanovskiy wrote:
> Sergey Ivanovskiy wrote:
> > The second issue is really came from my changes in which I ...
Hynek Cihlar
01:43 PM Bug #10915: ugly dialogs
Sergey Ivanovskiy wrote:
> >I do not know how to do it because the cursor must be controlled by the business logic. ...
Hynek Cihlar
12:13 PM Bug #10915: ugly dialogs
I committed rev 16661 (10915a) and started code review. I did not do anything with these issues: issue 6, 8, 9.
Sergey Ivanovskiy
11:54 AM Bug #10915: ugly dialogs
>I do not know how to do it because the cursor must be controlled by the business logic. This part is not elaborated.... Sergey Ivanovskiy
11:40 AM Bug #10915: ugly dialogs
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Th 8-th issue should be discussed because we should not need to ...
Sergey Ivanovskiy
11:33 AM Bug #10915: ugly dialogs
Sergey Ivanovskiy wrote:
> The second issue is really came from my changes in which I did the dialog without closed ...
Sergey Ivanovskiy
10:57 AM Bug #10915: ugly dialogs
Sergey Ivanovskiy wrote:
> Th 8-th issue should be discussed because we should not need to send mouse and key events...
Hynek Cihlar
10:56 AM Bug #10915: ugly dialogs
OK. I will leave this and remove p2j.lyra guard. Sergey Ivanovskiy
10:54 AM Bug #10915: ugly dialogs
Sergey Ivanovskiy wrote:
> At least we need to add comments before @evt.key = undefined || evt.key "Unidentified" ||...
Hynek Cihlar
10:45 AM Bug #10915: ugly dialogs
The 9-th issue is quite clear.
>[MAJOR] functional EmbeddedWebHandler.<init>: Still constructs new DojoToolkitHandle...
Sergey Ivanovskiy
10:43 AM Bug #10915: ugly dialogs
Th 8-th issue should be discussed because we should not need to send mouse and key events to the business layer. It i... Sergey Ivanovskiy
10:28 AM Bug #10915: ugly dialogs
At least we need to add comments before @evt.key = undefined || evt.key "Unidentified" || evt.key ""@ Sergey Ivanovskiy
10:25 AM Bug #10915: ugly dialogs
The 7th issue is due to unclear code that was from Playwright and Lyra. I proposed to add the guard here. If this one... Sergey Ivanovskiy
10:24 AM Bug #10915: ugly dialogs
Sergey Ivanovskiy wrote:
> The 6th issue must be discussed because I do not know why it should be consumed.
This ...
Hynek Cihlar
10:23 AM Bug #10915: ugly dialogs
Sergey Ivanovskiy wrote:
> This one is simple but should be discussed, The proposed solution is to remove title.
...
Hynek Cihlar
10:22 AM Bug #10915: ugly dialogs
The 6th issue must be discussed because I do not know why it should be consumed.
>[MAJOR] functional CHUIKeyboardRea...
Sergey Ivanovskiy
10:14 AM Bug #10915: ugly dialogs
This one is simple but should be discussed, The proposed solution is to remove title.
>[MAJOR] functional ssoReauth....
Sergey Ivanovskiy
10:13 AM Bug #10915: ugly dialogs
The 4th issue is similar to 3d.
>[MAJOR] functional ssoReauth.handleSsoReauth: reauthDialog.show() is asynchronous (...
Sergey Ivanovskiy
10:11 AM Bug #10915: ugly dialogs
The third issue looks bad because adding @await@ requires to add @async@ marker the hosted function.
>[MAJOR] funct...
Sergey Ivanovskiy
10:03 AM Bug #10915: ugly dialogs
The second issue is really came from my changes in which I did the dialog without closed button x but forgot to remov... Sergey Ivanovskiy
10:00 AM Bug #10915: ugly dialogs
The first issue I should discuss here... Sergey Ivanovskiy
09:58 AM Bug #10915: ugly dialogs
OK. Thank you. I see. Sergey Ivanovskiy
09:53 AM Bug #10915: ugly dialogs
Sergey Ivanovskiy wrote:
> May be you are correct. Those seem to me like shuffled old issues because of asynchronous...
Hynek Cihlar
09:49 AM Bug #10915 (WIP): ugly dialogs
Sergey Ivanovskiy
09:49 AM Bug #10915: ugly dialogs
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > These issues are shuffled from AI review to another one. Could y...
Sergey Ivanovskiy
09:35 AM Bug #10915: ugly dialogs
Sergey Ivanovskiy wrote:
> These issues are shuffled from AI review to another one. Could you select the ones that c...
Hynek Cihlar
09:31 AM Bug #10915 (Review): ugly dialogs
Sergey Ivanovskiy
09:20 AM Bug #10915: ugly dialogs
I would reject them all. Sergey Ivanovskiy
09:19 AM Bug #10915: ugly dialogs
These issues are shuffled from AI review to another one. Could you select the ones that can be fixed? Sergey Ivanovskiy
09:17 AM Bug #10915 (WIP): ugly dialogs
*Code review 10915a revisions 16573..16620*
* *[CRITICAL]* _functional_ @ModalDialog@.@show@: @dialogs.add(that.id)@...
Hynek Cihlar
08:21 AM Bug #10915: ugly dialogs
OK. I added the guide for this code. Could you review the last code rev 16620. I tried to fix the most issues. Sergey Ivanovskiy
08:13 AM Bug #10915: ugly dialogs
Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > Hynek, what was the reason that ...
Hynek Cihlar
09:26 AM Bug #11326: Reduce memory consumption of FWD clients
Ok, thanks for letting me know! Teodor Gorghe
09:24 AM Bug #11326: Reduce memory consumption of FWD clients
Teodor Gorghe wrote:
> Committed the changes into *hotel_gui* revision *454*.
If you want the base 24.04 Docker i...
Roger Borrello
08:22 AM Bug #11326 (Test): Reduce memory consumption of FWD clients
Teodor Gorghe
08:20 AM Bug #11326: Reduce memory consumption of FWD clients
Committed the changes into *hotel_gui* revision *454*. Teodor Gorghe
04:42 AM Bug #11326: Reduce memory consumption of FWD clients
Branch 11326c was merged into trunk as rev. 16575 and archived. Teodor Gorghe
04:34 AM Bug #11326: Reduce memory consumption of FWD clients
Testing was done on 4 projects, without any issue.
I am merging this now.
Teodor Gorghe
04:33 AM Bug #11326 (Merge Pending): Reduce memory consumption of FWD clients
Teodor, please merge 11326c now if you are satisfied with the changes. Also commit the docker-related changes to Hot... Constantin Asofiei
01:29 AM Bug #11326: Reduce memory consumption of FWD clients
@docker/docker-compose_create_pg_cluster.yml@ changes should be reverted. This was an attempt to create a pg cluster,... Teodor Gorghe
03:23 AM Bug #11343: Alert-box suddenly disppears when a specific item is selected from a drop-down list u...
Replicating the mouse-click behavior for the keyboard selection case *is not possible*.
On mouse-click:
* It is g...
Razvan-Nicolae Chichirau

05/20/2026

12:48 PM Bug #11326: Reduce memory consumption of FWD clients
Teodor, very good and complete. There is only this I have a problem with:... Roger Borrello
07:12 AM Bug #11326 (Internal Test): Reduce memory consumption of FWD clients
Teodor, the changes look good. Please do some small testing just to double-check normal setup works without appcds e... Constantin Asofiei
01:54 AM Bug #11326: Reduce memory consumption of FWD clients
Committed revision *16566* on task branch *11326c*:
* Improved implementation for support of client types.
Teodor Gorghe

05/19/2026

06:15 AM Bug #10915 (Review): ugly dialogs
Please review the last fixes rev. 16605 (10915a). Sergey Ivanovskiy
06:14 AM Bug #10915 (WIP): ugly dialogs
Sergey Ivanovskiy
01:41 AM Bug #11170 (Review): The caret position is initially wrong for DECIMAL/INTEGER FILL-IN widgets
*Hynek*: Please review 11170a/rev. 16564. Razvan-Nicolae Chichirau

05/18/2026

08:16 AM Bug #11170: The caret position is initially wrong for DECIMAL/INTEGER FILL-IN widgets
Some updates:
* Successfully implemented the first idea from #11170-10. The second one was bringing too much overhea...
Razvan-Nicolae Chichirau
06:56 AM Bug #11326: Reduce memory consumption of FWD clients
Roger, I have forgot to include the @docker/repo/entrypoint/docker-entrypoint_prepare.sh@.
These changes were includ...
Teodor Gorghe
03:48 AM Bug #11326: Reduce memory consumption of FWD clients
Teodor Gorghe wrote:
> I was thinking to replace the current approach with one which uses the already existing code ...
Constantin Asofiei
03:43 AM Bug #11326: Reduce memory consumption of FWD clients
Thanks.
I have found some issues while parsing @directory.xml@ from #11472, and I would need to rethink everything a...
Teodor Gorghe
03:32 AM Bug #11326: Reduce memory consumption of FWD clients
Teodor, 11326c looks OK.
Constantin Asofiei

05/15/2026

07:39 AM Bug #10915: ugly dialogs
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Hynek, what was the reason that this code was placed at the top ...
Sergey Ivanovskiy
07:36 AM Bug #10915: ugly dialogs
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Hynek, what was the reason that this code was placed at the top ...
Sergey Ivanovskiy
07:17 AM Bug #10915: ugly dialogs
Sergey Ivanovskiy wrote:
> Hynek, what was the reason that this code was placed at the top before logKeyEvent(evt, "...
Hynek Cihlar
04:22 AM Bug #10915 (Feedback): ugly dialogs
Hynek, we need to discuss #10915-178 before I finalized the code for the review. Sergey Ivanovskiy
07:28 AM Bug #11326 (Review): Reduce memory consumption of FWD clients
These are the latest changes to integrate AppCDS.
Also committed revision *16565* to branch *11326c*, which adds *...
Teodor Gorghe
05:15 AM Bug #11326: Reduce memory consumption of FWD clients
*Constantin*, I have done the *lib.client* change in *deploy.prepare* task for *hotel_gui* (which takes from *p2j/dis... Teodor Gorghe
03:46 AM Bug #11326: Reduce memory consumption of FWD clients
In the last couple of days, I have worked on integrating client AppCDS building process into @hotel_gui@ project:
* ...
Teodor Gorghe
03:45 AM Bug #11170: The caret position is initially wrong for DECIMAL/INTEGER FILL-IN widgets
Suppose a numeric-based fill-in (int, int64 or decimal). In 4GL, if the widget is cleared, either by realizing it (wi... Razvan-Nicolae Chichirau

05/14/2026

03:57 PM Bug #10915: ugly dialogs
Committed rev 16603(10915a) should fix most found issues (those that can be fixed) except
* *[MAJOR]* _functional...
Sergey Ivanovskiy
12:03 PM Bug #10915: ugly dialogs
Hynek, what was the reason that this code was placed at the top before logKeyEvent(evt, "keypress"); and guards?
<pr...
Sergey Ivanovskiy
07:41 AM Bug #10915: ugly dialogs
Committed revision 16600 (10915a) fixed
*[MAJOR]* functional startupServer (EmbeddedWebServerImpl): When DOJO...
Sergey Ivanovskiy

05/13/2026

07:05 AM Bug #10915: ugly dialogs
I think that false options can be omitted so... Sergey Ivanovskiy
07:02 AM Bug #10915: ugly dialogs
To remove the dialog title bar we need to set this option value @noTitle : true@... Sergey Ivanovskiy
06:54 AM Bug #10915: ugly dialogs
Stefanel, thank you for help with this dialog checking! If we require Close dialog button (X) and the title, then
<...
Sergey Ivanovskiy
04:51 AM Bug #10915: ugly dialogs
Sergey Ivanovskiy wrote:
> Stefanel, could you help with the test case to check the reauth dialog style from @p2j.ss...
Stefanel Pezamosca
04:47 AM Bug #10915: ugly dialogs
If it is important for the caller of @ModalDialog@ to wait until its method is completed, then @await@ construction s... Sergey Ivanovskiy
04:43 AM Bug #10915: ugly dialogs
This one
*[MAJOR]* functional doRedirectToLogoutPage: In the window.fetch(logoutPage).catch(...) branch the new co...
Sergey Ivanovskiy
04:01 AM Bug #10915: ugly dialogs
Yes, the current code looks suitable but there can be issues with ModalDialog usages that needs to be checked. Actual... Sergey Ivanovskiy
03:48 AM Bug #10915: ugly dialogs
Sergey Ivanovskiy wrote:
> Stefanel, could you help with the test case to check the reauth dialog style from @p2j.ss...
Stefanel Pezamosca

05/12/2026

02:01 PM Bug #10915: ugly dialogs
This one
* *[MAJOR]* _functional_ @p2j.mouse.js@.@processMouseMove@: @isDialogDisplayed()@ guard at line 362 fire...
Sergey Ivanovskiy
01:40 PM Bug #10915: ugly dialogs
Yes, this one @restoreConnectionDialog.setTitle(p2j.i18n.gettext("Server Unavailable"));@ can be removed because the ... Sergey Ivanovskiy
01:08 PM Bug #10915: ugly dialogs
*Code review 10915a revisions 16559..16591*
* *[MAJOR]* _functional_ @chooseFiles@: @onError@ reads @actionResultsDi...
Hynek Cihlar
12:37 PM Bug #10915: ugly dialogs
At the moment of writing the code this part was intentional:
*[MAJOR]* functional ModalDialog.close: Bypasses hide...
Sergey Ivanovskiy
12:35 PM Bug #10915: ugly dialogs
h1. FWD Code Review — Curated Findings
h2. Summary
20 files modified (2957 line diff). The prior CRITICAL findi...
Sergey Ivanovskiy
11:36 AM Bug #10915: ugly dialogs
Finally I realized that @onHide@ and @onClose@ listeners should be protected and do not send any key and mouse events... Sergey Ivanovskiy
11:19 AM Bug #10915: ugly dialogs
The current rev 16593 has this report
h1. FWD Code Review — Curated Findings
h2. Summary
This diff spans 20 ...
Sergey Ivanovskiy
10:47 AM Bug #10915: ugly dialogs
Stefanel, could you help with the test case to check the reauth dialog style from @p2j.sso_reauth.js@? Sergey Ivanovskiy
09:58 AM Bug #10915: ugly dialogs
Committed revision 16592 (10915a) fixed most of minor issues and I run new code review to collect what was left or ig... Sergey Ivanovskiy
05:38 AM Bug #10915: ugly dialogs
Committed revision 16591.(10915a). Fixed critical and major issues found in the AI review (#10915a-155). Sergey Ivanovskiy
04:38 AM Bug #10915: ugly dialogs
No, this is related to the dojo code. ... Sergey Ivanovskiy
04:28 AM Bug #10915: ugly dialogs
I tested repeatedly the direct upload web functionality and found that buttons do not trigger actions if Enter was pr... Sergey Ivanovskiy
08:46 AM Bug #11326: Reduce memory consumption of FWD clients
-deleted- Alexandru Lungu

05/11/2026

11:32 AM Bug #10915 (WIP): ugly dialogs
Some of those issues can be fixed. So I will change to WIP. Sergey Ivanovskiy
11:20 AM Bug #10915: ugly dialogs
Running fwd-code-review reported these issues:
h1. FWD Code Review — Curated Findings
h2. Summary
The diff m...
Sergey Ivanovskiy
09:47 AM Bug #10915: ugly dialogs
Committed revision 16588 (10915a) minor changes found by the gcd-code-style review. Sergey Ivanovskiy
07:53 AM Bug #10915: ugly dialogs
Each time AI assistant based on Claude Code finds new issues. I rebased this branch 10915a up to rev 16587. Sergey Ivanovskiy
08:06 AM Bug #11326: Reduce memory consumption of FWD clients
Constantin Asofiei wrote:
> Teodor Gorghe wrote:
> > One idea which I have is getting this information from @direct...
Teodor Gorghe
08:00 AM Bug #11326: Reduce memory consumption of FWD clients
Teodor Gorghe wrote:
> One idea which I have is getting this information from @directory.xml@.
Yes, we need this. ...
Constantin Asofiei
07:25 AM Bug #11326: Reduce memory consumption of FWD clients
I have managed to get @hotel_gui@ project up and running from a docker container and I have made some initial changes... Teodor Gorghe
03:57 AM Bug #11459: Hotel GUI Spreadsheet does not open
@Hotel_GUI@ *Spreadsheet* does open on local setup without any issue.
When using a setup which uses docker contain...
Teodor Gorghe
03:51 AM Bug #11459 (New): Hotel GUI Spreadsheet does not open
Teodor Gorghe

05/07/2026

02:12 PM Bug #11326: Reduce memory consumption of FWD clients
Branch 11326b was merged to trunk rev 16559 and archived. Constantin Asofiei
02:08 PM Bug #11326: Reduce memory consumption of FWD clients
Constantin Asofiei wrote:
> The patch is in note #11326-122 that's the only change separator instead of pathSeparato...
Eugenie Lyzenko
01:49 PM Bug #11326: Reduce memory consumption of FWD clients
The patch is in note #11326-122 that's the only change separator instead of pathSeparator Constantin Asofiei
01:47 PM Bug #11326: Reduce memory consumption of FWD clients
Constantin Asofiei wrote:
> Eugenie, please do some smoke-tests with 11326b rev 16559 (has the fix from #11326-123),...
Eugenie Lyzenko
01:41 PM Bug #11326: Reduce memory consumption of FWD clients
Eugenie, please do some smoke-tests with 11326b rev 16559 (has the fix from #11326-123), if is OK I'll merge it ASAP. Constantin Asofiei
01:31 PM Bug #11326: Reduce memory consumption of FWD clients
Teodor Gorghe wrote:
> Moved this task to *WIP* because we need to migrate customer application setup to use @lib.cl...
Constantin Asofiei
01:30 PM Bug #11326: Reduce memory consumption of FWD clients
Teodor, Eugenie is right; there was a 'typo':... Constantin Asofiei
01:00 PM Bug #11326: Reduce memory consumption of FWD clients
Teodor Gorghe wrote:
> Branch 11326a was merged into trunk as rev. 16557 and archived.
>
> Moved this task to *WI...
Eugenie Lyzenko
11:38 AM Bug #11326 (WIP): Reduce memory consumption of FWD clients
Branch 11326a was merged into trunk as rev. 16557 and archived.
Moved this task to *WIP* because we need to migrat...
Teodor Gorghe
11:32 AM Bug #11326 (Merge Pending): Reduce memory consumption of FWD clients
Please merge 11326a now. Constantin Asofiei
11:31 AM Bug #11326: Reduce memory consumption of FWD clients
I don't think (I have also tested with the @lib.client@). Teodor Gorghe
11:29 AM Bug #11326: Reduce memory consumption of FWD clients
Teodor Gorghe wrote:
> I have added the comment.
Thank you. Any other testing required?
Constantin Asofiei
11:28 AM Bug #11326: Reduce memory consumption of FWD clients
I have added the comment. Teodor Gorghe
11:20 AM Bug #11326: Reduce memory consumption of FWD clients
Teodor Gorghe wrote:
> The problem came from *spawn* JVM, which tried to load @EventDefinition@ (throws @ClassNotFou...
Constantin Asofiei
11:18 AM Bug #11326: Reduce memory consumption of FWD clients
The problem came from *spawn* JVM, which tried to load @EventDefinition@ (throws @ClassNotFoundException@)
@EventDef...
Teodor Gorghe
11:08 AM Bug #11326: Reduce memory consumption of FWD clients
Teodor Gorghe wrote:
> There was just one regression related with @PayloadSerializer@, which was fixed in +11326a/16...
Constantin Asofiei
10:19 AM Bug #11326: Reduce memory consumption of FWD clients
Regression testing has passed (ETF and two other customer applications).
There was just one regression related wit...
Teodor Gorghe

05/06/2026

06:30 AM Bug #11326: Reduce memory consumption of FWD clients
ChUI regression testing has passed.
I will continue testing ETF and the remaining customer apps.
Teodor Gorghe
06:29 AM Bug #11326: Reduce memory consumption of FWD clients
Smoke-testing a customer app with 11326a passed. Razvan-Nicolae Chichirau

05/05/2026

04:54 AM Bug #11191 (Review): ChUI: COMBO-BOX raises error 4058 on valid SCREEN-VALUE assignment
*Hynek*: Please review 11191a/rev. 16549. Razvan-Nicolae Chichirau
01:40 AM Bug #10938 (Review): Date FILL-IN: Incorrect SCREEN-VALUE after widget enablement
Commited the fix to 10938a/rev. 16518. Your testcase and the customer app regressions are now solved.
Speaking of ...
Razvan-Nicolae Chichirau

05/04/2026

03:24 AM Bug #11326: Reduce memory consumption of FWD clients
Thanks.
I have committed the changes into +11326a/r16534+.
Teodor Gorghe
03:19 AM Bug #11326: Reduce memory consumption of FWD clients
Teodor, for @LstExporter@:
* please fix the 'module' header (now has @com.goldencode.bytecode.LstExporter.java@)
* ...
Constantin Asofiei
 

Also available in: Atom