Golden Code Redmine

03/27/2025

04:44 PM Database Bug #9763 (Internal Test): xml-node-name buffer option

Eduard Soltan wrote:
> Committed on 9763a, rev. 15796.
A couple of minor observations:
* Please revert @RecordBuff... Ovidiu Maxiniuc

12:08 PM Database Bug #9763: xml-node-name buffer option

Eduard, for some reasons I missed some files in #9763-47 (I think I pressed Ctrl+C in wrong console):
* @JsonExpo... Ovidiu Maxiniuc

07:41 AM Database Bug #9763: xml-node-name buffer option

+Review of 9763b/15792+
This is pretty good, but there are several things which must be addressed:
* @AbstractTem... Ovidiu Maxiniuc

03/26/2025

07:37 PM Runtime Infrastructure Feature #7080 (Internal Test): expose all admin APIs via REST

The branch 8976a was updated and rebased to latest trunk. Current revision is 15830. Ovidiu Maxiniuc

08:00 PM Database Feature #9093 (Review): add protection for multi-tenant imports to optionally only import tables ...

I created the new tenant import mode. It is called @strict@ and also added an alias @strict-default@. In this case th... Ovidiu Maxiniuc

03/25/2025

02:25 PM Runtime Infrastructure Feature #7080: expose all admin APIs via REST

Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> You have @src/com/goldencode/p2j/security/WebServiceResource.j... Ovidiu Maxiniuc

01:52 PM Runtime Infrastructure Feature #7080: expose all admin APIs via REST

Constantin Asofiei wrote:
> Review of 8976a rev 15810:
> * please run javadoc with Java 8 and fix any issues in you... Ovidiu Maxiniuc

03/21/2025

05:57 PM Runtime Infrastructure Feature #7080 (Review): expose all admin APIs via REST

The changes in 8976a / 15810:
* created @BaseAdminRestHandler@ as base @abstract@ class for all REST handlers:
** w... Ovidiu Maxiniuc

05:22 PM Runtime Infrastructure Feature #7080 (WIP): expose all admin APIs via REST

I committed the changes to 8976a / 15810. Ovidiu Maxiniuc

03/20/2025

10:57 AM Database Feature #7020: always use "expanded" extent fields

Stefanel Pezamosca wrote:
> Now that I think about the potential issues, I believe this plan will be safer. So, I’m ... Ovidiu Maxiniuc

03/19/2025

04:23 PM Runtime Infrastructure Feature #7080: expose all admin APIs via REST

Constantin Asofiei wrote:
> The point is: I see real usage in getting the full details 'up front', and not having to... Ovidiu Maxiniuc

01:59 PM Runtime Infrastructure Feature #7080: expose all admin APIs via REST

Constantin and I have a discussion on meet and we reach the following conclusions (summarised):
# instead a having... Ovidiu Maxiniuc

02:09 PM Database Feature #9093: add protection for multi-tenant imports to optionally only import tables that are ...

I am preparing a new @tenantMode@, which will restrict the import to @Default@ physical database only to tables not m... Ovidiu Maxiniuc

03/18/2025

12:58 PM Database Feature #7020: always use "expanded" extent fields

Review of 7020c / 15792.
I see that you did what I was afraid to do: completely drop the support for custom extent... Ovidiu Maxiniuc

03/13/2025

06:51 PM Database Bug #9756 (Internal Test): Performance improvements for CONTAINS udf related methods.

O am OK with the changes in r15769. Ovidiu Maxiniuc

03:44 PM Database Bug #9763: xml-node-name buffer option

Constantin Asofiei wrote:
> Ovidiu, you are right. Eduard: for now, please rename @setLabel@ and @getLabel@ to @lab... Ovidiu Maxiniuc

02:09 PM Database Bug #9763: xml-node-name buffer option

I looked at 9763a.
* @buffer_definitions.rules@:
** contains some hard tabs (@#09@, @\t@)
** rules should use t... Ovidiu Maxiniuc

01:54 PM Database Bug #9763: xml-node-name buffer option

Constantin Asofiei wrote:
> I assume you mean 9763b.
Yes, you are right. Sorry, I did not realise that there are 2 ... Ovidiu Maxiniuc

01:51 PM Database Bug #9763: xml-node-name buffer option

I looked at 9763a and I do NOT agree with the implementation.
IMHO, the values of these new attributes should be s... Ovidiu Maxiniuc

01:11 PM TRPL Feature #9770: Change annotation key type from plain string to Enum

Radu,
I had peeked at the list you compiled. I am puzzled by something: why are there customer-specific values saved... Ovidiu Maxiniuc

12:10 PM Database Feature #9543: implement missing BUFFER attributes

There is another conversion issue. Instead of... Ovidiu Maxiniuc

10:56 AM Database Feature #9543: implement missing BUFFER attributes

I do not think you need to add a new method.
The _missing_ method is most likely @CommonHandle.readOnlyError(String ... Ovidiu Maxiniuc

03/12/2025

06:34 PM Database Feature #7020: always use "expanded" extent fields

I have started reviewing the branch, but it will not be ready until tomorrow due to its size. Ovidiu Maxiniuc

06:42 AM Database Bug #9756: Performance improvements for CONTAINS udf related methods.

Cool. I have looked at the code. The changes are minimal. They are OK in my opinion. However, we can assume the first... Ovidiu Maxiniuc

03/11/2025

02:16 PM Database Bug #9763: xml-node-name buffer option

Constantin Asofiei wrote:
> > 9763a/15767 only adds conversion support for buffer's @xml-node-name@ attribute. But t... Ovidiu Maxiniuc

11:24 AM Database Bug #9763: xml-node-name buffer option

Constantin Asofiei wrote:
> Ovidiu: please review 9763a
9763a/15767 only adds conversion support for buffer's @xm... Ovidiu Maxiniuc

11:08 AM Database Bug #9756: Performance improvements for CONTAINS udf related methods.

Stefanel Pezamosca wrote:
> The cache I made only saves the ast given by FQLParser, and has only the String fql as a... Ovidiu Maxiniuc

10:28 AM Database Bug #9756: Performance improvements for CONTAINS udf related methods.

Review of 9756a/15766.
I agree that these are two directions we can improve performance. The ideas are good. But I... Ovidiu Maxiniuc

03/10/2025

02:33 PM Database Feature #9093: add protection for multi-tenant imports to optionally only import tables that are ...

I downloaded the files from your link. Thank you.
As you said, there are 2 directories:
* the @emptydbwithschema@... Ovidiu Maxiniuc

03/07/2025

04:18 PM Database Bug #9633: bulk delete for permanent tables

Review of 9656a/15759.
* @Persistence.java@
** I think the new methods are very useful additions;
** line 1370: ... Ovidiu Maxiniuc

03/05/2025

08:09 AM Database Feature #9093: add protection for multi-tenant imports to optionally only import tables that are ...

Eric Faulhaber wrote:
> Can you proceed with testing the simple MT setup you were using before the customer's test c... Ovidiu Maxiniuc

03/03/2025

04:30 PM Database Feature #6720: lazy hydration

Greg Shah wrote:
> I understand. I presume it is scoped to the trigger. It is implicitly nested inside the convert... Ovidiu Maxiniuc

11:49 AM Database Feature #6720: lazy hydration

The 'old' buffer is not a normal buffer. The @snapshot@ of a record is created at the time it is changed (only if a t... Ovidiu Maxiniuc

11:48 AM Database Feature #9093: add protection for multi-tenant imports to optionally only import tables that are ...

The regression tests returned with success, as well as my targetted testcases used for development. But these no not ... Ovidiu Maxiniuc

02/27/2025

02:38 PM Runtime Infrastructure Feature #7080: expose all admin APIs via REST

The @domain@ table has references to @domain_type@ and @tenant_name@. Therefore a @domain@ cannot be defined without ... Ovidiu Maxiniuc

09:53 AM Database Bug #9701: RecordBuffer.updateCurrentChanged can be optimized to use a fast DMO equality check

I think that should suffice. The changes are right at the heart of the persistence and surely the affected code will ... Ovidiu Maxiniuc

09:32 AM Database Bug #9701 (Internal Test): RecordBuffer.updateCurrentChanged can be optimized to use a fast DMO e...

I have reviewed the changes in 9701a/r15735.
I agree with the new code (with the reservation of the problem related ... Ovidiu Maxiniuc

02/26/2025

05:06 PM Runtime Infrastructure Feature #7080: expose all admin APIs via REST

Greg Shah wrote:
> Ovidiu Maxiniuc wrote:
> > I was not, but @/admin/meta/<meta-tables>/@ and @MetaHandler@ will fi... Ovidiu Maxiniuc

02:57 PM Runtime Infrastructure Feature #7080: expose all admin APIs via REST

Constantin Asofiei wrote:
> You mean @/admin/meta/tenant/@? Then I'm OK to group these together, and use the @META:... Ovidiu Maxiniuc

12:43 PM Runtime Infrastructure Feature #7080: expose all admin APIs via REST

Constantin Asofiei wrote:
> *Ovidiu* - please document here all the REST paths added to @AdminHandler@ in 8976b, in ... Ovidiu Maxiniuc

12:55 PM Base Language Bug #4766: fix CHR and ASC

I was not aware of this attribute. Its mere existence means each compiled piece of code my have independent CPs decid... Ovidiu Maxiniuc