Golden Code Redmine

06/22/2024

08:11 PM Database Bug #7924: add support for creating an empty database

Review of 7924a, rev.15307-15311.
Good job!
The majority of the changes are required for carrying along the manda...

06/21/2024

04:57 AM Database Feature #8893: Make DDL code generated by FWD matching the SQL dump for respective dialect

Ovidiu Maxiniuc wrote:
> | @primary key (recid)@ | - | This puzzles me a bit. Does PSQL assume the first column (rec...

06/20/2024

04:46 PM Database Feature #8893: Make DDL code generated by FWD matching the SQL dump for respective dialect

The idea is to generate the code as much as possible identical with the DDLs generated by the RDBMSs. The main reason...

03:48 PM Database Feature #8893 (New): Make DDL code generated by FWD matching the SQL dump for respective dialect

06/18/2024

07:21 AM Database Bug #8878: Jumble sort dictates a full preselect

Review of 8878a/15285.
The only modified file is @preselect_prep.rules@:
* lines 64-65: there are some hard-tabs ...

05/21/2024

04:52 PM Conversion Tools Feature #8786: incremental schema conversion and updates

I would like to add a few thoughts here. We need to analyse all kind of mutations which can happen during an upgrade ...

10:56 AM Database Bug #7473: rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuilder to...

Alexandru Lungu wrote:
> I think the changes are only for debugging purposes, right? Ovidiu, please correct me if I ...

05/20/2024

03:20 PM Database Bug #7473: rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuilder to...

Review of 7473a, r15210.
The majority of the issues from previous review were addressed, I have not seen any logic...

02:32 PM Database Bug #8593 (Internal Test): H2 performance improvement for table 'truncate by multiplex'

The changes seem logical. I think the code is OK.

05/14/2024

04:31 PM Database Bug #7473: rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuilder to...

I have just notice that a branch 7473a already exists. It was not mentioned in the task so I assumed the changes are ...