Constantin Asofiei's activity
From 04/28/2025 to 05/27/2025
05/27/2025
- 06:00 AM Database Bug #9763: xml-node-name buffer option
- Review for 9763b rev 15950:
* BufferImpl - missing history number
* RecordBuffer - no actual change, use 'bzr rever... - 05:54 AM Base Language Feature #6161 (Internal Test): add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-P...
- 05:54 AM Base Language Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...
- I'm OK with the changes in 6161a, and it passed conversion testing. Please run harness for some apps.
Also, 6161a... - 03:47 AM Base Language Bug #9996: Object references should be decremented at the nearest block instead of the top-level ...
- Danut, some notes:
* now we register ObjectOps as 'block-scopeable' instead of 'top-level scopeable'.
* this mean...
05/26/2025
- 02:22 PM Database Bug #10049: UDF configuration regression in Persistence.java
- I'm OK with the changes.
- 04:43 AM Database Feature #9543 (Merge Pending): implement missing BUFFER attributes
- Please merge 9543b after 10027a
- 04:40 AM Base Language Bug #10027 (Merge Pending): Incorrect handling of an unused shared variable in the conversion pro...
- Please merge 10027a after 9583b.
05/23/2025
- 09:51 AM Base Language Bug #10027: Incorrect handling of an unused shared variable in the conversion process.
- Paula Păstrăguș wrote:
> Committed to 10027a/15933.
>
> Constantin, please double-check the revision.
The branch... - 08:41 AM Base Language Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...
- Constantin Asofiei wrote:
> Sorry, I meant @extent(extVar)@ as argument, not property call.
And this is not a class... - 08:41 AM Base Language Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...
- Sorry, I meant @extent(extVar)@ as argument, not property call.
- 08:08 AM Base Language Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...
- Paul Bodale wrote:
> Constantin Asofiei wrote:
> > There is also an added @new integer@ wrapper for this case:
> >... - 07:10 AM Base Language Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...
- There is also an added @new integer@ wrapper for this case:...
- 06:44 AM Base Language Feature #9516: include pre-converted webspeed runtime code in FWD
- Radu Apetrii wrote:
> I assume I need to add those in the directory. Is there a suitable place (like for example und... - 06:41 AM Base Language Feature #9516: include pre-converted webspeed runtime code in FWD
- Radu Apetrii wrote:
> I have a pretty small testcase with this issue that fails with both 6506a and trunk, so let me... - 06:37 AM Base Language Feature #9516: include pre-converted webspeed runtime code in FWD
- Radu Apetrii wrote:
> Will we add nodes in the directory with these configurations?
They should map to directory se...
05/22/2025
- 10:35 AM Base Language Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...
- Paul Bodale wrote:
> Returns the error 16548 instead of 16581 like expected but I -will- _can_ fix this in the next ... - 10:34 AM Base Language Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...
- Please do some improvements here:...
- 10:23 AM Base Language Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...
- OK, I think I understand now. Thanks.
- 09:59 AM Base Language Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...
- Paul Bodale wrote:
> I tested this multiple times and the results show that the cast is only needed for function cal... - 05:44 AM Base Language Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...
- Review of 6161a rev 15944:
* add missing headers to files where is not set
* shouldn't this honor also direct metho... - 04:07 AM Base Language Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...
- Shouldn't @mtypes[i].isAssignableFrom(BaseDataType.class)@ be @BaseDataType.class.isAssignableFrom(...)@? The javado...
- 03:13 AM Base Language Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...
- The please improve that code; at the least, if @mtypes[i].isArray()@, the do not @// last resort - try to convert@
- 03:04 AM Base Language Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...
- Is this from this code?...
- 09:55 AM Runtime Infrastructure Bug #10041: Extend usages of TransactionManager.honorStopCondition to tight loops inside the run-...
- To reiterate something I mentioned during the standup today: in OE, when you kill the OS process for a frozen GUI cli...
- 08:21 AM Base Language Feature #9516: include pre-converted webspeed runtime code in FWD
- Get the line from @debug.p.cache@ and look into the @debug.p.pphints@ for the include file matching that line.
- 08:18 AM Base Language Feature #9516: include pre-converted webspeed runtime code in FWD
- What file is this? Is this after parse (the .cache) or before it?
Try commenting the offending @NO-ERROR.@ line. - 06:20 AM Base Language Feature #9447: XML support feature improvements and testing
- Run @./gradlew dependencies@ and look into the dependency tree. There is also #9687 where we are upgrading dependenc...
- 04:19 AM Base Language Feature #9437: enhancements for Progress.Lang.Class
- Eduard, please rebase.
- 03:26 AM Conversion Tools Bug #10028: FWD needs full support for unicode/octal escape sequences
- A thought about the case like @define variable ch as character initial "~000doesntmatter":U no-undo.@.
In FWD, the...
05/21/2025
- 11:53 AM Conversion Tools Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
- Roger Borrello wrote:
> Constantin Asofiei wrote:
> > Your case-sensitivity is wrong - use @F ./abl/test.p@. I don... - 11:28 AM Conversion Tools Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
- Your case-sensitivity is wrong - use @F ./abl/test.p@. I don't recall exactly, but I think it was discussed in anoth...
- 08:56 AM Base Language Bug #10027: Incorrect handling of an unused shared variable in the conversion process.
- Paula Păstrăguș wrote:
> However, until then, Constantin, does the fix meet your expectations?
Yes, thank you.
- 06:15 AM Base Language Bug #10027: Incorrect handling of an unused shared variable in the conversion process.
- Paula Păstrăguș wrote:
> So just to confirm, you're suggesting that the better solution would be to update @variable... - 06:08 AM Base Language Bug #10027: Incorrect handling of an unused shared variable in the conversion process.
- Paula Păstrăguș wrote:
> Regarding the rule I mentioned earlier, I would suggest adding a new condition like the fol... - 06:06 AM Base Language Bug #10027: Incorrect handling of an unused shared variable in the conversion process.
- We need to exclude the 'meta' usage when checking the 'refid' - so in @variable_definitions_unrefd.rules@, do not use...
- 07:15 AM Base Language Bug #9819: SESSION:FIRST-ASYNC-REQUEST and SESSION:LAST-ASYNC-REQUEST
- Eduard Soltan wrote:
> Do I have the change @message h:connect("-URL http://localhost:8810/apsv -sessionModel Sessio... - 05:40 AM Database Feature #9440: get-codepage() function should work with CLOB fields
- Teodor Gorghe wrote:
> When using @get-codepage(buffer ttTable::fInt)@, on OpenEdge, it does not throw any error. Th... - 03:25 AM Database Feature #9440: get-codepage() function should work with CLOB fields
- Please expand the test to also use @get-codepage(buffer ttTable::fClob)@ (i.e. the POLY case which should convert to ...
- 03:16 AM Database Feature #9440: get-codepage() function should work with CLOB fields
- I'm OK with the changes in rev 15912.
What standalone tests did you use for this? - 03:41 AM Base Language Feature #9447: XML support feature improvements and testing
- Is there a constant in JRE for @http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit@?
- 03:20 AM Base Language Feature #9447: XML support feature improvements and testing
- What about @SaxReaderImpl@?
- 02:42 AM Base Language Feature #6490 (Merge Pending): DYNAMIC-INVOKE which returns an extent
- Please merge to trunk now. I've ran conversion again and it was OK.
05/20/2025
- 10:29 AM Base Language Bug #10004: NativeInvoker fails if an argument is of type integerConstant
- review for 10004a rev 15918:
* @type.equals(BaseDataTypeConstant.class)@ needs to be @BaseDataTypeConstant.class.isA... - 07:45 AM Base Language Bug #10004: NativeInvoker fails if an argument is of type integerConstant
- Artur Școlnic wrote:
> You mean storing the super class for anonymous classes and constants in the signature?
> If ... - 08:53 AM Conversion Tools Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
- Dănuț Filimon wrote:
> The revision is *7180a/15937*. *Constantin*, can you take a look at the last revision and let...
05/19/2025
- 10:17 AM Base Language Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...
- Eduard, please update [[p2j:Bootstrap_Configuration#Configuration-Reference]] with for the @catch-stop@ configuration.
- 10:14 AM Base Language Bug #10004: NativeInvoker fails if an argument is of type integerConstant
- Artur Școlnic wrote:
> I committed a new solution to 10004a/15917. Constantin, please review.
Why not do this in @C... - 09:45 AM Base Language Bug #10004: NativeInvoker fails if an argument is of type integerConstant
- Artur, that is not what I had in mind. This class uses lots of @.equals(Class<BDT>)@, and the solution needs to be a...
- 07:42 AM Base Language Bug #10004: NativeInvoker fails if an argument is of type integerConstant
- @NativeInvoker@ has lots of cases like @cls.equals(decimal.class)@ - if not solved by #9060, the entire class needs t...
- 08:39 AM Base Language Feature #9447: XML support feature improvements and testing
- Use 9447a.
- 03:41 AM Base Language Feature #9447: XML support feature improvements and testing
- Stefan Vieru wrote:
> They are the same format as the others in @base_language/xml/sax/support@, so I suppose yes.
... - 03:37 AM Base Language Feature #9447: XML support feature improvements and testing
- Stefan Vieru wrote:
> I still have the tests that I created locally, they're not on testcases, should I commit them?... - 03:32 AM Base Language Feature #9447: XML support feature improvements and testing
- Stefan, if you have any other notes to document, please do so.
Otherwise, Teodor, please work on this. - 07:43 AM Base Language Feature #9437: enhancements for Progress.Lang.Class
- Eduard Soltan wrote:
> Problem is that in FWD the access mode of the converted field will always be *private*. But w... - 07:29 AM Database Feature #9440: get-codepage() function should work with CLOB fields
- Review of 15910 rev 9440a:
* this must nest the @rule@s (like if/then/(if/then/else)/else); currently is is (if/then... - 03:31 AM Database Feature #9440 (WIP): get-codepage() function should work with CLOB fields
- Teodor, review of 9440a rev 15909:
* @builtin_functions.rules@ - this code:... - 07:16 AM Runtime Infrastructure Feature #9989: security plugin for appserver/REST/SOAP/web API access
- In 4GL, there is @SESSION:EXPORT(...)@ method, which gets a comma-separated list of names/patters, of 4GL programs wh...
- 04:04 AM Database Bug #9937 (Merge Pending): buffer argument with different DMO than the parameter
- Please merge 9937a now.
05/16/2025
- 11:02 AM Base Language Bug #9997: Apache HttpClient limitations when used via LegacySocketLibrary
- In FWD, the implementation of @OpenEdge.Net.HTTP.Lib.ABLSockets.ABLSocketLibrary@ uses Apache HttpClient library.
... - 10:56 AM Base Language Bug #9997 (New): Apache HttpClient limitations when used via LegacySocketLibrary
- 10:00 AM Database Bug #9969: Parsing query string error with \r character.
- I think we need to handle and escape all control characters - see https://www.ascii-code.com/characters/control-chara...
- 09:43 AM Database Bug #9969: Parsing query string error with \r character.
- Octavian, I think there may be a problem. In a project there is a var defined like:...
05/15/2025
- 01:18 PM Database Feature #9477: implement missing QUERY handle methods/attributes
- Alexandru, do you have any insight about the reposition methods in the first note? I recall seeing mentions about rep...
- 01:16 PM Base Language Bug #9532: codepage support in ASC(), CHR(), OUTPUT TO ... CONVERT and FIX-CODEPAGE()
- Hi Delia, what is the state of #4766? Can you do some preliminary tests with the codepages mentioned by Greg?
- 01:14 PM Database Feature #9546: investigate and implement field options, if missing
- Eric, these are from the .df, right?
Ovidiu: can you take a quick look at would need to be implemented?
05/14/2025
- 02:58 PM Base Language Feature #9437: enhancements for Progress.Lang.Class
- Eduard Soltan wrote:
> I think we could emit in converted class a field of type @WidgetPoolData@.
Please emit an an... - 10:05 AM Base Language Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...
- What is @getDynamicProperty@ returning in your branch?
I would expect if this is a problem of extent vs non-extent... - 08:45 AM Database Bug #9937: buffer argument with different DMO than the parameter
- Eduard Soltan wrote:
> Constantin Asofiei wrote:
>
> > Please continue testing.
>
> Runtime for Chui regressio... - 08:35 AM Database Bug #9937 (Internal Test): buffer argument with different DMO than the parameter
- Eduard Soltan wrote:
> Changed @defineAlias@ and @makeArgumentBuffer@ to create a proxy without @plugin@. Committed ... - 05:05 AM Base Language Feature #6506: implement CGI WebSpeed support and the standard web-disp.p dispatch functionality
- Review of 6506a rev 15764:
* WebContextOps - anything not supported, like FORM/QUERY env, other CGI vars, etc need t... - 04:01 AM Base Language Feature #8904 (Test): implement -catchStop and the integration/conversion of STOP conditions into...
05/12/2025
- 07:05 AM Base Language Feature #6490: DYNAMIC-INVOKE which returns an extent
- Is it 'safe' enough to emit @invoke()@ if LVALUE is a scalar field, and @invokeExtent@ otherwise? Ensuring that an ER...
- 06:03 AM Base Language Feature #6490: DYNAMIC-INVOKE which returns an extent
- What is the behavior in trunk? Also, @ObjectOps.dynamicInvoke@ now returns 'object' or BDT?
05/09/2025
- 08:06 AM Database Bug #9937: buffer argument with different DMO than the parameter
- Alexandru, can you take a look, too, at 9937a? This touches the @ArgumentProxy@ which IIRC was added by you.
- 06:50 AM Database Bug #9937: buffer argument with different DMO than the parameter
- Just to double-check, please do the same in @ctest@, but with the @btt2 for tt2@ buffer (which will not use the @buff...
- 06:19 AM Database Bug #9937: buffer argument with different DMO than the parameter
- Eduard, the approach is good and it should work; your reasoning is correct, the temp-tables need to be schema-compati...
- 02:55 AM Database Bug #9937: buffer argument with different DMO than the parameter
- I don't think is OK to have methods from both Tt2_1 and TT1_1 DMO interfaces.
I don't think @Proxy3@ should be ret... - 07:40 AM Base Language Feature #9516: include pre-converted webspeed runtime code in FWD
- You will also need to add @${P2J_HOME}/abl/ade/src/@ to the PROPATH in @p2j.cfg.xml@.
- 07:38 AM Base Language Feature #9516: include pre-converted webspeed runtime code in FWD
- You need to copy the skeleton project , and also add @<parameter name="oo-skeleton-path" value="skeleton" />@ in @p2j...
- 06:39 AM Base Language Feature #6490: DYNAMIC-INVOKE which returns an extent
- Paul, please get the review addressed, rebase and lets get it through testing.
- 06:34 AM Base Language Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...
- This is really weird - looks like a bug in 4GL, you can pass @DYNAMIC-PROPERTY(props, "intExt1")@ as an argument to a...
- 02:43 AM Conversion Tools Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
- Danut/Eduard: note that in trunk rev 15888.1.1 (commit 15889) there were some other fixes related to #7255.
05/08/2025
- 06:23 AM Database Feature #9543: implement missing BUFFER attributes
- Eduard Soltan wrote:
> Constantin Asofiei wrote:
> > Please also double-check the @ASSIGN@ statement if it trigger... - 04:53 AM Database Feature #9543: implement missing BUFFER attributes
- What happens if you do:...
- 02:32 AM Database Feature #9543: implement missing BUFFER attributes
- Please also double-check the @ASSIGN@ statement if it triggers the synchronize or not. If the @ASSIGN@ part of @BUFF...
05/07/2025
- 12:19 PM Database Feature #9543: implement missing BUFFER attributes
- For @BUFFER-COPY@, if the destination buffer has no loaded record, then it CREATE's a record in that buffer. So, ple...
- 10:57 AM Database Feature #9543: implement missing BUFFER attributes
- Also, are there cases when @auto-synchronize@ is disabled temporarily, like for @save-row-changes@ or @fill@ method c...
- 10:56 AM Database Feature #9543: implement missing BUFFER attributes
- Can this be described in short, the synchronize is automatically called when the buffer's record is either loaded, re...
- 10:11 AM Database Feature #9543: implement missing BUFFER attributes
- OK, so we already support @SYNCHRONIZE@ method via @Buffer.querySynchronize@ - so looks like we just need to call it ...
- 07:19 AM Database Feature #9543 (WIP): implement missing BUFFER attributes
- Actually, this is back to WIP.
Eduard: did you get a chance to test how these attrs should behave at runtime? - 07:18 AM Database Feature #9543 (Test): implement missing BUFFER attributes
- 08:51 AM Database Bug #9969: Parsing query string error with \r character.
- Please also see #9967, which is somehow related to the escape char used under linux.
- 08:32 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...
- Greg, I can't find an exact task for this - I think the discussion was spread-out for runtime query conversion, incre...
- 08:20 AM Database Bug #9950: Upgrade the metadata schema to a newer version
- Ovidiu, please get some preliminary changes in a branch, so we can patch 9457c and test FWD server startup.
- 05:03 AM TRPL Feature #1752: eliminate statics/singleton patterns in all TRPL worker classes and other dependen...
- If you look at @DataModelWorker@, you will see the static state is in a @WorkArea@ class, to be context-local. This ...
- 04:16 AM Base Language Bug #9819: SESSION:FIRST-ASYNC-REQUEST and SESSION:LAST-ASYNC-REQUEST
- I can not make SESSION:FIRST/LAST-ASYNC-REQUEST to return anything else other than unknown with 11.7:
* start progra... - 03:58 AM Base Language Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...
- Please merge 8904a to trunk after 9877a.
- 03:58 AM Base Language Bug #9877: output extent parameter when the type is object
- Please merge 9877a to trunk now.
05/06/2025
- 12:29 PM Base Language Bug #9967: unix separator in strings gets resolved as unicode separator
- This test when ran on Windows and Linux OpenEdge has different outputs:...
- 12:20 PM Base Language Bug #9967 (New): unix separator in strings gets resolved as unicode separator
- 05:23 AM Database Bug #9937: buffer argument with different DMO than the parameter
- Does this solve cases when the field is in an expression, copy-temp-table and others? Because @getDMOProxy();@ is us...
- 02:15 AM Database Bug #9937: buffer argument with different DMO than the parameter
- Ovidiu Maxiniuc wrote:
> Yes, I am aware, as you quoted me, _"[...] which declare the @new shared@ tables and *simpl...
05/05/2025
- 01:48 PM Database Bug #9937: buffer argument with different DMO than the parameter
- Ovidiu Maxiniuc wrote:
> So I think that would be the right implementation: to remove these attributes (like @xml-no... - 12:50 PM Database Bug #9937: buffer argument with different DMO than the parameter
- Eduard Soltan wrote:
> Question: Since we established in #9763 that @xml-node-name@ is a property specific to the bu... - 04:04 AM Database Bug #9937: buffer argument with different DMO than the parameter
- Eduard, I've tried something like this to create the proxy:...
04/30/2025
- 08:15 AM Base Language Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...
- Please don't use @this.text@, use @evalLib("type_pair", prog.func_int, prog.kw_extent, this)@ (or something like this).
- 03:10 AM Base Language Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...
- Paul Bodale wrote:
> Should I also touch on the other cases?
We need to cover the same cases done for @DYNAMIC-INVO... - 05:25 AM Base Language Feature #9436: add built-in OO classes
- Ioana-Cristina Prioteasa wrote:
> I added the @Array.cls@ and @ArrayIterator.cls@ from github ADE, where they are th...
04/29/2025
- 10:02 AM Base Language Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...
- Constantin Asofiei wrote:
> That should have converted as @res = assignMulti(res, ...)@. That is the problem.
And ... - 10:01 AM Base Language Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...
- That should have converted as @res = assignMulti(res, ...)@. That is the problem.
- 09:58 AM Base Language Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...
- Please post the entire testcase. The Java reference of an array is re-assigned *only if it was resized* (so dynamic ...
04/28/2025
- 08:18 AM Base Language Feature #9436: add built-in OO classes
- How is the test executed? With @NO-ERRO@?
- 07:23 AM Base Language Bug #9893 (Internal Test): LegacyErrorException is not rethrown in processForBody/processBody
- Andrei Plugaru wrote:
> Constantin, can we move on to testing? If yes, I can do the unit tests and fwd tests of a la... - 05:31 AM Base Language Bug #9893: LegacyErrorException is not rethrown in processForBody/processBody
- The changes make sense in -9754a- 9753a/15850.
- 07:22 AM Base Language Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...
- Paul Bodale wrote:
> Constantin Asofiei wrote:
> > Please see #9488-157 - I think Ioana already fixed the unknown p... - 05:20 AM Base Language Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...
- Please see #9488-157 - I think Ioana already fixed the unknown problem for extent resize.
- 02:52 AM Base Language Bug #9877 (Merge Pending): output extent parameter when the type is object
- Conversion testing passed - do not merge now. I will post when this can be merged.
Also available in: Atom