Golden Code Redmine

07/21/2025

09:47 AM Database Support #6709: track nested FIND inside a related FOR loop

I see the ChUI project used @datanames.xml@ which also changes how the converted project sees the bufname and filenam... Dănuț Filimon

08:57 AM Database Support #6709: track nested FIND inside a related FOR loop

I'll have to work on the conversion changes a bit more, the bufname is not the right one to use in this case. I've fo... Dănuț Filimon

07:34 AM Database Support #6709: track nested FIND inside a related FOR loop

I implemented the conversion changes necessary, this works by emitting a DataModelObject array before the Object arra... Dănuț Filimon

07/18/2025

06:50 AM Database Support #6709: track nested FIND inside a related FOR loop

Greg Shah wrote:
> Dănuț Filimon wrote:
> > [...]
> >
> > I can't come up with any idea on how to let the FindQu... Dănuț Filimon

03:51 AM Database Support #6709: track nested FIND inside a related FOR loop

... Dănuț Filimon

06:06 AM Conversion Tools Bug #9917: Fileset not ignoring case

Dănuț Filimon wrote:
> The customer application converted, but the build failed. Some temp-table dmos were missing a... Dănuț Filimon

05:02 AM Database Bug #9078: emit FindQuery as (reused) variables

I did a ChUI conversion and the project built with no issues, I noticed both the array and variable FindQuery types b... Dănuț Filimon

07/17/2025

06:59 AM Database Support #6709: track nested FIND inside a related FOR loop

I committed *6709a/16052*. Added FOR_LOOP_WHILE and DO_TO_WHILE reports, fixed database joins report. (refs: #6709)
... Dănuț Filimon

05:24 AM Database Support #6709: track nested FIND inside a related FOR loop

Added a fix to *6709a/16051*, only reports are affected. I also got the report results for the ChUI application.
!ch... Dănuț Filimon

03:20 AM Database Support #6709: track nested FIND inside a related FOR loop

One solution would be to consider all FindQuery nested when its buffers can be found in the @openBuffers@ and we are ... Dănuț Filimon

03:12 AM Database Support #6709: track nested FIND inside a related FOR loop

Greg Shah wrote:
> If we are implementing a runtime mode for this detection, we would expect to use the @Transaction... Dănuț Filimon

03:19 AM Conversion Tools Bug #9917: Fileset not ignoring case

--- deleted, the comment was for another issue Dănuț Filimon

02:28 AM Conversion Tools Bug #9917: Fileset not ignoring case

The customer application converted, but the build failed. Some temp-table dmos were missing and might be caused by so... Dănuț Filimon

07/16/2025

06:31 AM Database Support #6709: track nested FIND inside a related FOR loop

Dănuț Filimon wrote:
> I'm looking into the runtime changes and how the blocks are converted at the moment, just to ... Dănuț Filimon

06:03 AM Database Support #6709: track nested FIND inside a related FOR loop

Ovidiu/Alexandru, please review 6709a for the report changes. Dănuț Filimon

05:20 AM Database Support #6709 (Review): track nested FIND inside a related FOR loop

I'm looking into the runtime changes and how the blocks are converted at the moment, just to understand what I can us... Dănuț Filimon

04:10 AM Database Support #6709: track nested FIND inside a related FOR loop

I rebased *6709a* to latest *trunk/16046* and committed *16050*. Added nested find block type reports. Dănuț Filimon

03:17 AM Database Bug #10111: All statements are logged to a single text file for P2JQueryLogger and SQLStatementLo...

10111a changes should also be ported to *7156e*. Dănuț Filimon

03:12 AM Conversion Tools Bug #9917: Fileset not ignoring case

There's a single customer application left to test to get 9917a into the merge queue and tomorrow I expect to get the... Dănuț Filimon

07/15/2025

05:54 AM Database Support #6709: track nested FIND inside a related FOR loop

I've managed to get a report for nested FINDs in FOR EACH statements, the report works in the following way:
# there... Dănuț Filimon

04:04 AM Database Support #6709: track nested FIND inside a related FOR loop

Alexandru Lungu wrote:
> Is this ready for review? Or are you actively working on #6709-47?
I'm working on #6709-... Dănuț Filimon

07/14/2025

07:19 AM Database Bug #9078: emit FindQuery as (reused) variables

DO blocks are quite tricky, those blocks do not have an instvarid and in some cases I can get out of the expected blo... Dănuț Filimon

07/11/2025

08:58 AM Database Support #6709: track nested FIND inside a related FOR loop

To do:
* add a report where nested find queries are displayed based on the type of block, but only if the block refe... Dănuț Filimon

07:40 AM Database Support #6709: track nested FIND inside a related FOR loop

Committed *6709a/16034*. Included UNIQUE finds in the report, I missed those previously. Dănuț Filimon

06:54 AM Database Support #6709: track nested FIND inside a related FOR loop

Dănuț Filimon wrote:
> * Nested FIND: 13 first, 6 next, 5 last, 5 current, 3 where (this is confusing a bit because ... Dănuț Filimon

06:35 AM Database Bug #9078 (Review): emit FindQuery as (reused) variables

Fixed #9078-113 in *9078b/16039*. We did not emit the find query as a variable when we had a block in the queue, but ... Dănuț Filimon

05:21 AM Database Bug #9078 (WIP): emit FindQuery as (reused) variables

Found the issue from #9078-113 again, but I got a reliable reproduction this time. It seems that when I use the array... Dănuț Filimon

07/10/2025

09:24 AM Database Support #6709: track nested FIND inside a related FOR loop

I ran the reports for hotel and got:
* Nested FIND: 13 first, 6 next, 5 last, 5 current, 3 where (this is confusing ... Dănuț Filimon

08:02 AM Database Support #6709: track nested FIND inside a related FOR loop

Committed *6709a/16032*. Extended the functionality of the nested_find annotation and added more detailed reports:
... Dănuț Filimon

02:14 AM Conversion Tools Feature #6256: improved profile support

Greg Shah wrote:
> > I got a message from Razvan that he converted the ChUI project, but the "convert" command was s... Dănuț Filimon

07/09/2025

08:00 AM Database Support #6709: track nested FIND inside a related FOR loop

... Dănuț Filimon

07:16 AM Conversion Tools Feature #6256: improved profile support

Greg Shah wrote:
> > and there are different ways to get the file-set?
>
> What do you mean?
ChUI project uses... Dănuț Filimon

03:21 AM Conversion Tools Feature #6256: improved profile support

I got a message from Razvan that he converted the ChUI project, but the "convert" command was skipped. This is becaus... Dănuț Filimon

07/08/2025

09:47 AM Database Support #6709: track nested FIND inside a related FOR loop

Alex, I took a look at the last example from #6709-38 and only the FOR EACH find has the nested_find annotation. Are ... Dănuț Filimon

09:05 AM Database Support #6709: track nested FIND inside a related FOR loop

I'll mention a few ideas from the latest discussions so that I do not lose track of them:
* Tracking nested finds in... Dănuț Filimon

07:55 AM Database Bug #9078 (Review): emit FindQuery as (reused) variables

I added 9078b to my ETF conversion queue, it will take a while to get through it. Dănuț Filimon

07:54 AM Database Bug #9078: emit FindQuery as (reused) variables

Dănuț Filimon wrote:
> I've managed to fix the issue, I've also noticed that CAN-FINDs were ignored and AdaptiveFind... Dănuț Filimon

07:23 AM Database Bug #9078: emit FindQuery as (reused) variables

I've managed to fix the issue, I've also noticed that CAN-FINDs were ignored and AdaptiveFinds were also counted. I'l... Dănuț Filimon

06:24 AM Database Bug #9078 (WIP): emit FindQuery as (reused) variables

I've found an issue while converting ETF:... Dănuț Filimon

07/07/2025

07:17 AM Database Bug #9078: emit FindQuery as (reused) variables

Rebased *9078b* to latest *trunk/16028*, the branch is now at revision *16037*. Dănuț Filimon

02:39 AM Database Bug #9078: emit FindQuery as (reused) variables

Constantin Asofiei wrote:
> Danut, does @AdaptiveFind@ still emit properly? This is the @FIND FIRST. REPEAT: FIND N... Dănuț Filimon

06:44 AM Conversion Tools Bug #10208: do not convert the schema in incremental mode if it hasn't changed

I committed *10208a/16007*. Added IncrementalCvtRunMode and used to skip most of the phases that involve the database... Dănuț Filimon

07/04/2025

02:20 AM Conversion Tools Bug #10208: do not convert the schema in incremental mode if it hasn't changed

In our weekly meeting, I mentioned that I would not modify how the M0, M1, F2 and F3 modes are used. I decided to tak... Dănuț Filimon

07/03/2025

07:57 AM Database Bug #9078 (Review): emit FindQuery as (reused) variables

Committed *9078b/16012*. In case of a DO block that is also a loop, ensure that a block/inner block with "instvarid" ... Dănuț Filimon

06:17 AM Database Bug #9078 (WIP): emit FindQuery as (reused) variables

There's a scenario when using a DO block as a loop and there is no "instvarid" to attach the array, this causes the c... Dănuț Filimon

07/02/2025

08:56 AM Conversion Tools Feature #6256: improved profile support

Greg Shah wrote:
> My only question is why would the metadata schema be bypassed in profile mode. I understand it w... Dănuț Filimon

06:41 AM Conversion Tools Feature #6256 (Review): improved profile support

Committed *6256a/15946* for review, the branch contains:
* The NPE fix for the issue mentioned in #6256-97 - reintro... Dănuț Filimon

07/01/2025

09:12 AM Conversion Tools Feature #7180 (WIP): create a centralized manager for the conversion list and per-file/project st...

I'll put this into WIP until 5586a (#5586) is merged, the purpose is to get 7180a rebased to latest trunk which conta... Dănuț Filimon

08:04 AM Conversion Tools Feature #6256: improved profile support

The issue with the database is actually related to how the default profile in SchemaCOnfig is set, the root cause is ... Dănuț Filimon

06:05 AM Conversion Tools Feature #6256: improved profile support

The global schema should be used by a profile only when none of the active profiles have a schema defined, this is th... Dănuț Filimon

02:43 AM Conversion Tools Feature #6256 (WIP): improved profile support

Dănuț Filimon

02:43 AM Conversion Tools Feature #6256: improved profile support

Dănuț Filimon wrote:
> Greg Shah wrote:
> > If a profile contains any schema at all, then the top-level namespaces ... Dănuț Filimon

06/30/2025

07:29 AM Conversion Tools Bug #10208: do not convert the schema in incremental mode if it hasn't changed

Greg, the skipDBSchema is quite old. I suggest removing it and using the @schema@ flag to do the job. Dănuț Filimon

06:24 AM Conversion Tools Bug #10208: do not convert the schema in incremental mode if it hasn't changed

#10208-13 can be achieved by correctly setting CvtRunMode.skipDBSchema, I made it protected and did the following for... Dănuț Filimon

05:34 AM Conversion Tools Bug #10208: do not convert the schema in incremental mode if it hasn't changed

I created *10208a* from *trunk/16005* and committed an initial version in *10208a/16006*. The changes are for #10208-9. Dănuț Filimon

03:54 AM Conversion Tools Bug #10208: do not convert the schema in incremental mode if it hasn't changed

I've made a few changes as mentioned in #10208-9, but I am wondering if there are any other conversion steps I should... Dănuț Filimon

02:26 AM Database Bug #9078: emit FindQuery as (reused) variables

Dănuț Filimon wrote:
> Artur found a regression while converting a customer application, currently investigating.
I... Dănuț Filimon

02:18 AM Database Bug #9078: emit FindQuery as (reused) variables

Artur found a regression while converting a customer application, currently investigating. Dănuț Filimon

02:14 AM Conversion Tools Feature #6256: improved profile support

Greg Shah wrote:
> If a profile contains any schema at all, then the top-level namespaces are ignored. I think that... Dănuț Filimon

06/27/2025

09:12 AM Conversion Tools Bug #10208 (WIP): do not convert the schema in incremental mode if it hasn't changed

Dănuț Filimon

09:12 AM Conversion Tools Bug #10208: do not convert the schema in incremental mode if it hasn't changed

My current implementation works like this:
# @SchemaLoader.importSchema()@ should call @ConversionData.saveFileHash(... Dănuț Filimon

03:29 AM Conversion Tools Bug #10208: do not convert the schema in incremental mode if it hasn't changed

Greg Shah wrote:
> I don't object, but can we just add the schemata to the FILE_SIGNATURE table?
Yes, I will do t... Dănuț Filimon

09:01 AM Database Bug #9078: emit FindQuery as (reused) variables

I committed *9078b/16010* to address #9078-101 and #9078-102. Dănuț Filimon

04:16 AM Database Bug #9078: emit FindQuery as (reused) variables

Ovidiu Maxiniuc wrote:
> I looked at 9078b / r16008.
>
> The code looks pretty much solid. But it's difficult to ... Dănuț Filimon

06/26/2025

09:06 AM Conversion Tools Bug #10208: do not convert the schema in incremental mode if it hasn't changed

As far as I can tell, there doesn't seem to be any information (e.g. hash) for the schema file in the cvtdb database.... Dănuț Filimon

07:25 AM Database Bug #9078: emit FindQuery as (reused) variables

Rebased *9078b* to latest *trunk/16003*, the branch is now at revision *16008*. Dănuț Filimon

06:57 AM Database Bug #9078 (Review): emit FindQuery as (reused) variables

Committed *9078b/15974*, Added rules to count the number of FindQuery instances in a top level block, but also added ... Dănuț Filimon

06/25/2025

09:05 AM Database Bug #9078: emit FindQuery as (reused) variables

Dănuț Filimon wrote:
> I managed to get a working version for #9078-95 and started working on a version where it use... Dănuț Filimon

08:18 AM Database Bug #9078: emit FindQuery as (reused) variables

I managed to get a working version for #9078-95 and started working on a version where it uses an array in case too m... Dănuț Filimon

04:56 AM Database Bug #9078: emit FindQuery as (reused) variables

Current rule-set:... Dănuț Filimon

04:53 AM Database Bug #9078: emit FindQuery as (reused) variables

Constantin mentioned that I could count the number of FindQueries for each top level block and emit the array only wh... Dănuț Filimon

04:02 AM Base Language Bug #9996 (Test): Object references should be decremented at the nearest block instead of the top...

Branch 9538d was merged to trunk revision 15998 and archived. Dănuț Filimon

02:30 AM Base Language Bug #9996: Object references should be decremented at the nearest block instead of the top-level ...

9538d passed all regression tests and can be merged. Dănuț Filimon

06/24/2025

03:37 AM Conversion Tools Feature #6256 (Review): improved profile support

I've tested hotel with 2-4 profiles and found no other issues. Greg/Constantin, please review.
#6256-47 is already... Dănuț Filimon

06/23/2025

09:15 AM Database Bug #9078: emit FindQuery as (reused) variables

I've made some progress, but I will have to refactor all of the changes for the FindQuery. If I am using an array to ... Dănuț Filimon

03:11 AM Database Bug #9078: emit FindQuery as (reused) variables

Ovidiu Maxiniuc wrote:
> I was thinking about @fqueryArray[0] = new FindQuery();@ initialization. To have a more com... Dănuț Filimon