General

Profile

Greg Shah's activity

From 07/26/2025 to 08/24/2025

08/21/2025

10:31 AM Conversion Tools Feature #10459: migrate all project configuration into a single jSON configuration file
> The "new" hotel method generates a JSON based upon the responses to the prompts.
We will want to invert that. ...
Greg Shah
09:12 AM Conversion Tools Feature #10459: migrate all project configuration into a single jSON configuration file
The current approach to conversion project configuration is a frankenstein monster which we have pieced together over... Greg Shah
08:46 AM Conversion Tools Feature #10459 (New): migrate all project configuration into a single jSON configuration file
Greg Shah
08:29 AM Conversion Tools Feature #10458 (Rejected): stable and deterministic name generation during app-by-app conversion
This work is already represented in #9639. Greg Shah
08:23 AM Conversion Tools Feature #10458: stable and deterministic name generation during app-by-app conversion
We need to ensure that the names we generate (classes, methods, data members...) are stable and deterministic. This ... Greg Shah
08:00 AM Conversion Tools Feature #10458 (Rejected): stable and deterministic name generation during app-by-app conversion
Greg Shah
08:28 AM Conversion Tools Feature #9639: centralized name management (and conversion) OR jar based resolution
We need to ensure that the names we generate (classes, methods, data members...) are stable and deterministic. This ... Greg Shah
07:57 AM Conversion Tools Bug #8967 (Closed): Remove relationship annotation from full conversion
Greg Shah
07:22 AM Conversion Tools Bug #10208: do not convert the schema in incremental mode if it hasn't changed
I'm OK with a merge but please coordinate with Constantin to ensure that we don't negatively affect customer deliveri... Greg Shah

08/20/2025

09:58 AM Runtime Infrastructure Feature #10451: GUI interaction event logging
Let's use FINER or FINEST instead of INFO. Greg Shah
08:38 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...
> All @NameConverterWorker@ state is context-local implemented for runtime conversion. I had to share that state betw... Greg Shah
06:10 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...
I don't want to artificially limit our future improvements by forcing single threading for any significant portion of... Greg Shah

08/19/2025

02:19 PM User Interface Bug #10442 (Rejected): FILL-IN for Decimal Variable: Issues with Screen Value Display
Greg Shah
10:36 AM Runtime Infrastructure Feature #10451: GUI interaction event logging
A common log file is useful because then all logging has context about what was happening. To make that work, we wou... Greg Shah

08/18/2025

07:58 AM Database Support #10420: Refactoring DMO interface layers
This would certainly solve the concern I had in #9976 and much more. It seems to me that the performance of this pro... Greg Shah

08/14/2025

07:07 AM Conversion Tools Bug #10208 (Internal Test): do not convert the schema in incremental mode if it hasn't changed
Code Review Task Branch 10208a Revision 16117
I like it.
Greg Shah
07:01 AM Database Feature #6720: lazy hydration
> Yes, but this was actually the case even before #9701. The return value of the @equalData@ method is used to update... Greg Shah

08/13/2025

12:36 PM Database Feature #6720: lazy hydration
> @16110@ and @16112@: Apart from unimportant rebase issues, I have changed the implementation of @BaseRecord.equalD... Greg Shah
12:07 PM Database Feature #6720: lazy hydration
> The original implementation of #6720 was to cover as many scenarios as possible, but the @OPEN QUERY@ and @FIND FIR... Greg Shah
11:49 AM FWD Bug #10422: Some documentations links seem broken
Those pages do not exist yet. Greg Shah
11:49 AM FWD Bug #10422: Some documentations links seem broken
From Onno:
I was checking out documentation and noticed these broken links:
PAGE
https://proj.goldencode.com/p...
Greg Shah
11:38 AM Runtime Infrastructure Support #10389 (Review): Ending Web application does not free port
Greg Shah
08:38 AM Runtime Infrastructure Feature #9687: drop support for Java 8 and Java 11
Please rebase 9687c from trunk 16111. There was another regression in incremental conversion from the 5586a changes,... Greg Shah

08/12/2025

03:27 PM Runtime Infrastructure Feature #9687: drop support for Java 8 and Java 11
I've pushed 9687c revision 16135 to xfer. Greg Shah
03:24 PM Runtime Infrastructure Feature #9687: drop support for Java 8 and Java 11
I'm going to push this to xfer. Greg Shah

08/11/2025

11:24 AM Runtime Infrastructure Feature #9687: drop support for Java 8 and Java 11
OK, the pushed branch looks OK now. I've pushed it to xfer. Greg Shah
10:36 AM Runtime Infrastructure Feature #9687: drop support for Java 8 and Java 11
> In meantime on customer's request I've rebased branch 9687c to trunk revision 16089.
9687c seems to be based on ...
Greg Shah
09:55 AM Runtime Infrastructure Feature #9687: drop support for Java 8 and Java 11
I don't want to squash changes in every rebase. We did that once to deal with some conflicting changes in trunk. Le... Greg Shah
09:29 AM Runtime Infrastructure Feature #9687 (Internal Test): drop support for Java 8 and Java 11
What testing is needed before we make this available to a customer?
Also: Hynek, I think we need your help with th...
Greg Shah

08/08/2025

11:07 AM Base Language Bug #4766: fix CHR and ASC
> An idea I had is to enhance the character data with additional information about where the content came from.
I ...
Greg Shah
10:55 AM Conversion Tools Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Please consider if code like @Configuration.getPathToSourceFileFromConversionFolder()@ should be in the @AM@ instead ... Greg Shah

08/07/2025

12:45 PM Runtime Infrastructure Feature #9687: drop support for Java 8 and Java 11
Hynek: Are you OK with the changes? Greg Shah
07:07 AM Runtime Infrastructure Feature #9687: drop support for Java 8 and Java 11
Tomasz Domin wrote:
> Tomasz Domin wrote:
> > Oh, that is not true as @EmbeddedWebServer@ is part of a client. I'll...
Greg Shah
07:58 AM Conversion Tools Bug #10208 (Internal Test): do not convert the schema in incremental mode if it hasn't changed
Code Review Task Branch 10208a Revision 16080
The change is good.
Greg Shah

08/05/2025

02:51 PM Testing Support #6859: preprocessor tests
In each of these cases, you'll have to change this:... Greg Shah
08:04 AM Conversion Tools Bug #10208: do not convert the schema in incremental mode if it hasn't changed
OK, then add a comment to explain that in full conversion mode, all schemata will be detected as "changed" and will b... Greg Shah
07:38 AM Conversion Tools Bug #10208: do not convert the schema in incremental mode if it hasn't changed
Code Review Tk Branch 10208a Revision 16078
Overall, I agree with the changes for when we are running incremental ...
Greg Shah

08/04/2025

02:41 PM Base Language Bug #10373: Try to replace the StackUnwindExceptions used for control flow in BlockManager with a...
This is indeed a good idea and it will improve performance. We have worked on some of this already, including implem... Greg Shah
08:08 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...
Octavian Adrian Gavril wrote:
> Does current conversion prioritize the super-class persistence over the current proc...
Greg Shah

08/01/2025

09:08 AM Base Language Bug #10313: server-sidef file-system must 'mount' user's working dir and look in this path by def...
Artur Școlnic wrote:
> Isn't there a place where all relative file names are resolved to the current working dir? Wi...
Greg Shah
09:06 AM Base Language Bug #10313: server-sidef file-system must 'mount' user's working dir and look in this path by def...
> *Greg*: in terms of #9055, I think there is more than what we can identify easily. We can release 10313a, and afte... Greg Shah

07/31/2025

01:40 PM Runtime Infrastructure Feature #9687: drop support for Java 8 and Java 11
Perhaps we should disable it by default and provide a configuration option to enable it. Greg Shah
08:20 AM Runtime Infrastructure Feature #9687: drop support for Java 8 and Java 11
Why is it an issue now when it wasn't before?
Whatever we do, the solution is not to have a Jetty property file or...
Greg Shah
01:33 PM Conversion Tools Bug #10208 (WIP): do not convert the schema in incremental mode if it hasn't changed
Code Review Task Branch 10208a Revisons 16075 through 16077
Overall the changes are a good first pass. In most ca...
Greg Shah

07/30/2025

06:13 AM Base Language Bug #4766: fix CHR and ASC
> Greg, please see the test in #4766-123 - this contradicts what I suggested to use cpinternal for PUT/GET-STRING. ... Greg Shah

07/28/2025

10:53 AM User Interface Feature #9055: server-side processing of client platform dependencies in the UI
Code Review Task Branch 9055a Revisions 16071 through 16083
I don't have any objections.
Have you prepared chan...
Greg Shah
 

Also available in: Atom