Constantin Asofiei's activity
From 07/27/2025 to 08/25/2025
08/25/2025
- 06:48 AM Conversion Tools Bug #10469: incremental conversion when basepath is more than one folder (aka abl/foo) with #5586
- You need to add @:${P2J_HOME}/abl/hotel/@ to @propath@ in @p2j.cfg.xml@. If we look in @Configuration.getPathToConve...
- 06:05 AM Conversion Tools Bug #10469: incremental conversion when basepath is more than one folder (aka abl/foo) with #5586
- There is a bug when @basepath="./abl/hotel/"@ and @cvtpath="./cvt"@. Incremental conversion will fail because @Confi...
- 06:04 AM Conversion Tools Bug #10469 (Test): incremental conversion when basepath is more than one folder (aka abl/foo) wit...
- 06:05 AM Conversion Tools Feature #6256 (Test): improved profile support
- OK, moved to 10469.
- 05:57 AM Conversion Tools Feature #6256 (WIP): improved profile support
- There is a bug when @basepath="./abl/hotel/"@ and @cvtpath="./cvt"@. Incremental conversion will fail because @Confi...
08/22/2025
- 07:49 AM Base Language Bug #10313 (Merge Pending): server-sidef file-system must 'mount' user's working dir and look in ...
- Go ahead and merge now.
08/21/2025
- 10:18 AM Base Language Bug #10313: server-sidef file-system must 'mount' user's working dir and look in this path by def...
- Please create a task in the customer's project to discuss this.
10313a will not be delayed for this bug. - 04:55 AM Base Language Bug #10313: server-sidef file-system must 'mount' user's working dir and look in this path by def...
- Artur Școlnic wrote:
> Constantin Asofiei wrote:
> > Are they created in the working dir of the FWD client, when se... - 04:29 AM Base Language Bug #10313: server-sidef file-system must 'mount' user's working dir and look in this path by def...
- Are they created in the working dir of the FWD client, when server-side resources are present?
- 02:04 AM Base Language Bug #10313: server-sidef file-system must 'mount' user's working dir and look in this path by def...
- Artur Școlnic wrote:
> Constantin, is there something else we should address at this point?
I think if we fix Targe... - 09:14 AM Conversion Tools Feature #10459: migrate all project configuration into a single jSON configuration file
- There are also schema hint files.
We should also have a tool to gather all these input files and generate the .jso... - 08:50 AM Conversion Tools Bug #10208 (Merge Pending): do not convert the schema in incremental mode if it hasn't changed
- You can merge to trunk now.
08/20/2025
- 04:06 AM Base Language Bug #10391: Comparisons methods not returning the correct result in poly cases
- Please check also when right-side operand is POLY, like @if -1 < DYNAMIC-FUNCTION("f") @ - does this use integer as c...
08/19/2025
- 03:59 AM Base Language Bug #10406 (Internal Test): Wrong parameter mode for buffers passed to a constructor
- Thanks.
- 02:42 AM Base Language Bug #10406: Wrong parameter mode for buffers passed to a constructor
- I'm OK with the change.
Teodor: can you do a manual runtime test with the example in first note? If FWD calls prop... - 03:58 AM Database Bug #10398 (Internal Test): Incorrect base data type used in buffer dereference
- Looks good, thanks.
- 03:47 AM Database Bug #10398: Incorrect base data type used in buffer dereference
- Please check if the @bdt.isUnknown()@, also - I assume no ERROR condition is raised in this case, and it just returns...
- 03:12 AM Database Bug #10398: Incorrect base data type used in buffer dereference
- Please work on this as Eduard is out. I'd like to have this and #10406 in trunk so we can run another conversion.
- 02:46 AM Database Bug #10398: Incorrect base data type used in buffer dereference
- The change looks good. The only unknown is what happens if @h::f1@ is i.e. a character - is there an ERROR condition...
- 02:22 AM Database Bug #10351 (Merge Pending): ProDataSet READ-XML issue when temp-table node is the same as dataset...
- 10351a can be merged after 10360a
- 02:22 AM Database Bug #10360 (Merge Pending): FOR loop WHERE condition evaluation issue
- 10360a can be merged now.
08/18/2025
- 08:03 AM Conversion Tools Feature #6256 (Merge Pending): improved profile support
- 6256a can be merged now.
08/06/2025
- 11:33 AM Base Language Bug #10313: server-sidef file-system must 'mount' user's working dir and look in this path by def...
- * @FileSystemDaemon.searchPathWithExts@ - the javadoc says that this also does PROPATH lookups - but I can't find whe...
- 11:28 AM Base Language Bug #10313: server-sidef file-system must 'mount' user's working dir and look in this path by def...
- Artur, there are still concerns:
* in @FileSystemOps.initFileInfo@ - why @origName.isEmpty()@?...
08/05/2025
- 08:11 AM Database Feature #9456: implement SQL Server dialect and helpers
- Alexandru, is this something which prevents 9456b to be merged to trunk? Does it affect other dialects than SQLServer?
- 07:10 AM Database Bug #10351: ProDataSet READ-XML issue when temp-table node is the same as dataset node
- OK, so if you have something like @foo/bar/@ in the XMl structure, and neither foo or bar match the temp-table, then ...
- 07:07 AM Database Bug #10360: FOR loop WHERE condition evaluation issue
- Hm... why is @success@ true in this case?
- 07:02 AM Base Language Bug #10336 (Internal Test): Issue on object deletion: java.lang.IllegalStateException
- 05:52 AM Database Feature #6457: finish COPY-LOB support
- Eduard Soltan wrote:
> > * @longchar.java@
> > ** why @"" + StringHelper.@ ?
>
> Because if value was @null@, a...
08/04/2025
- 04:49 PM Base Language Bug #10308 (Internal Test): DYNAMIC TEMP-TABLE issue when using READ-XML before TEMP-TABLE-PREPARE
- Teodor, I understand now your changes. Please go ahead with testing.
- 03:56 PM Base Language Bug #10336: Issue on object deletion: java.lang.IllegalStateException
- Teodor, please test this change with the unit-test in question. In RecordBuffer:...
- 02:35 PM Database Bug #10351: ProDataSet READ-XML issue when temp-table node is the same as dataset node
- OK, what you found is if the root node does not match the dataset, and is a temp-table (serialized) name, then the ro...
- 05:49 AM Database Bug #10351: ProDataSet READ-XML issue when temp-table node is the same as dataset node
- Teodor, is this related to #10203 ?
- 01:54 PM Database Bug #10360 (WIP): FOR loop WHERE condition evaluation issue
- Teodor, the fix is not OK. The root cause is the @block-level on error undo, throw.@ clause in FWD and an additional...
- 01:19 PM Base Language Bug #10352: Fix READ-JSON dataset handle method's behaviour
- Paul, the problems are multiple:
* @processHiddenFk@ - here I think all the relation fields need to be registered, r... - 01:01 PM Base Language Bug #10366 (Internal Test): ObjectOps.invokeStandalonePoly does not change output parameter value
- Good catch, I'm OK with the changes.
- 10:08 AM Base Language Bug #10313: server-sidef file-system must 'mount' user's working dir and look in this path by def...
- Artur, about 10313a rev 16068:
* @searchPath@
** will return the same relative path, not absolute. I don't know i... - 06:35 AM Database Feature #6457 (WIP): finish COPY-LOB support
- Review for 6457a rev 16070:
* missing history entry or copyright year update: @block_properties.rules@, @copy_lob.ru... - 03:30 AM Base Language Bug #10365: Mismatched number of parameters passed to routine for external function
- Make sure you @-Drules.tracing=true@ to see where/how this gets emitted. Also, add a normal function and check how th...
08/01/2025
- 01:00 PM Database Feature #9456: implement SQL Server dialect and helpers
- Constantin Asofiei wrote:
> * the @releaseSavepoint@ part - for non-local dbs, that should also check via JDBC for t... - 12:43 PM Database Feature #9456: implement SQL Server dialect and helpers
- Ovidiu, some notes:
* the @"FirstNumber".equals(firstColumnLabel)@ approach (appears twice now in the code) I think ... - 09:25 AM Database Feature #9456: implement SQL Server dialect and helpers
- Alexandru, please review the @p2j.persist@ changes.
- 07:13 AM Database Feature #9456: implement SQL Server dialect and helpers
- Ovidiu, 9456b/16097 looks good (I've committed some formatting fixes).
Please commit the dialect NPE fix from #714... - 08:58 AM Base Language Bug #10352: Fix READ-JSON dataset handle method's behaviour
- @FOREIGN-KEY-HIDDEN@ means that fk is calculated automatically (i.e. it knows that the parent's field is used as key ...
- 08:45 AM Base Language Bug #10313: server-sidef file-system must 'mount' user's working dir and look in this path by def...
- Artur Școlnic wrote:
> Is the PROPATH always used in relative path resolving? If so, can't we just add the client wo... - 08:41 AM Base Language Bug #10313: server-sidef file-system must 'mount' user's working dir and look in this path by def...
- Artur Școlnic wrote:
> It's a long shot, but:
> [...]
>
> Effectively sets the user.dir to any path we choose, t... - 08:02 AM Base Language Bug #10313: server-sidef file-system must 'mount' user's working dir and look in this path by def...
- There is TargetData and SourceData, which in the end rely on @StreamFactory.openFileStream@
For icons, there is @T... - 07:49 AM Base Language Bug #10313: server-sidef file-system must 'mount' user's working dir and look in this path by def...
- Artur Școlnic wrote:
> Constantin, do we need to go through all the methods and functions that could take a relative... - 08:03 AM Database Bug #10360: FOR loop WHERE condition evaluation issue
- For now, lets fix it so that FWD doesn't abend - I assume the resolver/lambda? for this argument is not properly exec...
- 07:39 AM Database Bug #10360: FOR loop WHERE condition evaluation issue
- Teodor, please also add a test where @hdl::f3@ is a valid field and @hdl@ is a valid handle.
- 07:26 AM Database Bug #10360: FOR loop WHERE condition evaluation issue
- This one is weird, not in terms that it fails, but how 4GL behaves. In FWD, we evaluate all arguments before executi...
- 07:37 AM Database Bug #6923: inner transaction block reverts too much
- Alexandru Lungu wrote:
> > Thanks, then I have no other concerns for 6923a_h2 . The changes are additive and can be ... - 06:59 AM Database Bug #6923: inner transaction block reverts too much
- Thanks, then I have no other concerns for 6923a_h2 . The changes are additive and can be merged to fwd-h2 trunk (and...
- 06:52 AM Database Bug #6923: inner transaction block reverts too much
- Constantin Asofiei wrote:
> Also, you are missing assigning the multiplex ID to the row, @reclaimPrimaryKey@.
But w... - 06:36 AM Database Bug #6923: inner transaction block reverts too much
- Also, in other words, after the sub-tx was rolled back: the newly created record still survives, and needs its PK to ...
- 06:34 AM Database Bug #6923: inner transaction block reverts too much
- Alexandru Lungu wrote:
> * record is created (claiming a new key)
OK, so this adds the record to the multiplex inde... - 06:10 AM Database Bug #6923: inner transaction block reverts too much
- Alexandru, how is @reclaimPrimaryKey@ supposed to be used?
With 6923a_h2/60, we leave the table indexes in an inco... - 05:55 AM Base Language Bug #10356 (Internal Test): Invalid logical value: should throw error instead of warning
- Please put this into testing.
- 02:49 AM Base Language Bug #10356: Invalid logical value: should throw error instead of warning
- Why is @asMsg@ made @true@ - this will not add the @**@ prefix to the error message.
How does this test work with ... - 05:54 AM Base Language Bug #10277 (Merge Pending): Adaptive Query REPOSITION statement/method error handling improvement
- Please merge now and also update the %Done
- 03:52 AM Database Feature #6457 (Review): finish COPY-LOB support
- I'll review the first pass and we'll work on the codepage problems in a second branch.
07/31/2025
- 02:14 PM Base Language Bug #10313: server-sidef file-system must 'mount' user's working dir and look in this path by def...
- I mean more like setting an icon for a button (for which the location uses PROPATH AFAIK), or using a @COPY-LOB@ (wit...
- 04:00 AM Base Language Bug #10313 (WIP): server-sidef file-system must 'mount' user's working dir and look in this path ...
- Please go ahead and create tests for PROPATH, icons and other features which load from the file-system.
- 03:52 AM Base Language Bug #10313: server-sidef file-system must 'mount' user's working dir and look in this path by def...
- Question: did you test the propath lookup, also? Usually there are a '.' or relative paths there, and this means 'cu...
- 03:49 AM Base Language Bug #10313 (Internal Test): server-sidef file-system must 'mount' user's working dir and look in ...
- I'm OK with the change. Any more testing needed?
- 11:05 AM Base Language Bug #10356: Invalid logical value: should throw error instead of warning
- Teodor, I don't understand the test.
In a simple .p, the behavior is this:...
07/30/2025
- 04:39 AM Base Language Bug #4766: fix CHR and ASC
- Greg, please see the test in #4766-123 - this contradicts what I suggested to use cpinternal for PUT/GET-STRING. Th...
- 03:27 AM Base Language Bug #4766: fix CHR and ASC
- In 4GL, if @cpinternal = cpstream = "ibm850"@, what do you get? I assume still @FF 0@.
You are correct that FWD s...
07/29/2025
- 06:24 AM Base Language Bug #10110 (New): add ClientPrincipal support for FWD OpenClient
- 10110a was merged to trunk rev 16075.
What is left is a more complete support for CLIENT-PRINCIPAL received from O... - 06:22 AM Base Language Bug #10110 (Merge Pending): add ClientPrincipal support for FWD OpenClient
- I'm merging 10110a now, it passed testing. I haven't renamed the classes.
- 06:02 AM Database Bug #10337: Possible memory leak with FastFindCache
- Artur, please archive branches after you merge them - 10337a is still 'active'.
- 04:43 AM Base Language Bug #10313: server-sidef file-system must 'mount' user's working dir and look in this path by def...
- Also, we need to test the impact on customer projects where server-side filesystem is used.
- 04:37 AM Base Language Bug #10313: server-sidef file-system must 'mount' user's working dir and look in this path by def...
- Artur, for 10313a:
* @getWorkingDirectory().value.concat("/").concat(name);@ - does this work on Windows? Don't we n... - 04:41 AM Base Language Bug #10308 (WIP): DYNAMIC TEMP-TABLE issue when using READ-XML before TEMP-TABLE-PREPARE
- Teodor, I don't think this approach is good - we know that READ-XML uses the buffer's (default or explicit) options,...
- 04:39 AM Runtime Infrastructure Bug #8060 (Merge Pending): Admin Console login fails every first time (AdminServerImpl.setTargetL...
- Please merge now.
- 04:34 AM Base Language Bug #10277: Adaptive Query REPOSITION statement/method error handling improvement
- Alexandru, can you take a look, too, please?
- 04:28 AM Base Language Feature #9448 (Internal Test): compatibility test security features
- Go ahead with regression testing.
- 04:27 AM Base Language Bug #10336: Issue on object deletion: java.lang.IllegalStateException
- Teodor, please upload the test with the .p programs.
- 03:25 AM Database Feature #9456: implement SQL Server dialect and helpers
- *Eduard* - there are usages of 'lower' in @udf/sqlserver/udfs.sql@ where it matches with an uppercase text, see:
<pr... - 03:10 AM Base Language Feature #10290 (Merge Pending): Add support for character string literals options
- Conversion testing passed, please merge now.
07/28/2025
- 08:59 AM Base Language Feature #10290: Add support for character string literals options
- Paul Bodale wrote:
> Constantin Asofiei wrote:
> > Paul, 10290a does not compile with Java 8.
>
> I think it's b... - 08:37 AM Base Language Feature #10290: Add support for character string literals options
- Paul, 10290a does not compile with Java 8.
- 07:28 AM Base Language Feature #10290 (Internal Test): Add support for character string literals options
- No, I want to finish converting all apps.
- 04:07 AM Base Language Bug #4766: fix CHR and ASC
- Delia, please work on automating using an approach like this:...
- 03:31 AM Base Language Bug #4766: fix CHR and ASC
- Please compile the file to a .r and run that via "pro -p", not from the procedure editor. It may matter what cpinter...
Also available in: Atom