Bug #10351: ProDataSet READ-XML issue when temp-table node is the same as dataset node - Database - Golden Code Redmine

Bug #10351

ProDataSet READ-XML issue when temp-table node is the same as dataset node

Added by Teodor Gorghe 12 months ago. Updated 11 months ago.

Status:

Test

Priority:

Normal

Assignee:

Teodor Gorghe

Target version:

Start date:

Due date:

% Done:

100%

billable:

vendor_id:

GCD

case_num:

version_reported:

version_resolved:

reviewer:

Ovidiu Maxiniuc

production:

env_name:

topics:

tt3_tt4_no_root_nested.xml (263 Bytes) Teodor Gorghe, 07/31/2025 04:21 AM

tt1_tt2_no_root_nested.xml (263 Bytes) Teodor Gorghe, 07/31/2025 04:21 AM

Related issues

History

#2 Updated by Teodor Gorghe 12 months ago

File tt3_tt4_no_root_nested.xml added
File tt1_tt2_no_root_nested.xml added

On OE 4GL, you can define XML input files, for static and dynamic datasets, with a structure like this:

<?xml version="1.0"?>
<ttName xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
    <ttField1>...</ttField1>
    ...
</ttName>

On FWD, the following tests fails because it treats the root node as a dataset node and expects the child nodes to be temp-table nodes:

ABL Code ABL Code

BLOCK-LEVEL ON ERROR UNDO, THROW.

USING support.test.AssertExt FROM PROPATH.
USING OpenEdge.Core.Assert FROM PROPATH.

CLASS tests.TestDatasetReadXml:
    DEFINE PRIVATE TEMP-TABLE tt1
        FIELD f1 AS INTEGER.

    DEFINE PRIVATE TEMP-TABLE tt2
        FIELD f2 AS INTEGER
        FIELD tt1_id AS RECID.

    DEFINE PRIVATE TEMP-TABLE tt3
        FIELD f1 AS INTEGER.

    DEFINE PRIVATE TEMP-TABLE tt4
        FIELD f2 AS INTEGER
        FIELD tt3_id AS RECID.

    DEFINE PRIVATE VARIABLE ds1 AS HANDLE NO-UNDO.
    DEFINE PRIVATE DATASET ds2 FOR tt3, tt4
        PARENT-ID-RELATION rel1 FOR tt3, tt4 PARENT-ID-FIELD tt3_id.

    @Test.
    METHOD PUBLIC VOID TestReadXmlDynamicDataset():
        DEFINE VARIABLE tt1_recid AS RECID NO-UNDO.
        DEFINE VARIABLE i AS INTEGER NO-UNDO.

        CREATE DATASET ds1.
        ds1:SET-BUFFERS (TEMP-TABLE tt1:HANDLE, TEMP-TABLE tt2:HANDLE).
        ds1:ADD-PARENT-ID-RELATION (BUFFER tt1:HANDLE, BUFFER tt2:HANDLE).

        ds1:READ-XML ("file", "tests/tt1_tt2_no_root_nested.xml", "empty", ?, ?, ?, ?).
        Assert:Equals("", ds1:NAME).

        FIND FIRST tt1 NO-ERROR.

        Assert:IsTrue(AVAILABLE tt1).
        Assert:Equals(1, tt1.f1).
        tt1_recid = RECID(tt1).

        FIND NEXT tt1 NO-ERROR.
        Assert:IsFalse(AVAILABLE tt1).

        i = 1.
        FOR EACH tt2:
            Assert:Equals(tt1_recid, tt2.tt1_id).
            Assert:Equals(i, tt2.f2).
            i = i + 1.
        END.

        FINALLY:
            IF VALID-HANDLE (ds1) THEN
                DELETE OBJECT ds1.    
        END FINALLY.
    END METHOD.

    @Test.
    METHOD PUBLIC VOID TestReadXmlStaticDataset():
        DEFINE VARIABLE tt3_recid AS RECID NO-UNDO.
        DEFINE VARIABLE i AS INTEGER NO-UNDO.

        DATASET ds2:READ-XML ("file", "tests/tt3_tt4_no_root_nested.xml", "empty", ?, ?, ?, ?).
        Assert:Equals("ds2", DATASET ds2:NAME).

        FIND FIRST tt3 NO-ERROR.

        Assert:IsTrue(AVAILABLE tt3).
        Assert:Equals(1, tt3.f1).
        tt3_recid = RECID(tt3).

        FIND NEXT tt3 NO-ERROR.
        Assert:IsFalse(AVAILABLE tt3).

        i = 1.
        FOR EACH tt4:
            Assert:Equals(tt3_recid, tt4.tt3_id).
            Assert:Equals(i, tt4.f2).
            i = i + 1.
        END.
    END METHOD.
END CLASS.

Test logs

╷
├─ JUnit Jupiter ✔
├─ JUnit Vintage ✔
├─ JUnit Platform Suite ✔
└─ FWD Test ✔
   └─ tests.TestDatasetReadXml ✔
      ├─ testReadXmlDynamicDataset ✘ Dataset name '' in namespace '' not found in XML Document. (13514)
      └─ testReadXmlStaticDataset 816055 ms ✘ com.goldencode.p2j.util.DeferredLegacyErrorException

Failures (2):
  FWD Test:tests.TestDatasetReadXml:testReadXmlDynamicDataset
    MethodSource [className = 'com.goldencode.testcases.tests.TestDatasetReadXml', methodName = 'testReadXmlDynamicDataset', methodParameterTypes = '']
    => org.opentest4j.AssertionFailedError: Dataset name '' in namespace '' not found in XML Document. (13514)
       com.goldencode.p2j.oo.lang.SysError.newInstance(SysError.java:151)
       com.goldencode.testcases.tests.TestDatasetReadXml.testReadXmlDynamicDataset(TestDatasetReadXml.java:71)
       com.goldencode.testcases.tests.TestDatasetReadXml.testReadXmlDynamicDataset(TestDatasetReadXml.java:66)
  FWD Test:tests.TestDatasetReadXml:testReadXmlStaticDataset
    MethodSource [className = 'com.goldencode.testcases.tests.TestDatasetReadXml', methodName = 'testReadXmlStaticDataset', methodParameterTypes = '']
    => com.goldencode.p2j.util.DeferredLegacyErrorException

#3 Updated by Teodor Gorghe 12 months ago

Status changed from New to WIP
Assignee set to Teodor Gorghe

Created task branch 10351a.

#4 Updated by Greg Shah 12 months ago

Project changed from Base Language to Database

#5 Updated by Teodor Gorghe 12 months ago

Status changed from WIP to Review
% Done changed from 0 to 100

Committed revision 16080 on task branch 10351a:
- DATASET:READ-XML added support for buffer as root node.

The customer app that I have found this issue uses dynamic ProDataSet object with SET-BUFFER call. I don't have a solution for ProDataSet structure infered READ-XML call.

#6 Updated by Teodor Gorghe 12 months ago

reviewer Constantin Asofiei added

#7 Updated by Teodor Gorghe 12 months ago

Committed revision 16081 on task branch 10351a:
- Added some isRoot = false before break because the next stream node should not be a root node anymore.

#8 Updated by Constantin Asofiei 12 months ago

Teodor, is this related to #10203 ?

#9 Updated by Teodor Gorghe 12 months ago

Constantin Asofiei wrote:

Teodor, is this related to #10203 ?

The testcase that Dennis wrote on #10203 is related with another parsing issue. For that case, I think 4GL implicitly assigns child text node to the only buffer field existent.

This task tells another test case where READ-XML fails. The .xml files attached on #10351-2 shows an example of .xml input file which works on 4GL and the dataset gets populated. On FWD, this fails on trunk rev and I have made this work after 10351a rev 16081.

#10 Updated by Constantin Asofiei 12 months ago

OK, what you found is if the root node does not match the dataset, and is a temp-table (serialized) name, then the root dataset node is skipped.

But I don't understand this part:

                           if (!tableNameMatch && !dataSetNameMatch)
                           {                              // If the current node is the root node
                              // and it does not match with a buffer node, continue to the next XML node.
                              if (isRoot)
                              {
                                 isRoot = false;
                                 break;
                              }

Are you saying that if the root node doesn't match either the dataset or temp-table name, then is skipped?

#11 Updated by Teodor Gorghe 12 months ago

Constantin Asofiei wrote:

OK, what you found is if the root node does not match the dataset, and is a temp-table (serialized) name, then the root dataset node is skipped.

But I don't understand this part:
[...]

Are you saying that if the root node doesn't match either the dataset or temp-table name, then is skipped?

4GL allows you to specify XML input payload with a root node name different than the dataset serialized name (and is also not a temp-table serialized name). If this does not match with a temp-table name, then the data is populated from his node childs.
This condition was necessary because the dataset XML-NODE-NAME can be empty or unknown and I have found this by running some tests.

#12 Updated by Constantin Asofiei 12 months ago

OK, so if you have something like foo/bar/ in the XMl structure, and neither foo or bar match the temp-table, then it will fail?

#13 Updated by Teodor Gorghe 12 months ago

Constantin Asofiei wrote:

OK, so if you have something like foo/bar/ in the XMl structure, and neither foo or bar match the temp-table, then it will fail?

Yes, it will fail on bar node

#14 Updated by Teodor Gorghe 12 months ago

FWD (error message hidden by READ XML invoke, but is the same error as from 4GL):

testReadXmlFooBar 15010 ms ✘ com.goldencode.p2j.util.DeferredLegacyErrorException

OE 4GL:

TestReadXmlFooBar .001 Dataset name 'ds2' in namespace '' not found in XML Document. (13514)

#15 Updated by Teodor Gorghe 12 months ago

reviewer Ovidiu Maxiniuc added
reviewer deleted (~~Constantin Asofiei~~)

Ovidiu, Constantin ran some tests with a P2J build with changes from this branch.
Can you check the changes from this branch and tell to me if there is something that is not right?

#16 Updated by Ovidiu Maxiniuc 12 months ago

I looked at the changes in 10351a. The way I read the lines at 603/606 is that the root node can be anything (including tableNameMatch and dataSetNameMatch) and the XML file processing will continue with inner nodes. Error 13514 will be thrown if one of these cannot be matched, instead.

If this is the expected behaviour (it does not seems logical, but I've seen other strange things in 4GL) and it fixes the original issue, then we should go ahead with testing. I'll let you update the task status and you seem fit.

#17 Updated by Teodor Gorghe 12 months ago

Status changed from Review to Internal Test

#18 Updated by Alexandru Lungu 11 months ago

Teodor, is this ready to be merged?

#19 Updated by Teodor Gorghe 11 months ago

Yes, now is ready to be merged.

#20 Updated by Constantin Asofiei 11 months ago

Status changed from Internal Test to Merge Pending

10351a can be merged after 10360a

#21 Updated by Teodor Gorghe 11 months ago

Status changed from Merge Pending to Test

Branch 10351a was merged to trunk rev 16121 and archived.

#22 Updated by Teodor Gorghe 9 months ago

Related to Bug #10203: XMLs cannot be imported into a dataset without a schema present added

Also available in: Atom PDF

Project

General

Profile

FWD » Core Development » Database

Issues

Custom queries

Bug #10351

ProDataSet READ-XML issue when temp-table node is the same as dataset node

History

#2 Updated by Teodor Gorghe 12 months ago

#3 Updated by Teodor Gorghe 12 months ago

#4 Updated by Greg Shah 12 months ago

#5 Updated by Teodor Gorghe 12 months ago

#6 Updated by Teodor Gorghe 12 months ago

#7 Updated by Teodor Gorghe 12 months ago

#8 Updated by Constantin Asofiei 12 months ago

#9 Updated by Teodor Gorghe 12 months ago

#10 Updated by Constantin Asofiei 12 months ago

#11 Updated by Teodor Gorghe 12 months ago

#12 Updated by Constantin Asofiei 12 months ago

#13 Updated by Teodor Gorghe 12 months ago

#14 Updated by Teodor Gorghe 12 months ago

#15 Updated by Teodor Gorghe 12 months ago

#16 Updated by Ovidiu Maxiniuc 12 months ago

#17 Updated by Teodor Gorghe 12 months ago

#18 Updated by Alexandru Lungu 11 months ago

#19 Updated by Teodor Gorghe 11 months ago

#20 Updated by Constantin Asofiei 11 months ago

#21 Updated by Teodor Gorghe 11 months ago

#22 Updated by Teodor Gorghe 9 months ago