Golden Code Redmine

09/24/2025

05:49 AM Runtime Infrastructure Feature #10451: GUI interaction event logging

Paula Păstrăguș wrote:
> Hynek, thanks for the detailed review!
>
> Quick question: should we log every key inpu... Hynek Cihlar

09/23/2025

04:08 PM Runtime Infrastructure Feature #9687: drop support for Java 8 and Java 11

Tomasz Domin wrote:
> Hynek Cihlar wrote:
> > Code review 9687c. The changes look good. Just please add the history... Hynek Cihlar

01:32 PM Runtime Infrastructure Feature #9687: drop support for Java 8 and Java 11

Code review 9687c. The changes look good. Just please add the history entry. Hynek Cihlar

06:30 AM Runtime Infrastructure Feature #9687: drop support for Java 8 and Java 11

Code review 9687c.
Please write the response directly to a @ByteArrayOutputStream@ and avoid the intermediate stri... Hynek Cihlar

12:57 AM Runtime Infrastructure Feature #9687: drop support for Java 8 and Java 11

Please check whether the upload handler sets the content length. If not, set it. Hynek Cihlar

01:51 PM User Interface Bug #10485 (Internal Test): App freeze due to lack of synchronization

Code review 10485a. The changes look good. Hynek Cihlar

05:56 AM User Interface Bug #10485: App freeze due to lack of synchronization

Paula Păstrăguș wrote:
> Okay, so I can take the status code (per https://datatracker.ietf.org/doc/html/rfc6455#sect... Hynek Cihlar

11:16 AM Runtime Infrastructure Feature #10451: GUI interaction event logging

Paula, what I meant was using @CentralLogger@ but through a dedicated logger instance. Normally, we have one instance... Hynek Cihlar

06:47 AM User Interface Bug #9738 (Internal Test): Infinite loop/memory leak caused by ENTRY trigger on current-window

Code review 9738a. The changes look good. Surprising we didn't notice this earlier. Please go ahead and regression test. Hynek Cihlar

09/22/2025

01:02 PM Runtime Infrastructure Feature #10451: GUI interaction event logging

Code review 10451a.
Instead of outputting custom message for evety distinct key code, just make the output generic... Hynek Cihlar

09:45 AM User Interface Bug #10485: App freeze due to lack of synchronization

Paula Păstrăguș wrote:
> I think @Test failed@ on its own is enough, no need to mention @connection error@, since th... Hynek Cihlar

09:08 AM User Interface Bug #10485: App freeze due to lack of synchronization

Hynek Cihlar wrote:
> Paula Păstrăguș wrote:
> > Hynek Cihlar wrote:
> > > The connection error is output to the t... Hynek Cihlar

09:07 AM User Interface Bug #10485: App freeze due to lack of synchronization

Paula Păstrăguș wrote:
> Hynek Cihlar wrote:
> > The connection error is output to the test results from the websoc... Hynek Cihlar

08:37 AM User Interface Bug #10485: App freeze due to lack of synchronization

Code review.
When logging the websocket close/error event, do not log just the @reason@ property, but the whole ob... Hynek Cihlar

09/19/2025

02:42 PM User Interface Bug #10485: App freeze due to lack of synchronization

Paula Păstrăguș wrote:
> I’d like your input: should we leave the behavior as it is, or also display the @Test abort... Hynek Cihlar

03:13 AM Runtime Infrastructure Feature #9687: drop support for Java 8 and Java 11

Tomasz Domin wrote:
> There is one new small change in the branch compared to trunk which is related with MultiPart ... Hynek Cihlar

09/18/2025

01:13 PM User Interface Bug #10485: App freeze due to lack of synchronization

Paula Păstrăguș wrote:
> Addressed points 2 and 3 in rev *16138*.
>
> I double checked the first point, the sock... Hynek Cihlar

09/17/2025

03:40 PM User Interface Bug #10593: SPREADSHEET: Keikai backend sends huge amount of data to the frontend

This issue was first identified in #10210. Keikai transmits an excessive amount of data to the frontend, even for min... Hynek Cihlar

03:37 PM User Interface Bug #10593 (New): SPREADSHEET: Keikai backend sends huge amount of data to the frontend

Hynek Cihlar

09/16/2025

02:46 PM User Interface Bug #10485 (WIP): App freeze due to lack of synchronization

Code review 10485a.
Overall the changes look fine. Just a few points.
* The socket should be closed after the t... Hynek Cihlar

09/11/2025

06:30 AM Runtime Infrastructure Feature #10451: GUI interaction event logging

Paula Păstrăguș wrote:
> It is caused because we're posting @COM-EVENTS@ with a *null source*:
>
> [...]
>
> T... Hynek Cihlar

09/10/2025

08:09 AM Base Language Bug #9572: ArrayIndexOutOfBoundsException and wrong newline handling in RedirectedTerminal.addCha...

Vladimir Tsichevski wrote:
> Hynek Cihlar wrote:
> > Vladimir Tsichevski wrote:
> > > Hynek Cihlar wrote:
> > > >... Hynek Cihlar

07:16 AM User Interface Bug #10323 (Closed): FILL-IN in GUI Mode: Issues with Displaying Empty Screen Value

Hynek Cihlar

04:56 AM User Interface Bug #10323 (Merge Pending): FILL-IN in GUI Mode: Issues with Displaying Empty Screen Value

Please merge 10323a to trunk. Hynek Cihlar

07:16 AM User Interface Bug #10512 (Closed): REGRESSION: In ChUI, all RADIO-SET items are positioned at the same location

Hynek Cihlar

04:57 AM User Interface Bug #10512 (Merge Pending): REGRESSION: In ChUI, all RADIO-SET items are positioned at the same l...

Please merge 10512a after 10323a. Hynek Cihlar

04:54 AM Runtime Infrastructure Feature #10451: GUI interaction event logging

Paula Păstrăguș wrote:
> I attached the patch. (reverted window manager, event manager, logs for show / hide are now... Hynek Cihlar

09/08/2025

11:03 AM User Interface Bug #10485: App freeze due to lack of synchronization

Sergey raises a valid point. Adding synchronization logic to cover up a flawed design is not a good approach.
The ... Hynek Cihlar

09:36 AM User Interface Bug #10485: App freeze due to lack of synchronization

Paula Păstrăguș wrote:
> Committed as rev *16136*.
>
> Please review.
The changes look good to me. Sergey, wha... Hynek Cihlar

07:08 AM User Interface Bug #10485: App freeze due to lack of synchronization

Paula Păstrăguș wrote:
> I’ve attached a patch that switches the implementation to use a @ReentrantLock@. If this ap... Hynek Cihlar

09:29 AM Base Language Bug #9572: ArrayIndexOutOfBoundsException and wrong newline handling in RedirectedTerminal.addCha...

Vladimir Tsichevski wrote:
> Hynek Cihlar wrote:
> > Code review 9572a. Please start regression testing. I suppose ... Hynek Cihlar

07:16 AM Runtime Infrastructure Feature #10451: GUI interaction event logging

Paula Păstrăguș wrote:
> Hynek, if we add the logging directly in ThinClient, the web_gui log will quickly fill up w... Hynek Cihlar

09/05/2025

04:03 AM User Interface Bug #9916 (Closed): FILL-IN: date format: incorrect condition for triggering normalization of thi...

Hynek Cihlar

09/04/2025

06:29 AM User Interface Bug #10323: FILL-IN in GUI Mode: Issues with Displaying Empty Screen Value

ChUI tests passed. Hynek Cihlar

02:36 AM User Interface Bug #10512: REGRESSION: In ChUI, all RADIO-SET items are positioned at the same location

ChUI regression tests passed. Vladimir, do you plan some more regression testing? Hynek Cihlar

09/03/2025

05:16 PM User Interface Bug #10323: FILL-IN in GUI Mode: Issues with Displaying Empty Screen Value

Vladimir Tsichevski wrote:
> Hynek Cihlar wrote:
> > Vladimir Tsichevski wrote:
> > > Hynek Cihlar wrote:
> > > >... Hynek Cihlar

03:52 AM User Interface Bug #10512 (Internal Test): REGRESSION: In ChUI, all RADIO-SET items are positioned at the same l...

Code review 10512a. The changes are good. I'm running ChUI regression tests. Should the issue be set to 100% done? Hynek Cihlar

09/02/2025

03:20 PM User Interface Bug #9916 (Test): FILL-IN: date format: incorrect condition for triggering normalization of third...

Are there any related customer test scenarios? Should the issue be moved to Test state? Hynek Cihlar

01:57 PM User Interface Bug #9916 (Merge Pending): FILL-IN: date format: incorrect condition for triggering normalization...

Vladimir Tsichevski wrote:
> I rebased the 9916a to trunk rev. 16141. Can we merge now?
Please 9916a merge to trunk. Hynek Cihlar

02:02 PM Base Language Bug #9572: ArrayIndexOutOfBoundsException and wrong newline handling in RedirectedTerminal.addCha...

Hynek Cihlar wrote:
> Code review 9572a. Please start regression testing. I suppose I will run the ChUI regression t... Hynek Cihlar

01:53 PM User Interface Bug #10512: REGRESSION: In ChUI, all RADIO-SET items are positioned at the same location

Vladimir Tsichevski wrote:
> Hynek, this is your code. What potential issues might arise if we remove this code?
... Hynek Cihlar

09/01/2025

12:22 PM Runtime Infrastructure Feature #10451: GUI interaction event logging

Paula Păstrăguș wrote:
> Hynek Cihlar wrote:
> > For the key events logging I think it would make it more useful if... Hynek Cihlar

12:19 PM Runtime Infrastructure Feature #10451: GUI interaction event logging

Paula Păstrăguș wrote:
> Would it make more sense to handle this on show/hide and log based on the window’s visibili... Hynek Cihlar

05:55 AM Runtime Infrastructure Feature #10451 (WIP): GUI interaction event logging

Code review 10451a.
The "window closed" log output is a bit misleading. It is logged in the @remove@ method of @W... Hynek Cihlar

04:08 AM Base Language Bug #9572 (Internal Test): ArrayIndexOutOfBoundsException and wrong newline handling in Redirecte...

Code review 9572a. Please start regression testing. I suppose I will run the ChUI regression tests. Hynek Cihlar

04:05 AM Base Language Bug #9572: ArrayIndexOutOfBoundsException and wrong newline handling in RedirectedTerminal.addCha...

Vladimir Tsichevski wrote:
> Hynek Cihlar wrote:
> > @ScreenBitmap@ size will get out of sync with the size of the ... Hynek Cihlar

08/29/2025

01:47 AM User Interface Bug #10485: App freeze due to lack of synchronization

Paula Păstrăguș wrote:
> Hynek Cihlar wrote:
> > Code review 10485a.
> >
> > Please remove @PushMessagesWorker.s... Hynek Cihlar

08/28/2025

07:46 AM User Interface Bug #10485 (WIP): App freeze due to lack of synchronization

Code review 10485a.
Please remove @PushMessagesWorker.session@ and the related methods.... Hynek Cihlar

08/27/2025

06:02 AM Runtime Infrastructure Feature #10451: GUI interaction event logging

Paula, I like the idea. Two suggestions.
1. I think it would be even better to extend this to all widgets. I.e. p... Hynek Cihlar

08/26/2025

02:25 PM Base Language Bug #9572 (WIP): ArrayIndexOutOfBoundsException and wrong newline handling in RedirectedTerminal....

Code review 9572a.... Hynek Cihlar