Project

General

Profile

Bug #10512

REGRESSION: In ChUI, all RADIO-SET items are positioned at the same location

Added by Vladimir Tsichevski about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Vladimir Tsichevski
Target version:
-
Start date:
Due date:
% Done:

100%

billable:
No
vendor_id:
GCD
case_num:
version_reported:
15774
version_resolved:
16158
reviewer:
Hynek Cihlar
production:
No
env_name:
topics:

Related issues

Related to User Interface - Bug #10521: RADIO-SET Rendering in ChUI Issues Test

History

#3 Updated by Vladimir Tsichevski about 1 year ago

  • Status changed from New to WIP

In ChUI, all items are rendered at the same screen location. This regression stems from the merge of revision 8933a into trunk revision 15774.
This issue was initially reported in #10446-17.

#4 Updated by Greg Shah about 1 year ago

Please update Open Regressions in FWD v4 with an entry about the regression.

#5 Updated by Vladimir Tsichevski about 1 year ago

The issue occurs when this condition is satisfied, causing the loop to exit prematurely, which prevents the positioning of the remaining buttons.

         // TODO: In GUI the button sizes are not calculated correctly and so it may
         //       happen that the button does not fit by a pixel or two. This is a 
         //       temporary fix to let the buttons be displayed but the correct
         //       solution will be to get the size calculation right.
         if (isChui && size > maxSize)
         {
            break;
         }

Hynek, this is your code. What potential issues might arise if we remove this code?

#6 Updated by Vladimir Tsichevski about 1 year ago

Greg Shah wrote:

Please update Open Regressions in FWD v4 with an entry about the regression.

Done.

#7 Updated by Vladimir Tsichevski about 1 year ago

  • Status changed from WIP to Review

Regression resolved in branch 10512a revision 16145. The fix involved removing the code block referenced in #10512-5.
Hynek, please review.

I identified two additional minor issues (potentially related) in ChUI following the application of this fix:

When the selection is shifted to the left item:
  1. the inverted caret appears to the right of the selected item
  2. the RADIO-SET width is one character wider than in OE

#8 Updated by Vladimir Tsichevski about 1 year ago

Vladimir Tsichevski wrote:

When the selection is shifted to the left item:
  1. the inverted caret appears to the right of the selected item

Same issue is observed in a vertical RADIO-SET.

#9 Updated by Hynek Cihlar about 1 year ago

Vladimir Tsichevski wrote:

Hynek, this is your code. What potential issues might arise if we remove this code?

Actually the condition size > maxSize was added way before my change. I only excluded GUI. Also I'm not aware of any related test cases. If you think it should be removed altogether then remove it and we will regression test the change.

#10 Updated by Vladimir Tsichevski about 1 year ago

Hynek Cihlar wrote:

Vladimir Tsichevski wrote:

Hynek, this is your code. What potential issues might arise if we remove this code?

Actually the condition size > maxSize was added way before my change. I only excluded GUI. Also I'm not aware of any related test cases. If you think it should be removed altogether then remove it and we will regression test the change.

So be it.

#11 Updated by Hynek Cihlar about 1 year ago

  • Status changed from Review to Internal Test

Code review 10512a. The changes are good. I'm running ChUI regression tests. Should the issue be set to 100% done?

#12 Updated by Vladimir Tsichevski about 1 year ago

  • % Done changed from 0 to 100

Hynek Cihlar wrote:

Code review 10512a. The changes are good. I'm running ChUI regression tests. Should the issue be set to 100% done?

Yes

#13 Updated by Hynek Cihlar about 1 year ago

ChUI regression tests passed. Vladimir, do you plan some more regression testing?

#14 Updated by Vladimir Tsichevski about 1 year ago

Hynek Cihlar wrote:

ChUI regression tests passed. Vladimir, do you plan some more regression testing?

No. I will register another task for #10512-7.

#15 Updated by Vladimir Tsichevski about 1 year ago

  • Related to Bug #10521: RADIO-SET Rendering in ChUI Issues added

#16 Updated by Vladimir Tsichevski about 1 year ago

Vladimir Tsichevski wrote:

I will register another task for #10512-7.

Done. The issue #10521.

I think, we can merge now.

#17 Updated by Hynek Cihlar about 1 year ago

  • Status changed from Internal Test to Merge Pending

Please merge 10512a after 10323a.

#18 Updated by Vladimir Tsichevski about 1 year ago

  • version_resolved set to 16158

Hynek Cihlar wrote:

Please merge 10512a after 10323a.

Done at rev. 16158.

#19 Updated by Hynek Cihlar about 1 year ago

  • Status changed from Merge Pending to Closed

Also available in: Atom PDF