Golden Code Redmine

12/23/2025

04:17 PM User Interface Bug #10100: Setting the SORT Attribute in a Realized Widget

Vladimir Tsichevski wrote:
> Although the widgets implement a common interface, placing the field-referencing logic ... Hynek Cihlar

11:05 AM User Interface Bug #10100 (WIP): Setting the SORT Attribute in a Realized Widget

Code review. Just one more minor point. Please move @sort@ out from the config class. The config classes are a kind o... Hynek Cihlar

10:57 AM User Interface Bug #11056: SHIFT + TAB doesn't work on Swing ChUI

Is this issue limited only to Shift+Tab?
Sergey, also please review. Hynek Cihlar

12/22/2025

12:21 PM User Interface Bug #10100 (WIP): Setting the SORT Attribute in a Realized Widget

Code review 10100a. The changes look good, just please deduplicate the sorting logic. Hynek Cihlar

10:42 AM User Interface Bug #10915: ugly dialogs

Sergey Ivanovskiy wrote:
> This dialog has no title by the previous design. If you proposed to add title to this dia... Hynek Cihlar

10:22 AM User Interface Bug #10915: ugly dialogs

Sergey Ivanovskiy wrote:
> The server unavailable dialog has no title by its construction. Please see the code.
S... Hynek Cihlar

09:47 AM User Interface Bug #10915: ugly dialogs

Sergey Ivanovskiy wrote:
> Could you check this video, please? No view was recorded.
Try a different player. Hynek Cihlar

09:46 AM User Interface Bug #10915: ugly dialogs

Sergey Ivanovskiy wrote:
> It is enough to do a print screen. How did you emulate restore connection dialog?
A sc... Hynek Cihlar

09:08 AM User Interface Bug #10915: ugly dialogs

Please see the atttached screen cast. Hynek Cihlar

06:58 AM User Interface Bug #10915: ugly dialogs

Code review 10915a. The changes look good I just checked in a copyright year update and a couple of formatting issues... Hynek Cihlar

04:28 AM User Interface Bug #10521 (Merge Pending): RADIO-SET Rendering in ChUI Issues

Please merge 10521a to trunk. Hynek Cihlar

12/18/2025

01:04 PM Conversion Tools Feature #10190: Prototype the changes to the build to add ANTLR v4

Paula, @ant-antlr4All@ should be protected with @run-gradle-run@. Try to add @unless="run-gradle-run"@ to it. Hynek Cihlar

12/17/2025

09:21 AM Runtime Infrastructure Bug #10858: Replace capturing with non-capturing lambdas in getters and setters

Hynek Cihlar wrote:
> Razvan-Nicolae Chichirau wrote:
> > Hynek Cihlar wrote:
> > > Code review.
> > >
> > > @B... Hynek Cihlar

09:13 AM Runtime Infrastructure Bug #10858: Replace capturing with non-capturing lambdas in getters and setters

Razvan-Nicolae Chichirau wrote:
> Hynek Cihlar wrote:
> > Code review.
> >
> > @BrowseColumnWidget.getLabelFgCol... Hynek Cihlar

08:48 AM Runtime Infrastructure Bug #10858 (WIP): Replace capturing with non-capturing lambdas in getters and setters

Code review.
@BrowseColumnWidget.getLabelFgColor()@:
It reads @labelBgColor@ via @BrowseColumnConfig::getLabelBgC... Hynek Cihlar

07:00 AM Conversion Tools Feature #10190: Prototype the changes to the build to add ANTLR v4

Paula Păstrăguș wrote:
> I completed a full conversion of a large GUI application, and it passed successfully. I als... Hynek Cihlar

05:46 AM User Interface Bug #10521 (Internal Test): RADIO-SET Rendering in ChUI Issues

Razvan-Nicolae Chichirau wrote:
> *Hynek*: Please review 10521a/rev. 16317.
Code review. The changes look good.
... Hynek Cihlar

03:39 AM User Interface Bug #10100: Setting the SORT Attribute in a Realized Widget

Razvan, try the following.
Sort on the client during realization. After you sort mark the sorted items field on th... Hynek Cihlar

02:51 AM User Interface Bug #10423: Scrollbar is clipped by frame after a virtual width assignment

Hynek Cihlar wrote:
> Hynek Cihlar wrote:
> > Should the assignment be done only when @SCA.isSuspended()@?
>
> O... Hynek Cihlar

12/09/2025

04:52 AM Runtime Infrastructure Feature #9687: drop support for Java 8 and Java 11

Tomasz, I don't see the changes in the branche. Please check if they are pushed. Hynek Cihlar

12/08/2025

05:35 AM Runtime Infrastructure Feature #9687: drop support for Java 8 and Java 11

Tomasz Domin wrote:
> Hynek Cihlar wrote:
> > Tomasz Domin wrote:
> > > But why we need the configuration elements... Hynek Cihlar

04:57 AM Runtime Infrastructure Feature #9687: drop support for Java 8 and Java 11

Tomasz Domin wrote:
> But why we need the configuration elements to be exactly like provided ? Why not using default... Hynek Cihlar

12/05/2025

12:31 PM Runtime Infrastructure Feature #9687: drop support for Java 8 and Java 11

Tomasz Domin wrote:
> Hynek (Constantin ?)
> I'd like to standardize configurations used by @GenericWebServer.initi... Hynek Cihlar

12/03/2025

05:52 AM User Interface Bug #10693 (Merge Pending): Incorrect z-order and focus for new Stack trace dialog

Please merge 10693a after 10085a. Hynek Cihlar

12/02/2025

11:36 AM Base Language Bug #9956 (Closed): Client crashes in DATE function

Hynek Cihlar

11:14 AM User Interface Bug #10693: Incorrect z-order and focus for new Stack trace dialog

Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > Eugenie Lyzenko wrote:
> > > Hynek Cihlar wrote:
> > > > This wi... Hynek Cihlar

10:53 AM User Interface Bug #10693: Incorrect z-order and focus for new Stack trace dialog

Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > This will require ChUI regression testing.
>
> We can do @ChUI@... Hynek Cihlar

09:17 AM User Interface Bug #10693 (Internal Test): Incorrect z-order and focus for new Stack trace dialog

This will require ChUI regression testing. Hynek Cihlar

07:35 AM Runtime Infrastructure Feature #9687: drop support for Java 8 and Java 11

Tomasz Domin wrote:
> Greg - its hard to judge if its FWD problem. It was included in FWD distribution, now it is no... Hynek Cihlar

11/27/2025

10:22 AM User Interface Bug #10760: Mouse events should not be dispatched while a combo box drop-down is open.

Delia, please note the javadoc for @updateHeaders@ contains unexpected word "process". Hynek Cihlar

09:16 AM User Interface Bug #10693: Incorrect z-order and focus for new Stack trace dialog

Code review 10693a.
The changes look fine. Just a question, was the check @isStackTraceActive@ in @AlertBoxImpl@ a... Hynek Cihlar

11/26/2025

11:07 AM Runtime Infrastructure Bug #10858: Replace capturing with non-capturing lambdas in getters and setters

Alexandru Lungu wrote:
> It may have been used in the base. I am afraid of having a decisive answer as I am not the ... Hynek Cihlar

07:47 AM User Interface Bug #10760 (Internal Test): Mouse events should not be dispatched while a combo box drop-down is ...

Code review 10760a. The changes look good. Please go ahead with regression testing. Hynek Cihlar

11/25/2025

10:57 AM User Interface Bug #10760: Mouse events should not be dispatched while a combo box drop-down is open.

Delia Mitric wrote:
> I didn't found any case where clicking interacts with the target widget *while* the drop-down ... Hynek Cihlar

06:45 AM User Interface Bug #10760: Mouse events should not be dispatched while a combo box drop-down is open.

Delia Mitric wrote:
> During testing the web application, I've found another case which should be treated:
> * whil... Hynek Cihlar

07:07 AM User Interface Bug #10915: ugly dialogs

Sergey Ivanovskiy wrote:
> I did not defend this implementation @p2j.ModalDialog@ but I need some time to replace th... Hynek Cihlar

06:42 AM User Interface Bug #10915: ugly dialogs

Sergey Ivanovskiy wrote:
> The third argument is that @p2j.ModalDialog@ can have any styles but styles or templates ... Hynek Cihlar

06:38 AM User Interface Bug #10915: ugly dialogs

Sergey Ivanovskiy wrote:
> Hynek, why did you call this dialog reconnect?
Sorry, I misread the actual dialog typ... Hynek Cihlar

05:20 AM User Interface Bug #10915: ugly dialogs

Sergey Ivanovskiy wrote:
> If this task is to make auto height, then these changes are done. I recalled that text wi... Hynek Cihlar

04:20 AM User Interface Bug #10915: ugly dialogs

Sergey Ivanovskiy wrote:
> The logic implemented in @chooseFiles = function(direct, uploadId, title, multiple, uploa... Hynek Cihlar

03:50 AM User Interface Bug #10915: ugly dialogs

Sergey Ivanovskiy wrote:
> Yes, dojo dialogs should not be the issue but there is no your review in this task #5487.... Hynek Cihlar

03:06 AM User Interface Bug #10915: ugly dialogs

Sergey Ivanovskiy wrote:
> I could not find an exact task where the obstacles to use dojo dialog was discussed. From... Hynek Cihlar

11/24/2025

11:39 AM User Interface Bug #10915: ugly dialogs

Sergey Ivanovskiy wrote:
> The styles can be used to add border and other elements if there are needed. So it needs ... Hynek Cihlar

11:38 AM User Interface Bug #10915: ugly dialogs

Sergey Ivanovskiy wrote:
> Hynek, it is not used in the web client but only in @p2j.perf_tests.js@ although I did no... Hynek Cihlar

11:16 AM User Interface Bug #10915: ugly dialogs

Sergey Ivanovskiy wrote:
> I can perform only constructive requirements dynamic height and so on.
Don't worry, I ... Hynek Cihlar

11:02 AM User Interface Bug #10915: ugly dialogs

The changes look fine, but the dialog is still pretty ugly :-). Why don't we use a Dojo dialog here? We already use i... Hynek Cihlar

11:09 AM Testing Support #6863: implement CI/CD servers and the rules for each set of tests

Roger Borrello wrote:
> A basic question... do we generate the pipeline language via script that will then be fed to... Hynek Cihlar

11:06 AM Testing Support #6863: implement CI/CD servers and the rules for each set of tests

JSON it is then. Hynek Cihlar

04:59 AM User Interface Bug #10924: drawFillInBorder hover is always false

+Eugenie Hynek Cihlar

04:26 AM User Interface Bug #10910: tree control arrow keys don't work

Șerban Bursuc wrote:
> In #10273 we discovered a bug that put the focus on a text widget when tab cycling which was ... Hynek Cihlar

04:07 AM User Interface Bug #10760 (Internal Test): Mouse events should not be dispatched while a combo box drop-down is ...

Code review 10760a. The changes look good, please go ahead with regression testing. Hynek Cihlar