FWD » Core Development » Conversion Tools

Created task branch 10185a.

Committed revision 15992 on task branch 10185a:
- Fixed subscript wrapper on new TableParameter()

• DATASET-HANDLEDATASET-HANDLE

  ABL:
  

      @Test.
      method public void AddRecordExtent():
          define variable dext as handle no-undo extent 1.
          run dsAsOutput in hproc( output dataset-handle dext[1] by-value, input 2, output dsReturnId, output ttCustomerItemsReturned ) no-error.
          support.test.AssertExt:NotErrorNotWarning().
          run support/temptable/help/get_tt_num_rows.p( table-handle ttCustomer by-reference , ?, output ttCustomerItems ).
  
          Assert:IsTrue(dsReturnId <> dsMaster:unique-id).
          Assert:Equals(1, ttCustomerItems).
          Assert:Equals(1, ttCustomerItemsReturned).
      end method.
  

  Converted code:
  

     @LegacySignature(type = Type.METHOD, name = "AddRecordExtent")
     @Test(order = 2)
     public void addRecordExtent()
     {
        handle[] dext = TypeFactory.handleExtent(1);
  
        internalProcedure(TestOutputDynamicDsInDynamicProc.class, this, "AddRecordExtent", new Block((Body) () -> 
        {
           silent(() -> RUN_CALL_SITE_5.clone().setInHandle(hproc).run(new DataSetParameter(subscript(dext, 1), ParameterOption.BY_VALUE), new integer(2), dsReturnId, ttCustomerItemsReturned));
           com.goldencode.testcases.support.test.AssertExt.notErrorNotWarning();
           RUN_CALL_SITE_6.clone().run(new TableParameter(ttCustomer, ParameterOption.BY_REFERENCE), new unknown(), ttCustomerItems);
           Assert.isTrue(isNotEqual(dsReturnId, dsMaster.unwrapUniqueID().getUniqueID()));
           Assert.legacyEquals(new integer(1), ttCustomerItems);
           Assert.legacyEquals(new integer(1), ttCustomerItemsReturned);
        }));
     }
  

• Handle Array cls var/property/static propertyHandle Array cls var/property/static property

  ABL:
  

      @TEST.
      METHOD PUBLIC VOID TestLocalArrayHandle():
          DEFINE VARIABLE hext AS HANDLE NO-UNDO EXTENT 1.
          hext[1] = TEMP-TABLE ttTest:HANDLE.
          RUN noopOutTable IN hproc ( OUTPUT TABLE-HANDLE hext[1] ) NO-ERROR.
          AssertExt:NotErrorNotWarning().
      END METHOD.
  
      @TEST.
      METHOD PUBLIC VOID TestPropertyArrayHandle():
          hext_instance[1] = TEMP-TABLE ttTest:HANDLE.
          RUN noopOutTable IN hproc ( OUTPUT TABLE-HANDLE hext_instance[1] ) NO-ERROR.
          AssertExt:NotErrorNotWarning().
      END METHOD.
  
      @TEST.
      METHOD PUBLIC VOID TestStaticPropertyArrayHandle():
          hext_static[1] = TEMP-TABLE ttTest:HANDLE.
          RUN noopOutTable IN hproc ( OUTPUT TABLE-HANDLE hext_static[1] ) NO-ERROR.
          AssertExt:NotErrorNotWarning().
      END METHOD.
  
      @TEST.
      METHOD PUBLIC VOID TestGlobalArrayHandle():
          hext_global[1] = TEMP-TABLE ttTest:HANDLE.
          RUN noopOutTable IN hproc ( OUTPUT TABLE-HANDLE hext_global[1] ) NO-ERROR.
          AssertExt:NotErrorNotWarning().
      END METHOD.
  

  
  Converted code:
  

     @LegacySignature(type = Type.METHOD, name = "TestLocalArrayHandle")
     @Test(order = 1)
     public void testLocalArrayHandle()
     {
        handle[] hext = TypeFactory.handleExtent(1);
  
        internalProcedure(TestHandleArray.class, this, "TestLocalArrayHandle", new Block((Body) () -> 
        {
           assignSingle(hext, 1, tempTable(tttest));
           silent(() -> RUN_CALL_SITE_2.clone().setInHandle(hproc).run(new TableParameter(subscript(hext, 1))));
           AssertExt.notErrorNotWarning();
        }));
     }
  
     @LegacySignature(type = Type.METHOD, name = "TestPropertyArrayHandle")
     @Test(order = 2)
     public void testPropertyArrayHandle()
     {
        internalProcedure(TestHandleArray.class, this, "TestPropertyArrayHandle", new Block((Body) () -> 
        {
           setHextInstance(new handle(tempTable(tttest)), new integer(1));
           silent(() -> RUN_CALL_SITE_3.clone().setInHandle(hproc).run(new TableParameter(new HandlePropertyRef(ObjectOps.thisObject(), "hext_instance", 1))));
           AssertExt.notErrorNotWarning();
        }));
     }
  
     @LegacySignature(type = Type.METHOD, name = "TestStaticPropertyArrayHandle")
     @Test(order = 3)
     public void testStaticPropertyArrayHandle()
     {
        internalProcedure(TestHandleArray.class, this, "TestStaticPropertyArrayHandle", new Block((Body) () -> 
        {
           setHextStatic(new handle(tempTable(tttest)), new integer(1));
           silent(() -> RUN_CALL_SITE_4.clone().setInHandle(hproc).run(new TableParameter(new HandlePropertyRef("tests.table.parameter.output.TestHandleArray", "hext_static", 1))));
           AssertExt.notErrorNotWarning();
        }));
     }
  
     @LegacySignature(type = Type.METHOD, name = "TestGlobalArrayHandle")
     @Test(order = 4)
     public void testGlobalArrayHandle()
     {
        internalProcedure(TestHandleArray.class, this, "TestGlobalArrayHandle", new Block((Body) () -> 
        {
           assignSingle(hextGlobal, 1, tempTable(tttest));
           silent(() -> RUN_CALL_SITE_5.clone().setInHandle(hproc).run(new TableParameter(subscript(hextGlobal, 1))));
           AssertExt.notErrorNotWarning();
        }));
     }
  

I don't notice any problem. The application compiles and the tests seems to work.

On FWD, HAS-LOBS attribute is supported?
This is the cause of the second conversion problem on ADE.
Unsupported method or attribute KW_HAS_LOBS.

LogLog

    [javac] /home/tg/projects/radius/src/com/eps/radius/possenet/src/adm2/Dataquery.java:6474: error: no suitable method found for not(handle)
    [javac]          if (_and(and(hRowObject.isValid(), () -> not(hRowObject)), () -> isEqual(indexOf(cDataColumns, "."), 0)))
    [javac]                                                   ^
    [javac]     method logical.not(logical) is not applicable
    [javac]       (argument mismatch; handle cannot be converted to logical)
    [javac]     method logical.not(boolean) is not applicable
    [javac]       (argument mismatch; handle cannot be converted to boolean)

There is a test tests.buffer.attributes.TestHasLobs.cls, which has conversion issues.

Committed revision 15995 on task branch 10185a:
- Added a partial implementation of WIDGET:UNIQUE-MATCH.
- Added some ADD-LIKE-COLUMN method overloads for fixing compilation issues on adm2/browser.p
- Added a setWidgetId method overload on using int64 id type.

Committed revision 15996 on task branch 10185a:
- Fixed compilation issues on adm2/b2b.p (the fix was suggested by Constantin).

From this stage, it seems that all .p files from adm2 gets converted and running.

Conversion testing passed. Please merge 10185a after 9550a.

Branch 10185a was merged to trunk rev 16016 and archived.