Project

General

Profile

Activity

From 05/22/2025 to 06/20/2025

06/20/2025

02:12 PM Feature #4076: remove empty triggers during conversion
OK. I agree. Ovidiu Maxiniuc
07:49 AM Feature #4076: remove empty triggers during conversion
Ovidiu Maxiniuc wrote:
> After some thoughts, I think we can drop the empty triggers. If the 4GL programmer +really+...
Greg Shah
06:10 AM Feature #4076: remove empty triggers during conversion
After some thoughts, I think we can drop the empty triggers. If the 4GL programmer +really+ wants to disable a normal... Ovidiu Maxiniuc
04:59 AM Feature #4076: remove empty triggers during conversion
The dangerous case here is when there are more than one trigger that exists with the same filename (and operating on ... Greg Shah
11:00 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Start here and we will see where we move it. Greg Shah
10:52 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Where will this documentation be? In this issue or on a different page?
I will look into which @ant@ commands are im...
Stefan Vieru
08:44 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Since we must provide guidance to customers on this shift, it is important that we prepare documentation and examples... Greg Shah
08:33 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Greg Shah wrote:
> But don't we need to change the project-level @build.xml@ to process things like @clean@ in a dif...
Stefan Vieru
08:26 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
But don't we need to change the project-level @build.xml@ to process things like @clean@ in a different location? Greg Shah
08:04 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
From what I remember no, in @p2j.cfg@ the cvtpath can be configured, but by default it has @cvt@.
Stefan Vieru
07:46 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Please remind me: is there any requirement for scripting or configuration changes in the project cfg? Greg Shah
04:09 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Greg, all regression testing passed. 5586a can be merged. Dănuț Filimon
07:16 AM Bug #10185: ADE conversion and runtime
When passing a value from extent to a procedure, with OUTPUT TEMP-HANDLE, on compilation we have this issue:... Teodor Gorghe
07:02 AM Bug #10185 (Test): ADE conversion and runtime
Teodor Gorghe

06/19/2025

05:58 AM Bug #9863: Fileset eXclude broken on native Windows
I added a comment in *9863a/15984*. Dănuț Filimon
05:37 AM Bug #9863 (Internal Test): Fileset eXclude broken on native Windows
> > It handles the @!filter.endsWith("/")@ case but don't we also need to handle the @filter.endsWith("/")@ case?
> ...
Greg Shah
04:34 AM Bug #9863: Fileset eXclude broken on native Windows
I committed *9863a/15983*. Moved normalizeFilePath() to Utils, removed the unnecessary endsWith() call. Dănuț Filimon
02:00 AM Bug #9863: Fileset eXclude broken on native Windows
Greg Shah wrote:
> Code Review Task Branch 9863a Revisions 15980 through 15982
>
> The changes are good.
>
> 1...
Dănuț Filimon

06/18/2025

03:27 PM Bug #9863: Fileset eXclude broken on native Windows
Code Review Task Branch 9863a Revisions 15980 through 15982
The changes are good.
1. I wonder if @FLF.normalize...
Greg Shah
12:59 PM Bug #9917 (Internal Test): Fileset not ignoring case
OK, good. Greg Shah
09:18 AM Bug #9917: Fileset not ignoring case
Greg Shah wrote:
> Code Review Task Branch 9917a Revisions 15969 through 15971
>
> Overall, the changes seem reas...
Dănuț Filimon
08:38 AM Bug #9917: Fileset not ignoring case
Code Review Task Branch 9917a Revisions 15969 through 15971
Overall, the changes seem reasonable.
My only quest...
Greg Shah
02:47 AM Bug #9917: Fileset not ignoring case
Dănuț Filimon wrote:
> I will be running a conversion today with the same customer application that failed previousl...
Dănuț Filimon
09:50 AM Feature #6256: improved profile support
Committed *6256a/15945*. Fixed the two issues I found when converting hotel using multiple profiles. Dănuț Filimon

06/17/2025

08:35 AM Feature #6256: improved profile support
I fixed the problem by removing the bit of code that checks for @isMultiProfile()@, this was added in:... Dănuț Filimon
06:01 AM Feature #6256: improved profile support
The issue is related to @TransformDriver.createDatabaseList()@ where the "standard" namespace is not taken into consi... Dănuț Filimon
04:44 AM Bug #10099 (WIP): Tilde consumes the octals/follow-up characters, when in OE this doesn't happen
Stefan Vieru
02:54 AM Bug #9917: Fileset not ignoring case
I will be running a conversion today with the same customer application that failed previously. Dănuț Filimon
02:36 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
The project was converted and built successfully. Dănuț Filimon

06/16/2025

06:24 AM Feature #6256: improved profile support
The issue is that there are three profiles and the two profiles that do not define a namespace for the hotel, do not ... Dănuț Filimon
06:20 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
You can start, I have nothing to add for now. Stefan Vieru
06:18 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Stefan, is there anything else you need to add to the branch? I want to pick this up and run a customer conversion. Dănuț Filimon
04:37 AM Bug #9863 (Review): Fileset eXclude broken on native Windows
I created a @FileListFactory.normalizeFilePath()@ method and tested the following:
# @D ./abl/tmp/ *.p@ => @abl/tmp@...
Dănuț Filimon

06/13/2025

09:12 AM Bug #9863: Fileset eXclude broken on native Windows
We still need to canonicalize the result. Please write a version of the processing that can handle it. Greg Shah
08:08 AM Bug #9863: Fileset eXclude broken on native Windows
Greg Shah wrote:
> > I'm also wondering if we should account for @..@ in the filters?
>
> Canonicalization whould...
Dănuț Filimon
08:06 AM Bug #9863: Fileset eXclude broken on native Windows
> I'm also wondering if we should account for @..@ in the filters?
Canonicalization whould deal with things like @...
Greg Shah
07:57 AM Bug #9863: Fileset eXclude broken on native Windows
Dănuț Filimon wrote:
> Some cases I tested/will test:
> # @D ./abl/tmp/@ : at row 1 in file zfile_set.txt is malfor...
Dănuț Filimon
07:56 AM Bug #9863: Fileset eXclude broken on native Windows
Committed *9863a/15981*. Summary of the changes:
* Paths should replace "\\" with "/" before any processing is done,...
Dănuț Filimon
06:51 AM Bug #9863: Fileset eXclude broken on native Windows
Greg Shah wrote:
> > Currently @X ./abl/tmp/@ does nothing. It will not exclude any files from the specified folder ...
Dănuț Filimon
06:41 AM Bug #9863: Fileset eXclude broken on native Windows
> Currently @X ./abl/tmp/@ does nothing. It will not exclude any files from the specified folder since the pattern wi... Greg Shah
06:08 AM Bug #9863: Fileset eXclude broken on native Windows
Currently @X ./abl/tmp/@ does nothing. It will not exclude any files from the specified folder since the pattern will... Dănuț Filimon
06:07 AM Bug #9863: Fileset eXclude broken on native Windows
Greg Shah wrote:
> Dănuț Filimon wrote:
> > Greg Shah wrote:
> > > > I am sure we do not want to add a feature whi...
Dănuț Filimon
06:06 AM Bug #9863: Fileset eXclude broken on native Windows
Dănuț Filimon wrote:
> Greg Shah wrote:
> > > I am sure we do not want to add a feature which didn't exist before.
...
Greg Shah
06:02 AM Bug #9863: Fileset eXclude broken on native Windows
Greg Shah wrote:
> > I am sure we do not want to add a feature which didn't exist before.
>
> Is it a new feature...
Dănuț Filimon
05:59 AM Bug #9863: Fileset eXclude broken on native Windows
> I am sure we do not want to add a feature which didn't exist before.
Is it a new feature? Or is it just making ...
Greg Shah
03:27 AM Bug #9863: Fileset eXclude broken on native Windows
Dănuț Filimon wrote:
> Additional note for #9863-43, @Utils.canonicalizePath()@ doesn't work for @.//abl//tmp//*@ bu...
Dănuț Filimon
06:10 AM Feature #6256: improved profile support
Greg Shah wrote:
> > I don't think two profiles should have the same namespace defined (with the same name).
>
> ...
Dănuț Filimon
06:02 AM Feature #6256: improved profile support
> I don't think two profiles should have the same namespace defined (with the same name).
Correct. Such a thing i...
Greg Shah
05:47 AM Feature #6256: improved profile support
Greg, the issue with #6256-84 is that I've defined the following namespace for both profiles:... Dănuț Filimon
04:38 AM Feature #6256: improved profile support
Committed *6256a/15944*. Added PROFILE mode.
Currently looking into the error from #6256-84.
Dănuț Filimon
02:29 AM Feature #6256: improved profile support
Greg Shah wrote:
> > There is a problem when the 'exclude' filter is used to not add files to conversion. During pr...
Constantin Asofiei

06/12/2025

09:26 AM Bug #9863: Fileset eXclude broken on native Windows
Greg Shah wrote:
> > If I replace the '\\' with '/', the only problem will be the pattern because the files in Windo...
Dănuț Filimon
09:01 AM Bug #9863: Fileset eXclude broken on native Windows
Greg Shah wrote:
> Normally, we use things like @Utils.canonicalizePath()@ to eliminate the excess nonsense like @so...
Dănuț Filimon
09:00 AM Bug #9863: Fileset eXclude broken on native Windows
Greg Shah wrote:
> > If I replace the '\\' with '/', the only problem will be the pattern because the files in Windo...
Dănuț Filimon
08:56 AM Bug #9863: Fileset eXclude broken on native Windows
Dănuț Filimon wrote:
> Greg, is the scenario [...] something that should be supported? Using a single \ instead of \...
Greg Shah
08:52 AM Bug #9863: Fileset eXclude broken on native Windows
> If I replace the '\\' with '/', the only problem will be the pattern because the files in Windows will be using '\'... Greg Shah
08:29 AM Bug #9863: Fileset eXclude broken on native Windows
Dănuț Filimon wrote:
> Greg, is the scenario [...] something that should be supported? Using a single \ instead of \...
Dănuț Filimon
07:58 AM Bug #9863: Fileset eXclude broken on native Windows
Greg, is the scenario ... Dănuț Filimon
07:03 AM Bug #9863: Fileset eXclude broken on native Windows
If I replace the '\\' with '/', the only problem will be the pattern because the files in Windows will be using '\' a... Dănuț Filimon
03:04 AM Bug #9863 (WIP): Fileset eXclude broken on native Windows
I'll work on #9863-33 to #9863-35. Dănuț Filimon
08:41 AM Bug #6308: post string literal alternative coding quirk in 4GL preprocessor
OK, good. Greg Shah
02:24 AM Bug #6308: post string literal alternative coding quirk in 4GL preprocessor
Greg Shah wrote:
> > The cause is that after the @&THEN@ of the first @&IF@, we set @InStatement@ on false.
> > Rem...
Stefan Vieru
03:03 AM Feature #6256 (WIP): improved profile support
Greg Shah wrote:
> > These profiles can only be used in the default @ConversionDriver@ mode which is @ListType.CMD_L...
Dănuț Filimon

06/11/2025

02:58 PM Bug #6308: post string literal alternative coding quirk in 4GL preprocessor
> The cause is that after the @&THEN@ of the first @&IF@, we set @InStatement@ on false.
> Removing this fixed the i...
Greg Shah
04:42 AM Bug #6308: post string literal alternative coding quirk in 4GL preprocessor
The changes in the current version include the following, after @ASTMT@... Stefan Vieru
02:42 PM Bug #9863: Fileset eXclude broken on native Windows
Code Review Task Branch 9863a Revision 15979
The change @filter = filter.replace('/', File.separatorChar);@ seems ...
Greg Shah
01:26 PM Bug #9863: Fileset eXclude broken on native Windows
> Let me know if I should work on supporting the @X ./abl/folder1/@ filter in this task, I will adjust the %Done if s... Greg Shah
11:34 AM Bug #9863: Fileset eXclude broken on native Windows
Dănuț Filimon wrote:
> Roger/Greg, please review.
I won't be able to really test until I get back to my Windows lap...
Roger Borrello
03:45 AM Bug #9863 (Review): Fileset eXclude broken on native Windows
Created *9863a* from latest *trunk/15978* and committed *9863a/15979*. The commit contains the fix for fileset eXclud... Dănuț Filimon
02:23 PM Feature #6256: improved profile support
> These profiles can only be used in the default @ConversionDriver@ mode which is @ListType.CMD_LINE@. For any of th... Greg Shah
01:48 PM Feature #6256: improved profile support
> There is a problem when the 'exclude' filter is used to not add files to conversion. During pre-scan phase, the fi... Greg Shah

06/10/2025

08:55 AM Bug #9863: Fileset eXclude broken on native Windows
We've been canonicalizing filenames to use @/@ on Windows in the past and had not found this limitation. Greg Shah
08:47 AM Bug #9863: Fileset eXclude broken on native Windows
On Windows, even if the path is ./abl/, it will make it into @.\abl@ when calling @new File(path)@, disregarding the ... Dănuț Filimon
07:05 AM Bug #9863: Fileset eXclude broken on native Windows
Greg Shah wrote:
> The patterns should not be file-system specific. In fact, we should only support the @/@ as the ...
Dănuț Filimon
07:01 AM Bug #9863: Fileset eXclude broken on native Windows
The patterns should not be file-system specific. In fact, we should only support the @/@ as the path separator. The... Greg Shah
05:54 AM Bug #9863: Fileset eXclude broken on native Windows
Replacing the "/" with the file separator in step 2 will make the filter match the ".\" (@./abl/fwd-embedded-driver.p... Dănuț Filimon
05:18 AM Bug #9863: Fileset eXclude broken on native Windows
I used the following zset:... Dănuț Filimon
07:06 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
I have updated: r15976 Stefan Vieru
06:52 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Got it, will remove this logging and will retain the null checks that have been found until now. I will create a comm... Stefan Vieru
06:50 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Returning @null@ will likely result in an NPE and we will see the stack trace already. Greg Shah
06:48 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Or maybe enable this logging when in @p2j.cfg.xml@ there is a "debugging" parameter set on true. Stefan Vieru
03:44 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Okay, will check for null calls and make sure these are bypassed. I kept the null checks in @visitAst@ which have bee... Stefan Vieru

06/09/2025

10:39 AM Feature #5630 (Closed): add missing classes referenced during parsing to the conversion list in f...
Greg Shah
10:39 AM Bug #6082 (Closed): automatically add to conversion list all non-skeleton .cls dependencies
Greg Shah

06/06/2025

11:24 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
In those cases, we should not call @getPathToConversionFolder()@. Just bypass it when the input is @null@. In other... Greg Shah
09:49 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
The functions in #5586-77, the @visitAst@ methods.
In the case of @com.goldencode.p2j.uast.SymbolResolver#loadClass...
Stefan Vieru
09:37 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
> I have found that there are many places that might call getPathToConversionFolder with a null filename
This seem...
Greg Shah
08:59 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
While testing the latest revision I have found that there are many places that might call @getPathToConversionFolder@... Stefan Vieru
10:17 AM Feature #6319: IntelliJ plugin
I see that the IntelliJ LSP support isn't maintained anymore. Also, according to "jetbrains":https://plugins.jetbrain... Florin Eugen Rotaru
07:15 AM Bug #9863: Fileset eXclude broken on native Windows
I managed to setup the w11 vm and reproduce the issue. Currently investigating. Dănuț Filimon
04:54 AM Bug #9863: Fileset eXclude broken on native Windows
Șerban Bursuc wrote:
> Dănuț Filimon wrote:
> > Roger, is there a minimal requirement for the w11 vm? I've made min...
Dănuț Filimon
04:53 AM Bug #9863: Fileset eXclude broken on native Windows
Dănuț Filimon wrote:
> Roger, is there a minimal requirement for the w11 vm? I've made mine with 4gb base memory and...
Șerban Bursuc
04:45 AM Bug #9863: Fileset eXclude broken on native Windows
Roger, is there a minimal requirement for the w11 vm? I've made mine with 4gb base memory and 2 processors and it han... Dănuț Filimon
02:49 AM Bug #9863: Fileset eXclude broken on native Windows
Roger Borrello wrote:
> Dănuț Filimon wrote:
> > Hi Roger, I am trying to setup a Windows11 instance to start worki...
Dănuț Filimon

06/05/2025

11:35 AM Bug #9863: Fileset eXclude broken on native Windows
Dănuț Filimon wrote:
> Hi Roger, I am trying to setup a Windows11 instance to start working on this issue and have b...
Roger Borrello
06:17 AM Bug #9863: Fileset eXclude broken on native Windows
Hi Roger, I am trying to setup a Windows11 instance to start working on this issue and have been meeting with some is... Dănuț Filimon
10:09 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
> Created r15974 with the following changes:
Please add comments to these code locations to explain that @// these...
Greg Shah
08:26 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Stefan, I mentioned in our weekly meeting that I plan to run a conversion on a customer project. At the moment, the i... Dănuț Filimon
08:25 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Also added r15975 which removes a redundant null check from @getPathToConversionFolder@. This check has been moved in... Stefan Vieru
06:46 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Created r15974 with the following changes:... Stefan Vieru
02:28 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Ovidiu Maxiniuc wrote:
> I think you should simply ignore these locations. These "in-mem" files are volatile resourc...
Stefan Vieru
08:45 AM Bug #10099: Tilde consumes the octals/follow-up characters, when in OE this doesn't happen
When preprocessing the following test: (same behavior is present with @~@ directly)... Stefan Vieru
08:39 AM Bug #10099 (Internal Test): Tilde consumes the octals/follow-up characters, when in OE this doesn...
Stefan Vieru
08:40 AM Bug #9917 (Review): Fileset not ignoring case
Committed *9917a/14971*. Use Set instead of List for listImpl() and sortFiles() + a few small changes. Dănuț Filimon
08:00 AM Bug #9917: Fileset not ignoring case
I rebased *9917a* to latest *trunk/15967*, the branch is now at revision *15970*.
I plan to commit the change for...
Dănuț Filimon
04:22 AM Bug #9917: Fileset not ignoring case
I committed *9917a/15947*. This only contains changes for the frame and menu issue, the idea is that in @convertSourc... Dănuț Filimon

06/04/2025

05:20 PM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
I think you should simply ignore these locations. These "in-mem" files are volatile resources, not related to static ... Ovidiu Maxiniuc
08:05 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Ovidiu Maxiniuc wrote:
> I have looked at +5586a / r15973+.
>
> While I agree with using the constant suffixes fo...
Stefan Vieru
02:48 PM Bug #6082: automatically add to conversion list all non-skeleton .cls dependencies
Greg Shah wrote:
> What other related features are still not complete? The intention here is to resolve the problem...
Eduard Soltan
02:03 PM Bug #6082: automatically add to conversion list all non-skeleton .cls dependencies
What other related features are still not complete? The intention here is to resolve the problem that explciitly or ... Greg Shah
02:06 PM Feature #5630: add missing classes referenced during parsing to the conversion list in file list ...
For now, that approach does resolve this issue. In the future, we would also want to be able to use the annotations ... Greg Shah
11:56 AM Bug #9917: Fileset not ignoring case
> I'd expect the right start.p to be selected here. What do you think Greg?
Yes. On a case-insensitive approach, ...
Greg Shah
09:34 AM Bug #9917: Fileset not ignoring case
Dănuț Filimon wrote:
> [...]
>
> This fixes the issue, but I've just found an issue.
>
> Scenarios:
> # zfile...
Roger Borrello
09:30 AM Bug #9917: Fileset not ignoring case
... Dănuț Filimon
08:10 AM Bug #9917 (WIP): Fileset not ignoring case
Dănuț Filimon wrote:
> I think the naming convention for frames should be changed. When handling a frame with the na...
Dănuț Filimon
03:59 AM Bug #9917: Fileset not ignoring case
I think the naming convention for frames should be changed. When handling a frame with the name @test-form@, the name... Dănuț Filimon
03:33 AM Bug #9917: Fileset not ignoring case
I ran a conversion for a customer application that uses case-sensitive = false and it failed.
The scenario:
* 715...
Dănuț Filimon

06/03/2025

02:30 PM Feature #5630: add missing classes referenced during parsing to the conversion list in file list ...
Greg Shah wrote:
> We probably also should implement this even in blacklist mode. In other words: what should we do ...
Eduard Soltan
08:15 AM Feature #5630: add missing classes referenced during parsing to the conversion list in file list ...
Does trunk rev 15852 (changes from #7255) resolve this task? Greg Shah
02:24 PM Bug #6082: automatically add to conversion list all non-skeleton .cls dependencies
Greg Shah wrote:
> Does trunk rev 15852 (changes from #7255) resolve this task?
If the scope of this task is stri...
Eduard Soltan
08:15 AM Bug #6082: automatically add to conversion list all non-skeleton .cls dependencies
Does trunk rev 15852 (changes from #7255) resolve this task? Greg Shah
01:36 PM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
I have looked at +5586a / r15973+.
While I agree with using the constant suffixes for file types, I do not think w...
Ovidiu Maxiniuc
08:56 AM Feature #6256: improved profile support
Greg Shah wrote:
> Are you sure that the requirements of #6256-47 and #6256-50 are already handled? I didn't think ...
Dănuț Filimon
08:41 AM Feature #6256: improved profile support
Code Review Task Branch 6256a Revisions 15942 and 15943
The change is good.
Are you sure that the requirements ...
Greg Shah
07:53 AM Feature #6256 (Review): improved profile support
Indeed, BarTest.cls is added during the @Scanning Progress Source (preprocessor, lexer, parser, persist ASTs)@ step.
...
Dănuț Filimon
05:06 AM Feature #6256: improved profile support
Constantin Asofiei wrote:
> No, @X@ directive works only with @./abl/@ paths - there can't be relative paths.
>
>...
Eduard Soltan
03:23 AM Feature #6256: improved profile support
A breakdown of the remaining parameters:
* includeRemap: #6256-76 is really helpful, I also found that the tag is no...
Dănuț Filimon

06/02/2025

11:25 AM Feature #6256: improved profile support
I don't remember that code. It isn't currently used in the project associated with #4069.
Still, if it was needed...
Greg Shah
10:53 AM Feature #6256: improved profile support
@includeRemap@ is from:... Constantin Asofiei
10:43 AM Feature #6256: improved profile support
> > I updated https://proj.goldencode.com/projects/p2j/wiki/Chapter_6_Project_Setup#Profiles, but I am not sure how t... Greg Shah
09:46 AM Feature #6256: improved profile support
Constantin Asofiei wrote:
> > * paths: ?
This is the PROPATH for the profile.
Constantin Asofiei
09:45 AM Feature #6256: improved profile support
Dănuț Filimon wrote:
> I updated https://proj.goldencode.com/projects/p2j/wiki/Chapter_6_Project_Setup#Profiles, but...
Constantin Asofiei
09:37 AM Feature #6256: improved profile support
Dănuț Filimon wrote:
> Dănuț Filimon wrote:
> > I also want to add the following scenario:
> > * When there is a *...
Constantin Asofiei
09:34 AM Feature #6256: improved profile support
Dănuț Filimon wrote:
> I also want to add the following scenario:
> * When there is a *default* profile defined, bu...
Dănuț Filimon
07:55 AM Feature #6256: improved profile support
I updated https://proj.goldencode.com/projects/p2j/wiki/Chapter_6_Project_Setup#Profiles, but I am not sure how to de... Dănuț Filimon
06:43 AM Feature #6256: improved profile support
Constantin Asofiei wrote:
> If profiles are used, then:
> * if the profile has a fileset, then that is used
> * if...
Dănuț Filimon
06:12 AM Feature #6256: improved profile support
I committed *6256a/15492*. Ignore the -z fileset, but only when there's a profile fileset specified. Dănuț Filimon

05/30/2025

09:49 AM Bug #6308: post string literal alternative coding quirk in 4GL preprocessor
A present bug:
Preprocessing this in OE allows the file to be included:...
Stefan Vieru
04:58 AM Bug #9918: tilde doesn't duplicate semicolon in alternative codings
That seems reasonable. Greg Shah
02:52 AM Bug #9918: tilde doesn't duplicate semicolon in alternative codings
I have found that when preprocessing the following in OE:... Stefan Vieru

05/29/2025

10:15 AM Feature #6256: improved profile support
Greg Shah wrote:
> > When a profile is used using the -p option and we also use ListType.FILESET (-z), it should beh...
Constantin Asofiei
08:06 AM Feature #6256: improved profile support
Alexandru Lungu wrote:
> > So we intend for profiles to be self-contained definitions of applications/modules. I pre...
Greg Shah
08:00 AM Feature #6256: improved profile support
> So we intend for profiles to be self-contained definitions of applications/modules. I prefer not to mix random -z f... Alexandru Lungu
07:37 AM Feature #6256: improved profile support
> When a profile is used using the -p option and we also use ListType.FILESET (-z), it should behave like -z was not ... Greg Shah
07:05 AM Feature #6256: improved profile support
The ProfileConfig is created when the p2j.cfg.xml is read (Configuration.loadXml()), the following properties must be... Dănuț Filimon
06:10 AM Feature #6256: improved profile support
Greg Shah wrote:
> Please plan to make additions to our documentation to explain this syntax.
I will do so in thi...
Dănuț Filimon
06:06 AM Bug #9917: Fileset not ignoring case
I tested and didn't find a scenario where this breaks. The customer application I'm working on uses uses the default ... Dănuț Filimon
02:50 AM Bug #9917: Fileset not ignoring case
I committed 9917a/15946 to address #9917-7. I will do a few more tests. Dănuț Filimon

05/28/2025

12:53 PM Bug #9917 (Internal Test): Fileset not ignoring case
Code Review Task Branch 9917a Revision 15945
Please only initialize @directoryCache@ when @!isCaseSensitive()@ is ...
Greg Shah
07:56 AM Bug #9917 (Review): Fileset not ignoring case
I confirmed that the scenario doesn't work. About #9917-2, the compare method is not what I expect to use in this cas... Dănuț Filimon
11:07 AM Support #9919: discuss and define the MVP for the first pass at IDE support
Interesting results. I will have to check the licensing of LSP4J, not sure yet if it is safe to use.
I wasn't pla...
Greg Shah
10:27 AM Feature #6256: improved profile support
Please plan to make additions to our documentation to explain this syntax. Greg Shah
09:03 AM Feature #6256: improved profile support
I've experimented and the following worked:... Dănuț Filimon
08:46 AM Feature #6256: improved profile support
Dănuț Filimon wrote:
> Dănuț Filimon wrote:
> > I am trying to understand how p2j.cfg.xml is used in this context, ...
Dănuț Filimon
08:29 AM Feature #6256: improved profile support
Dănuț Filimon wrote:
> I am trying to understand how p2j.cfg.xml is used in this context, I've found the following d...
Dănuț Filimon
05:31 AM Feature #6256: improved profile support
I am trying to understand how p2j.cfg.xml is used in this context, I've found the following documentation https://pro... Dănuț Filimon
04:59 AM Feature #6256: improved profile support
No, @X@ directive works only with @./abl/@ paths - there can't be relative paths.
> During pre-scan phase, the fil...
Constantin Asofiei
04:26 AM Feature #6256: improved profile support
For #6256-53, I think the fix needs to involve the p2j.cfg.xml (the propath and basepath parameters). In @FileListFac... Dănuț Filimon
09:48 AM Bug #9886: Double slashes should produce a new line during preprocessing
Will start the CHUI regression tests after #5586. I have added another rev, 15911. The changes:
* flag is not initia...
Stefan Vieru
04:49 AM Bug #6308: post string literal alternative coding quirk in 4GL preprocessor
I had to add this in @condtext@ in the Parser:... Stefan Vieru
04:48 AM Bug #6308: post string literal alternative coding quirk in 4GL preprocessor
I have fixed this issue regarding @&THEN@.
It seems that when preprocessing ...
Stefan Vieru

05/27/2025

09:47 AM Feature #6256: improved profile support
Constantin Asofiei wrote:
> There is a problem when the 'exclude' filter is used to not add files to conversion. Du...
Dănuț Filimon
07:45 AM Feature #6256: improved profile support
Created task branch *6256a* from latest *trunk/15941*. Dănuț Filimon
04:04 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Committed *7180a/15952*. Simplified transformArtifactNames() and removed containsArtifact() from ArtifactManager.
...
Dănuț Filimon

05/26/2025

10:12 AM Support #9919: discuss and define the MVP for the first pass at IDE support
I have experimented a bit with "LSP4J":https://github.com/eclipse-lsp4j/lsp4j, which is a framework that offers suppo... Florin Eugen Rotaru
07:49 AM Feature #6256: improved profile support
Although I added some notes in #6256-45, those are wider requirements for app-by-app conversion. We won't work those... Greg Shah
07:39 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
I decided that I will hold off the changes to UastHints due to #7180-163, I shifted my focus to getting rid of the Fi... Dănuț Filimon

05/23/2025

08:24 AM Bug #6308: post string literal alternative coding quirk in 4GL preprocessor
Stefan Vieru wrote:
>
> [...]
> My interpretation is that OE just "eats" what is after &THEN.
> How should I a...
Stefan Vieru
06:22 AM Bug #6308: post string literal alternative coding quirk in 4GL preprocessor
Another bug:... Stefan Vieru
04:18 AM Bug #6308: post string literal alternative coding quirk in 4GL preprocessor
Same behavior described in #6859-19 for @&ENDIF@
Stefan Vieru
03:44 AM Bug #6308: post string literal alternative coding quirk in 4GL preprocessor
I've created tests for all types of combinations between
* &scoped-define
* &if
* &then
* &elseif
* &else
* &e...
Stefan Vieru
07:49 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
One issue with using artifacts in UastHints which is problematic. The example is @AstGenerator.processFile()@ where w... Dănuț Filimon
06:14 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
I was going into the customer rules for the ChUI project and noticed a @getSourceFor()@ call which returns a filename... Dănuț Filimon
05:53 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Rebased *7180a* to latest *trunk/15932*, the branch is now at revision *15951*. Dănuț Filimon

05/22/2025

09:51 AM Bug #10028: FWD needs full support for unicode/octal escape sequences
I finished preprocessor testcases for printable ASCII characters (octal representation). I continue with code page-de... Octavian Adrian Gavril
06:52 AM Bug #10028: FWD needs full support for unicode/octal escape sequences
Agreed. Greg Shah
03:26 AM Bug #10028: FWD needs full support for unicode/octal escape sequences
A thought about the case like @define variable ch as character initial "~000doesntmatter":U no-undo.@.
In FWD, the...
Constantin Asofiei
 

Also available in: Atom