FWD » Core Development » Conversion Tools

• when we are placed inside a comment the alternative coding is not processed and ; is NOT duplicated
• when we are outside a comment the alternative coding is not processed and ; IS duplicated

while working on this I saw that the inString variable is not set correctly when reading the stream:
We have for example the following "text";&
When the read() function from ClearStream reaches ; the inString boolean is still set on True.
As a workaround i put this in text.g:

         // most (but not all) alternative codings that follow (without whitespace) a string literal
         // have a 4GL preproc quirk where the ; is eaten and the following char is left behind
         if (LA(1) == 0x3B                                    &&   // 0x3B is ; 
             ClearStream.isAlternativeCoding(LA(1), LA(2)))
         {
            if (LA(2) != 0x26                                 &&   // 0x26 is &
                LA(2) != 0x27                                 &&   // 0x27 is '
                LA(2) != 0x3F)                                     // 0x3F is ?
            {
                consume();
                text.setLength(text.length() - 1);
            }
            else
            {
                consume();
                consume();
                text.setLength(text.length() - 2);
                if (LA(1) == 0x20)
                {
                    consume();
                    text.setLength(text.length() - 1);
                }
            }
         }

To explain the current issue, only right now &,when we have the following code:

txt = "text"~;&GLOBAL-DEFINE argname4 9
txt = 'text'~;&GLOBAL-DEFINE argname4 9
txt = "text"~;& GLOBAL-DEFINE argname4 9
txt = 'text'~;& GLOBAL-DEFINE argname4 9

txt = "text"~;;&GLOBAL-DEFINE argname4 9
txt = 'text'~;;&GLOBAL-DEFINE argname4 9
txt = "text"~;;& GLOBAL-DEFINE argname4 9
txt = 'text'~;;& GLOBAL-DEFINE argname4 9

FWD preprocesses to:

txt = "text"txt = 'text'txt = "text"txt = 'text'

[00046:015] <CODE>                  ~;;
[00046:018] <CODE>                  &
[00046:019] <CODE>                  GLOBAL-DEFINE

and now preprocessing with FWD results:

txt3 = "text3"~;;&GLOBAL-DEFINE argname3 9
txt4 = 'text4'~;;&GLOBAL-DEFINE argname4 9
txt3 = "text3"~;;& GLOBAL-DEFINE argname3 9
txt4 = 'text4'~;;& GLOBAL-DEFINE argname4 9

I have committed this to 9918a/15892.

I have found that when preprocessing the following in OE:

// ~;(
/* ~;( */

The alternative coding in the SLASH_SLASH is converted:

// ~{

/* ~;( */

In FWD we will need to differentiate if we are in a SLASH_SLASH comment or a STAR_COMMENT for this purpose.
What I'm suggesting is adding 2 more flags, inStarComment and inSlashComment, and having inComment = inStarComment || inSlashComment, so that we don't have to make too many changes to the source code.

That seems reasonable.

• when we encounter a tilde we check if an alternative coding is placed after it;
• we then set the offset to 2, meaning that we skip the next 2 characters from being processed;
• duplicating the ; character when encountered, but only outside of comments and strings;
• we consume an ASTMT only if the offset is set on 0, for example:
  

  ~;?GLOBAL-DEFINED arg 1
  

  
  would need to be:
  

  ~;;?GLOBAL-DEFINED arg 1
  

  
  & would also need to be consumed when the offset is 0.

All changes have been moved to 6859b.

• alternative_coding_quirk_01
• alternative_coding_quirk_01_analyze
• alternative_coding_quirk_01_combined_directives_global
• alternative_coding_quirk_01_combined_directives_scoped
• alternative_coding_quirk_01_combined_directives_undefined
• alternative_coding_quirk_01_else
• alternative_coding_quirk_01_else_if
• alternative_coding_quirk_01_endif
• alternative_coding_quirk_01_if
• alternative_coding_quirk_01_message
• alternative_coding_quirk_01_post_string
• alternative_coding_quirk_01_then
• alternative_coding_quirk_01_tilde_strings
• alternative_coding_quirk_01_undefine
• alternative_coding_quirk_02
• alternative_coding_quirk_02_left_bracket
• alternative_coding_quirk_02_right_bracket
• alternative_coding_quirk_03
• alternative_coding_quirk_04
• alternative_coding_quirk_05
• alternative_coding_quirk_05_left_curly
• alternative_coding_quirk_05_post_curly
• alternative_coding_quirk_05_right_curly
• alternative_coding_quirk_06
• alternative_coding_quirk_07
• alternative_coding_quirk_08_global
• alternative_coding_quirk_08_scoped