FWD » Core Development » Conversion Tools

04/22/2025

09:46 AM Support #9919: discuss and define the MVP for the first pass at IDE support

In #6319 and #3883 we are implementing IDE support for two common Java IDE platforms. For the first pass, we need to... Greg Shah

09:37 AM Support #9919 (WIP): discuss and define the MVP for the first pass at IDE support

Greg Shah

09:45 AM Bug #9918 (WIP): tilde doesn't duplicate semicolon in alternative codings

Stefan Vieru

07:26 AM Bug #9918: tilde doesn't duplicate semicolon in alternative codings

While developing some more tests i have found that:... Stefan Vieru

07:25 AM Bug #9918 (Internal Test): tilde doesn't duplicate semicolon in alternative codings

Stefan Vieru

08:49 AM Bug #9905 (Internal Test): EOF file is not matched during preprocessing

Code Review Task Branch 9905a Revision 15868
The changes look good. Greg Shah

06:36 AM Bug #9905: EOF file is not matched during preprocessing

The issue i addressed earlier about the random NL that appear:
When we have a .i file that we include, in OE if it h... Stefan Vieru

06:05 AM Bug #9905 (Review): EOF file is not matched during preprocessing

Stefan Vieru

06:05 AM Bug #9905: EOF file is not matched during preprocessing

I have created 9905a with rev 15868 with my changes.
I have added the following change... Stefan Vieru

11:13 PM Bug #9917: Fileset not ignoring case

Filesets are not finding files when case-insensitivity is true and @-Z@ is used. This behaves in the same manner as @... Roger Borrello

10:57 PM Bug #9917 (Closed): Fileset not ignoring case

Roger Borrello

10:56 PM Bug #9863: Fileset eXclude broken on native Windows

Changed title to more focus on the issue Roger Borrello

04/17/2025

10:16 AM Bug #9905: EOF file is not matched during preprocessing

OK, the bottom line here: please keep going with the fixes. The FWD output should match OE output exactly. Greg Shah

07:15 AM Bug #9905: EOF file is not matched during preprocessing

I will explain the issue better after some analysis:
When @sym.size() = = 2@ (sym being the "stack call" of the fil... Stefan Vieru

07:03 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

I've went through the changes required to successfully convert the hotel gui project, the next step is to verify any ... Dănuț Filimon

04/16/2025

12:46 PM Bug #9905: EOF file is not matched during preprocessing

> This change fixes all the harness EOF errors, but only if we dont have a NL present at any of the files(also includ... Greg Shah

08:08 AM Bug #9905: EOF file is not matched during preprocessing

I looked into this issue and what I've found is:
In ClearStream @mread@, at the end... Stefan Vieru

08:53 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

Greg Shah wrote:
> Dănuț Filimon wrote:
> > I our last meeting I mentioned that I modified Aast.getFilename() to Aa... Dănuț Filimon

08:49 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

Dănuț Filimon wrote:
> I our last meeting I mentioned that I modified Aast.getFilename() to Aast.getArtifact(). file... Greg Shah

08:22 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

I our last meeting I mentioned that I modified Aast.getFilename() to Aast.getArtifact(). filename is used a lot in th... Dănuț Filimon

07:51 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

I discussed with Alex, #7180-101 is fixed by adding the worker in a file that includes the dmo_common.rules. I added ... Dănuț Filimon

06:05 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

I made the following patch for a quick fix on a function:... Dănuț Filimon

03:08 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

The rebase is too problematic, I have to refactor changes that are not related to the commit in order to ensure compa... Dănuț Filimon

08:38 AM Support #9703 (Closed): explore and document the existing OE IDE feature set

Nice! Greg Shah

02:55 AM Support #9703: explore and document the existing OE IDE feature set

Greg Shah wrote:
> I've read the changes. They are quite good. Some followup questions/comments:
>
> 1. In the ... Florin Eugen Rotaru

04/15/2025

02:10 PM Support #9703: explore and document the existing OE IDE feature set

I've read the changes. They are quite good. Some followup questions/comments:
1. In the "A Simple GUI/TTY Projec... Greg Shah

04:39 AM Support #9703 (Review): explore and document the existing OE IDE feature set

I finished writing "Configuring OpenEdge Projects":https://proj.goldencode.com/projects/p2j/wiki/Configuring_OpenEdge... Florin Eugen Rotaru

10:14 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

Constantin Asofiei wrote:
> Dănuț Filimon wrote:
> > I am not sure how to solve this conflict, maybe @bzr remove sr... Dănuț Filimon

10:10 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

Dănuț Filimon wrote:
> I am not sure how to solve this conflict, maybe @bzr remove src/com/goldencode/p2j/uast/ScanD... Constantin Asofiei

10:07 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

Constantin Asofiei wrote:
> Dănuț Filimon wrote:
> > Constantin Asofiei wrote:
> > > Question, did you unbind the ... Dănuț Filimon

10:04 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

Dănuț Filimon wrote:
> Constantin Asofiei wrote:
> > Question, did you unbind the branch first?
> Yes.
OK, then y... Constantin Asofiei

10:02 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

Constantin Asofiei wrote:
> Question, did you unbind the branch first?
Yes. Dănuț Filimon

10:02 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

Question, did you unbind the branch first?
Constantin Asofiei

10:00 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

Greg Shah wrote:
> @file@ is a "global" variable that is provided by @CommonAstSupport@.
Indeed, there is a getFi... Dănuț Filimon

09:10 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

Current rebase issue.... Dănuț Filimon

09:05 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

@file@ is a "global" variable that is provided by @CommonAstSupport@. Greg Shah

07:36 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

I have refactored the NsConfig to use an Artifact for the importFile and it worked out great, the only thing that nee... Dănuț Filimon

09:59 AM Bug #9905 (WIP): EOF file is not matched during preprocessing

Stefan Vieru

09:54 AM Bug #9905: EOF file is not matched during preprocessing

With this file:... Stefan Vieru

09:39 AM Bug #9905: EOF file is not matched during preprocessing

This is the output from OE
!oe_basic.png!
This is the output from FWD
!fwd_basic.png!
As we can see, at the e... Stefan Vieru

09:39 AM Bug #9905: EOF file is not matched during preprocessing

During preprocessing EOF is not matching the expected baseline.
For example:... Stefan Vieru

09:32 AM Bug #9905 (Internal Test): EOF file is not matched during preprocessing

Stefan Vieru

08:55 AM Bug #6308 (Internal Test): post string literal alternative coding quirk in 4GL preprocessor

Code Review Task Branch 6308a Revision 15852
The change is good.
In rev 15853, I added comments and changed the... Greg Shah

06:11 AM Bug #6308: post string literal alternative coding quirk in 4GL preprocessor

I updated this, new rev is 15852. Stefan Vieru

03:41 AM Bug #6308: post string literal alternative coding quirk in 4GL preprocessor

Greg Shah wrote:
> Code Review Task Branch 6308a Revision 15851
>
> My only concern is that this quirk will occur... Stefan Vieru

07:14 AM Bug #9903: alternative codings with ' (quote) don't convert to ` (backtick)

Base test:... Stefan Vieru

07:09 AM Bug #9903: alternative codings with ' (quote) don't convert to ` (backtick)

In the Preprocessor wiki and in @com.goldencode.p2j.preproc.Preprocessor@ is stated that @;'@ should convert to @'@, ... Stefan Vieru

07:07 AM Bug #9903 (Internal Test): alternative codings with ' (quote) don't convert to ` (backtick)

Stefan Vieru

06:58 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

Greg Shah wrote:
> Code Review Task Branch 5586a Revisions 15809 through 15811
>
> The changes are good.
>
> M... Stefan Vieru

04/14/2025

02:54 PM Bug #6308: post string literal alternative coding quirk in 4GL preprocessor

Code Review Task Branch 6308a Revision 15851
My only concern is that this quirk will occur for any alternative cod... Greg Shah

09:34 AM Bug #6308 (Review): post string literal alternative coding quirk in 4GL preprocessor

Stefan Vieru

09:01 AM Feature #5586 (Internal Test): move all conversion artifacts/outputs into the cvtdb or into a ded...

Code Review Task Branch 5586a Revisions 15809 through 15811
The changes are good.
Minor change: please create a... Greg Shah

07:22 AM Feature #5586 (Review): move all conversion artifacts/outputs into the cvtdb or into a dedicated ...

Stefan Vieru

06:33 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

Greg Shah wrote:
> > The problem is that I'll reach into NsConfig which I've already tried to refactor once and fail... Dănuț Filimon

05:27 AM Bug #7255 (Test): FWD resolves a OO file not included in conversion, if it exists on disk and on ...

Eduard Soltan

05:26 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

7255a was merged to trunk rev. 15852 and archived. Eduard Soltan

03:51 AM Bug #7255 (Merge Pending): FWD resolves a OO file not included in conversion, if it exists on dis...

Please merge after 9021b Constantin Asofiei

04/11/2025

10:01 AM Bug #6308 (WIP): post string literal alternative coding quirk in 4GL preprocessor

Created 6308a with revision 15851 Stefan Vieru

09:39 AM Bug #9894: new line with no carriage present in FWD conversion on windows

* in OE with @/* */@ comments we don't have two @/r/n@, but with @// @ we do. The following processes as it is.
<p... Stefan Vieru

09:39 AM Bug #9894 (New): new line with no carriage present in FWD conversion on windows

Stefan Vieru

09:36 AM Bug #9886 (Internal Test): Double slashes should produce a new line during preprocessing

Greg Shah

09:36 AM Bug #9886: Double slashes should produce a new line during preprocessing

> in FWD whether we use Preprocessor on windows or unix we have ONLY @\n@, due to the following I think
Please reg... Greg Shah

09:31 AM Bug #9886: Double slashes should produce a new line during preprocessing

Code Review Task Branch 9886a Revision 15852
I'm good with the changes. Greg Shah

06:06 AM Bug #9886: Double slashes should produce a new line during preprocessing

I updated the branch, new rev 15852. Stefan Vieru

04:41 AM Bug #9886: Double slashes should produce a new line during preprocessing

Greg Shah wrote:
> Code Review Task Branch 9886a Revisions 15850 and 15851
>
> 1. Could the problem here be somet... Stefan Vieru

09:20 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Code Review Task Branch 7255a Revisions 15828 through 15830
I'm good with the changes. Greg Shah

03:58 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Fixed review issue. Committed on 7255a, rev. 15830. Eduard Soltan

03:44 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Review for 7255a rev 15829:
* @FileList@ - this code... Constantin Asofiei

08:23 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

> The problem is that I'll reach into NsConfig which I've already tried to refactor once and failed. I think I'll man... Greg Shah

07:56 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

Greg Shah wrote:
> > I've got a question, if I have to create the artifact in the rules like in the following situat... Dănuț Filimon

07:45 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

> I've got a question, if I have to create the artifact in the rules like in the following situation:
> [...] where ... Greg Shah

07:44 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

> I ended up generating artifacts like this for ProgressASTs, so the issue from #7180-80 is valid. There are a few co... Greg Shah

07:40 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

The idea is to create a new Worker that would provide functionalities to the ArtifactManager, I'll take a look at Abs... Dănuț Filimon

06:51 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

I've got a question, if I have to create the artifact in the rules like in the following situation:... Dănuț Filimon

06:02 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

I ended up generating artifacts like this for ProgressASTs, so the issue from #7180-80 is valid. There are a few conv... Dănuț Filimon

04/10/2025

04:15 PM Bug #9886: Double slashes should produce a new line during preprocessing

Code Review Task Branch 9886a Revisions 15850 and 15851
1. Could the problem here be something related to the Wind... Greg Shah

09:32 AM Bug #9886 (Review): Double slashes should produce a new line during preprocessing

Stefan Vieru

09:32 AM Bug #9886: Double slashes should produce a new line during preprocessing

Created branch 9886a with revision 15851.
The added changes fix the issue that when preprocessing with FWD a file, i... Stefan Vieru

08:07 AM Bug #9886 (WIP): Double slashes should produce a new line during preprocessing

Stefan Vieru

09:09 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Committed on 7255a, rev. 15829.
Refactor the @addAdditionalFiles@ and @removeFiles@ methods, to get as a parameter... Eduard Soltan

08:35 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

Greg Shah wrote:
> > After making lots of changes to replace the filename usage, I ended up changing some calls in t... Dănuț Filimon

08:01 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

> After making lots of changes to replace the filename usage, I ended up changing some calls in the @Worker@ classes ... Greg Shah

07:59 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

> However, there's also the option of replacing the @BasePlugin.fnames@ from a Map<String, Long> to a Map<Artifact, L... Greg Shah

07:56 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

After making lots of changes to replace the filename usage, I ended up changing some calls in the @Worker@ classes to... Dănuț Filimon

02:29 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

Dănuț Filimon wrote:
> I understand. I was confused a bit because if I make this change I'd have to either lock base... Dănuț Filimon

02:19 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

Greg Shah wrote:
> But with things like the ASTs, the ID is absolutely critical and cannot be eliminated.
>
> >
... Dănuț Filimon

03:51 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

I added the above changes in 5586a, rev 15809 and 15811.
The changes include:
* provided safe default options in ca... Stefan Vieru

04/09/2025

10:02 AM Bug #9886: Double slashes should produce a new line during preprocessing

During preprocessing, the following:... Stefan Vieru

10:00 AM Bug #9886 (Internal Test): Double slashes should produce a new line during preprocessing

Stefan Vieru

09:56 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

> The more I did deeper into AstManager/AstGenerator, I see that we can also provide an id instead of the filename fo... Greg Shah

06:52 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

The more I did deeper into AstManager/AstGenerator, I see that we can also provide an id instead of the filename for ... Dănuț Filimon

07:22 AM Bug #9871 (Rejected): String followed by an alternative coding construct should emit a single cha...

The work will continue on #6308. Alexandru Lungu

04/08/2025

08:31 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

A summary of the changes from the last two commits (7180a/15852 and 7180a/15853):
# @src/com/goldencode/p2j/uast/Sca... Dănuț Filimon

07:24 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

Rebased *7180a* to latest *trunk/15846*, the branch is now at revision *15853*. Dănuț Filimon

07:06 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

Committed *7180a/15830*. Replaced a few more usages of the filename with artifacts, this expands the lexer/parser art... Dănuț Filimon

03:35 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

I tested hotel conversion and switched to converting *.cls, I found a few regressions and now I am working on fixing ... Dănuț Filimon

08:18 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

> Well, the changes on the branch already generate the .schema, .p2o and .dict files inside @cvt/data@, with the sche... Greg Shah

08:14 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

Well, the changes on the branch already generate the .schema, .p2o and .dict files inside @cvt/data@, with the schema... Stefan Vieru

07:59 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

> I'm looking into 3 but I can't find an example where namespace dir is used. I see in testcases that it is reference... Greg Shah

02:40 AM Feature #5586 (WIP): move all conversion artifacts/outputs into the cvtdb or into a dedicated dir...

Greg Shah wrote:
> Code Review Task Branch 5586a Revisions 15804 through 15808
>
> 1. In @Configuration.getPathTo... Stefan Vieru

07:54 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

> Since @files@ in FileList is stored as a Java array I don't know whether it could be made in more efficient way. Bu... Greg Shah

01:55 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Constantin Asofiei wrote:
>
> Otherwise, please get the #9457 app setup (see #9457-39), and test the #9420 scenari... Eduard Soltan

01:35 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Greg Shah wrote:
>
> My only concern is that the changes are likely to have an impact on performance. @SR.findFil... Eduard Soltan

04/07/2025

01:29 PM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Code Review Task Branch 7255a Revisions 15822 through 15827
I don't have an objection to the functional changes. ... Greg Shah

08:23 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Eduard, 7255a rev 15827 fixes some whitespace.
* in ScanDriver: either synchronize the method or create the sets in ... Constantin Asofiei

05:03 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

Committed *7180a/15829*. Addressed part of the #7180-60 review, added locking methods for the artifact and the plan i... Dănuț Filimon

04/04/2025

08:13 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

Code Review Task Branch 5586a Revisions 15804 through 15808
1. In @Configuration.getPathToConversionFolder()@, I d... Greg Shah

06:11 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Eduard Soltan wrote:
> I also think we should also synchronize the operations made on iterator @iter@, even if it is... Constantin Asofiei

03:22 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Constantin Asofiei wrote:
> * the way the static fields are now in @ScanDriver@, this does not support multi-threadi... Eduard Soltan

02:41 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Constantin Asofiei wrote:
> * shouldn't this code 'break' the loop? Because otherwise you remove the @referenceFi... Eduard Soltan

02:35 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Review for 7255a rev 15825:
* you have a typo in @remvoeSource@. same in @remvoeFile@ and @removedConverstionFiles@
... Constantin Asofiei

05:26 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

Greg Shah wrote:
> > The filename is retrieved through the @getFilename()@ call and this one relies on a @ParserShar... Dănuț Filimon

05:16 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

> The filename is retrieved through the @getFilename()@ call and this one relies on a @ParserSharedInputState/LexerSh... Greg Shah

04:01 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

The idea with the Lexer ends up with two scenarios:
# A @Reader@ parameter given to the @ProgressLexer@ constructor,... Dănuț Filimon

04/03/2025

10:00 AM Bug #7255 (Review): FWD resolves a OO file not included in conversion, if it exists on disk and o...

Eduard Soltan

08:27 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Committed on 7255a, rev. 15825. Eduard Soltan

07:43 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Eduard Soltan wrote:
> I some thoughts about this one, shouldn't we remove from the conversion list the @src2/oo/Bar... Constantin Asofiei

04:44 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Constantin Asofiei wrote:
> > * if oo.Bar is in both src1 and src2, PROPATH has both src1/ and src2/, and both src... Eduard Soltan

07:06 AM Bug #9871: String followed by an alternative coding construct should emit a single character

The modifications should be done somewhere here: com/goldencode/p2j/preproc/ClearStream.java:588 Stefan Vieru

06:51 AM Bug #9871: String followed by an alternative coding construct should emit a single character

When converting/preprocessing the following code... Stefan Vieru

06:49 AM Bug #9871 (Rejected): String followed by an alternative coding construct should emit a single cha...

Stefan Vieru

04/02/2025

01:50 PM Bug #9863: Fileset eXclude broken on native Windows

> > Then the only issue is possible drive letters.
> If "Running the Front End Conversion":/projects/p2j/wiki/Runnin... Greg Shah

09:52 AM Bug #9863: Fileset eXclude broken on native Windows

Greg Shah wrote:
> Don't use @\\@ anywhere, unless we really have to do so. Instead of shifting to the @File.separa... Roger Borrello

07:54 AM Bug #9863: Fileset eXclude broken on native Windows

Don't use @\\@ anywhere, unless we really have to do so. Instead of shifting to the @File.separatorChar@, I would pr... Greg Shah

01:00 PM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Eduard Soltan wrote:
> Ok, after this discussion lets recap a bit to not create any more confusion.
>
> * if oo.B... Constantin Asofiei

12:37 PM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Ok, after this discussion lets recap a bit to not create any more confusion.
* if oo.Bar exists only once in PROPA... Eduard Soltan

12:14 PM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Keep in mind that this @findFile@ needs to do the lookup in all @searchList@ entries, and only after that decide what... Constantin Asofiei

11:38 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Eduard Soltan wrote:
> Eduard Soltan wrote:
>
> > I think that is the source of confusion. As in the current vers... Constantin Asofiei

11:22 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Eduard Soltan wrote:
> I think that is the source of confusion. As in the current version of trunk, for duplicate ... Eduard Soltan

11:17 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Constantin Asofiei wrote:
> Eduard Soltan wrote:
> > And in @findFile@ there is no way I will even know that there ... Eduard Soltan

11:12 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Eduard Soltan wrote:
> And in @findFile@ there is no way I will even know that there is a @src2/oo/Bar.cls@.
@findF... Constantin Asofiei

11:10 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Constantin Asofiei wrote:
> So if you have @src1/oo/Bar.cls@ and @src2/oo/Bar.cls@ in conversion list, and only @src... Eduard Soltan

10:49 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

You have access to the set of conversion files. @findFile@ will have also the name of physical found file. Make sur... Constantin Asofiei

10:21 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Constantin Asofiei wrote:
> Eduard Soltan wrote:
>
> >
> > In @SymbolResolver.findFile@, if the propath entry i... Eduard Soltan

10:06 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Eduard Soltan wrote:
>
> In @SymbolResolver.findFile@, if the propath entry is not present in the conversion lis... Constantin Asofiei

09:44 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Constantin Asofiei wrote:
> PROPATH always has precedence. It doesn't matter if multiple .cls with the same basenam... Eduard Soltan

08:12 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

PROPATH always has precedence. It doesn't matter if multiple .cls with the same basename like @oo.Bar@ appear in mul... Constantin Asofiei

08:08 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Constantin Asofiei wrote:
> To summarize the rules we need to follow:
> * if oo.Bar exists only once in PROPATH, bu... Eduard Soltan

07:21 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Constantin Asofiei wrote:
> > I thought that if it is included in the conversion list, then it should be used.
> No... Constantin Asofiei

07:20 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Eduard Soltan wrote:
> Constantin Asofiei wrote:
> > * if a skeleton class is in abl/ folder and included in conver... Constantin Asofiei

07:14 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Constantin Asofiei wrote:
> * if a skeleton class is in abl/ folder and included in conversion, and is also in PROPA... Eduard Soltan

07:05 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Constantin Asofiei wrote:
> To summarize the rules we need to follow:
> * if oo.Bar exists only once in PROPATH, bu... Eduard Soltan

05:43 AM Bug #7255 (WIP): FWD resolves a OO file not included in conversion, if it exists on disk and on P...

To summarize the rules we need to follow:
* if oo.Bar exists only once in PROPATH, but not in conversion list, then ... Constantin Asofiei

05:14 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Eduard Soltan wrote:
> I am wondering what will happen if I have a usage of normal 4gl procedure like @run proc1.p@.... Constantin Asofiei

05:13 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

I am wondering what will happen if I have a usage of normal 4gl procedure like @run proc1.p@. Eduard Soltan

05:10 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Constantin Asofiei wrote:
> OK, now remove from conversion list @oo.Bar@ and check what happens - it should be added... Eduard Soltan

04:54 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

OK, now remove from conversion list @oo.Bar@ and check what happens - it should be added automatically Constantin Asofiei

04:51 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Constantin Asofiei wrote:
> Yes, this I think is from hierarchy. But you can also have @def var l1 as oo.Bar@, not ... Eduard Soltan

04:43 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Yes, this I think is from hierarchy. But you can also have @def var l1 as oo.Bar@, not just @inherits@. Constantin Asofiei

04:40 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Constantin, regarding the parsing of the reference files.
I have a @oo.Foo.cls@ class the inherits from @oo.Bar.cl... Eduard Soltan

12:10 PM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

Dănuț Filimon wrote:
> It also appears that TransformDriver.ExcludeCheck class and TransformDriver.ScanCheck class a... Greg Shah

12:07 PM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

> As mentioned yesterday, I am trying to make way for direct usage of artifacts in the AstManager. The problem I am f... Greg Shah

07:37 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

It also appears that TransformDriver.ExcludeCheck class and TransformDriver.ScanCheck class are never used. Dănuț Filimon

04:25 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

As mentioned yesterday, I am trying to make way for direct usage of artifacts in the AstManager. The problem I am fac... Dănuț Filimon

04/01/2025

06:53 PM Bug #9863 (WIP): Fileset eXclude broken on native Windows

After I modified the code to replace @/@ in the filter with @File.separatorChar@, @Pattern.compile@ is choking on the... Roger Borrello

06:18 PM Bug #9863: Fileset eXclude broken on native Windows

In @processFileSet@ the @ExplicitFileList reference = new ExplicitFileList(caseSens)@ returns a filenames list retrie... Roger Borrello

05:26 PM Bug #9863: Fileset eXclude broken on native Windows

No. Doing so would greatly reduce the possible combinations of input. There is no good functional reason to require... Greg Shah

05:13 PM Bug #9863: Fileset eXclude broken on native Windows

Greg Shah wrote:
> The wildcard being required is not something that is OK. Was that your question?
Yes, but the ... Roger Borrello

03:30 PM Bug #9863: Fileset eXclude broken on native Windows

The wildcard being required is not something that is OK. Was that your question? Greg Shah

02:50 PM Bug #9863: Fileset eXclude broken on native Windows

Greg Shah wrote:
> Debug it. The cause should be clear in the debugger.
I am working on that. I wanted to get a ... Roger Borrello

02:42 PM Bug #9863: Fileset eXclude broken on native Windows

It seems for each option (@-X@ or @-Z@), you can try with Unix path separators or Windows separators, and with/withou... Roger Borrello

02:29 PM Bug #9863: Fileset eXclude broken on native Windows

Debug it. The cause should be clear in the debugger. Greg Shah

01:58 PM Bug #9863: Fileset eXclude broken on native Windows

This occurs with Hotel GUI, when you make sure to checkout possenet into the @abl/@ directory. All the possenet files... Roger Borrello

10:34 AM Bug #9863: Fileset eXclude broken on native Windows

I used the same @zfile_set.txt@ file for a conversion on Windows as Ubuntu, and the @X@ directive was basically ignor... Roger Borrello

10:19 AM Bug #9863 (Closed): Fileset eXclude broken on native Windows

Roger Borrello

03/31/2025

07:25 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Constantin Asofiei wrote:
> Are you modifying the PROPATH maps in FWD? I don't want to do this, just check at resol... Eduard Soltan

05:52 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Are you modifying the PROPATH maps in FWD? I don't want to do this, just check at resolution time . Constantin Asofiei

05:34 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Eduard Soltan wrote:
>
> But I was think about something more general.
>
> I have a @src/oo/Foo.cls@ class whic... Eduard Soltan

03/28/2025

09:50 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Constantin Asofiei wrote:
> If is included, then yes, go ahead and resolve it from that PROAPTH location. The probl... Eduard Soltan

09:23 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Eduard Soltan wrote:
> Constantin Asofiei wrote:
> > Eduard Soltan wrote:
> > > This name duplication with 4gl bui... Constantin Asofiei

09:22 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Constantin Asofiei wrote:
> Eduard Soltan wrote:
> > This name duplication with 4gl buildin classes, or with custom... Eduard Soltan

09:07 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Eduard Soltan wrote:
> This name duplication with 4gl buildin classes, or with custom classes (@src1/oo/Foo.cls and ... Constantin Asofiei

09:03 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Constantin Asofiei wrote:
> Greg Shah wrote:
> > In regard to the change itself, I wonder if we should put an addit... Eduard Soltan

04:19 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Greg Shah wrote:
> In regard to the change itself, I wonder if we should put an additional protection into this code... Constantin Asofiei

08:17 AM Feature #7180 (WIP): create a centralized manager for the conversion list and per-file/project st...

Greg Shah wrote:
> 1. What is the purpose for @Artifact.get|setExtName()@? Is that supposed to be the fully qualifi... Dănuț Filimon

03/27/2025

05:18 PM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Code Review Task Branch 7255a Revision 15821
The @file-cvt-list.txt@ is nothing something that is built into FWD. ... Greg Shah

12:01 PM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Greg Shah wrote:
> Danut: Please review this change. I'd like if the approach we take here fits with our long term ... Dănuț Filimon

11:44 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Danut: Please review this change. I'd like if the approach we take here fits with our long term concepts of #7180 an... Greg Shah

11:35 AM Bug #7255 (Review): FWD resolves a OO file not included in conversion, if it exists on disk and o...

Committed on 7255a, rev. 15821.
Added in @SymbolResolver@ a static set with conversion sources from @file-cvt-list... Eduard Soltan

03:24 PM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

Code Review Task Branch 7180a Revisions 15826 through 15828
The code is moving along nicely.
1. What is the pur... Greg Shah

08:47 AM Feature #7180 (Review): create a centralized manager for the conversion list and per-file/project...

Rebased *7180a* to latest *trunk/15823*, the branch is now at revision *15828*. Dănuț Filimon

08:31 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

Committed *7180a/15742*. I replaced all usages of FileList with ArtifactCollection, and only the ones remaining in th... Dănuț Filimon

03/26/2025

11:25 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Well in @SymbolResolver@ constructor there is a call to @initPossibleClasses@ where the following classes are mapped:... Eduard Soltan

10:56 AM Bug #7255 (WIP): FWD resolves a OO file not included in conversion, if it exists on disk and on P...

Eduard Soltan wrote:
> Should the classes defined in @abl@ folder be mapped in @SymbolResolver.WorkArea.propathClass... Constantin Asofiei

10:51 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH

Question:
Should the classes defined in @abl@ folder be mapped in @SymbolResolver.WorkArea.propathClassDicts@, and... Eduard Soltan

08:59 AM Feature #8786: incremental schema conversion and updates

One customer (see #9288) uses "Liquibase":https://en.wikipedia.org/wiki/Liquibase to implement their incremental sche... Greg Shah

03/25/2025

11:08 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...

Updated this, ref 15808.
Added some changes that basically checks if:
@basepath@ is at the beginning of the filenam... Stefan Vieru