Project

General

Profile

Bug #9903

alternative codings with ' (quote) don't convert to ` (backtick)

Added by Stefan Vieru over 1 year ago. Updated 5 months ago.

Status:
Internal Test
Priority:
Normal
Assignee:
Stefan Vieru
Target version:
-
Start date:
Due date:
% Done:

100%

billable:
No
vendor_id:
GCD
case_num:
version_reported:
version_resolved:
reviewer:
Greg Shah
production:
No
env_name:
topics:
4GL Preprocessor

Related issues

Related to Testing - Support #6859: preprocessor tests Test
Related to Conversion Tools - Bug #10569: Semicolon is skipped while preprocessing Internal Test

History

#1 Updated by Stefan Vieru over 1 year ago

#2 Updated by Stefan Vieru over 1 year ago

In the Preprocessor wiki and in com.goldencode.p2j.preproc.Preprocessor is stated that ;' should convert to ', when in progress and in it's wiki is stated to convert to `.

#3 Updated by Stefan Vieru over 1 year ago

Base test:

/* ;' */
// ;'
/* "";' */
// "";'
/* ";' */
// ";'
/* ";'" */
// ";'" 
/* '';' */
// '';'
/* ';' */
// ';'
/* ';'' */
// ';''

OE converts to:

/* ` */
// `

/* ""` */
// ""`

/* "` */
// "`

/* "`" */
// "`" 

/* ''` */
// ''`

/* '` */
// '`

/* '`' */
// '`'

FWD converts to:

/* ' */
// '

/* ""' */
// ""'

/* "' */
// "'

/* "'" */
// "'" 

/* ''' */
// '''

/* '' */
// ''

/* ''' */
// '''

#4 Updated by Stefan Vieru about 1 year ago

  • Status changed from New to WIP

#5 Updated by Stefan Vieru about 1 year ago

  • Status changed from WIP to Review
  • reviewer Greg Shah added

This has been solved in 6859b

#6 Updated by Stefan Vieru about 1 year ago

  • Assignee set to Stefan Vieru

#7 Updated by Stefan Vieru 12 months ago

Testcases that cover this:
  • alternative_coding_quirk_04

#8 Updated by Greg Shah 11 months ago

  • Status changed from Review to Internal Test
  • % Done changed from 0 to 100

I've reviewed this change and all the related change in 6859b. It is difficult to assess by code review alone, if these changes are correct. At this point, we have to carefully test the full range of customer applications to confirm if this is safe.

#9 Updated by Radu Apetrii 10 months ago

  • Related to Bug #10569: Semicolon is skipped while preprocessing added

#10 Updated by Greg Shah 5 months ago

  • topics 4GL Preprocessor added

Also available in: Atom PDF