Bug #10284: JSON import error handing improvement - Base Language - Golden Code Redmine

Bug #10284

JSON import error handing improvement

Added by Teodor Gorghe about 1 year ago. Updated 12 months ago.

Status:

Test

Priority:

Normal

Assignee:

Teodor Gorghe

Target version:

Start date:

Due date:

% Done:

100%

billable:

vendor_id:

GCD

case_num:

version_reported:

version_resolved:

reviewer:

Constantin Asofiei

production:

env_name:

topics:

Related issues

History

#1 Updated by Teodor Gorghe about 1 year ago

Suppose we have this unit test, which checks the JSON error message on import:

ABL Code:

USING OpenEdge.Core.Assert FROM PROPATH.
USING support.test.AssertExt FROM PROPATH.

BLOCK-LEVEL ON ERROR UNDO, THROW.

CLASS tests.TestInvalidJSON:
    DEFINE VARIABLE hDSet       AS HANDLE    NO-UNDO.

    @Test.
    METHOD PUBLIC VOID TestInvalidJsonDataset():
        DEFINE VARIABLE lRetOk AS LOGICAL NO-UNDO.
        DEFINE VARIABLE clongchar AS LONGCHAR NO-UNDO.
        clongchar = "Invalid text".
        CREATE DATASET  hDSet.
        hDSet:READ-JSON ("longchar", clongchar, "empty") NO-ERROR.
        Assert:Equals(1, ERROR-STATUS:NUM-MESSAGES).
        AssertExt:Error(15358, "Error parsing JSON: expected bracket, but found I. (15358)").
    END METHOD.
END CLASS.

This passes on OE 4GL, but fails on FWD:

╷
├─ JUnit Jupiter ✔
├─ JUnit Vintage ✔
├─ JUnit Platform Suite ✔
└─ FWD Test ✔
   └─ tests.TestInvalidJSON ✔
      └─ testInvalidJsonDataset ✘ Expected: 1 but was: 0

Failures (1):
  FWD Test:tests.TestInvalidJSON:testInvalidJsonDataset
    MethodSource [className = 'com.goldencode.testcases.tests.TestInvalidJson', methodName = 'testInvalidJsonDataset', methodParameterTypes = '']
    => org.opentest4j.AssertionFailedError: Expected: 1 but was: 0
       com.goldencode.p2j.oo.core.AbstractAssert.raiseErrorForEquals(AbstractAssert.java:2182)
       com.goldencode.p2j.oo.core.AbstractAssert.call(AbstractAssert.java:1778)
       com.goldencode.p2j.oo.core.AbstractAssert.call(AbstractAssert.java:1762)
       com.goldencode.p2j.oo.core.AbstractAssert.call(AbstractAssert.java:2288)
       com.goldencode.p2j.oo.core.AbstractAssert.equalsImpl(AbstractAssert.java:1775)
       com.goldencode.p2j.oo.core.Assert.legacyEquals(Assert.java:2502)
       com.goldencode.testcases.tests.TestInvalidJson.testInvalidJsonDataset(TestInvalidJson.java:52)
       com.goldencode.testcases.tests.TestInvalidJson.testInvalidJsonDataset(TestInvalidJson.java:47)

#3 Updated by Teodor Gorghe about 1 year ago

This issue is also happening for static datasets and temp-table.

Code Code

USING OpenEdge.Core.Assert FROM PROPATH.
USING support.test.AssertExt FROM PROPATH.

BLOCK-LEVEL ON ERROR UNDO, THROW.

CLASS tests.TestInvalidJSON:
    DEFINE VARIABLE hDSet       AS HANDLE    NO-UNDO.
    DEFINE TEMP-TABLE tt1
        FIELD i1 AS INTEGER.
    DEFINE TEMP-TABLE tt2
        FIELD i1 AS INTEGER.
    DEFINE DATASET ds1 FOR tt1.

    @Test.
    METHOD PUBLIC VOID TestDynamicInvalidJsonPayloadDataset():
        DEFINE VARIABLE clongchar AS LONGCHAR NO-UNDO.
        clongchar = "Invalid text".
        CREATE DATASET  hDSet.
        hDSet:READ-JSON ("longchar", clongchar, "empty") NO-ERROR.
        Assert:Equals(1, ERROR-STATUS:NUM-MESSAGES).
        AssertExt:Error(15358, "Error parsing JSON: expected bracket, but found I. (15358)").
    END METHOD.

    @Test.
    METHOD PUBLIC VOID TestDynamicInvalidJsonPayloadDatasetWithBuffer():
        DEFINE VARIABLE clongchar AS LONGCHAR NO-UNDO.
        clongchar = "Invalid text".
        CREATE DATASET  hDSet.
        hDSet:SET-BUFFERS (BUFFER tt2:HANDLE).
        hDSet:READ-JSON ("longchar", clongchar, "empty") NO-ERROR.
        Assert:Equals(1, ERROR-STATUS:NUM-MESSAGES).
        AssertExt:Error(15358, "Error parsing JSON: expected bracket, but found I. (15358)").
    END METHOD.

    @Test.
    METHOD PUBLIC VOID TestStaticInvalidJsonPayloadDataset():
        DEFINE VARIABLE clongchar AS LONGCHAR NO-UNDO.
        clongchar = "Invalid text".
        DATASET ds1:READ-JSON ("longchar", clongchar, "empty") NO-ERROR.
        Assert:Equals(1, ERROR-STATUS:NUM-MESSAGES).
        AssertExt:Error(15358, "Error parsing JSON: expected bracket, but found I. (15358)").
    END METHOD.

    @Test.
    METHOD PUBLIC VOID TestDynamicInvalidJsonTempTable():
        DEFINE VARIABLE clongchar AS LONGCHAR NO-UNDO.
        DEFINE VARIABLE tt1hdl    AS HANDLE NO-UNDO.
        CREATE TEMP-TABLE tt1hdl.
        clongchar = "Invalid text".
        tt1hdl:READ-JSON ("longchar", clongchar, "empty") NO-ERROR.
        Assert:Equals(1, ERROR-STATUS:NUM-MESSAGES).
        AssertExt:Error(15360, "Error parsing JSON: unexpected token: error. (15360)").
    END METHOD.

    @Test.
    METHOD PUBLIC VOID TestStaticInvalidJsonTempTable():
        DEFINE VARIABLE clongchar AS LONGCHAR NO-UNDO.
        clongchar = "Invalid text".
        BUFFER tt1:HANDLE:READ-JSON ("longchar", clongchar, "empty") NO-ERROR.
        Assert:Equals(1, ERROR-STATUS:NUM-MESSAGES).
        AssertExt:Error(15360, "Error parsing JSON: unexpected token: error. (15360)").
    END METHOD.
END CLASS.

Logs

╷
├─ JUnit Jupiter ✔
├─ JUnit Vintage ✔
├─ JUnit Platform Suite ✔
└─ FWD Test ✔
   └─ tests.TestInvalidJSON ✔
      ├─ testDynamicInvalidJsonPayloadDataset ✘ Expected: 1 but was: 0
      ├─ testDynamicInvalidJsonPayloadDatasetWithBuffer ✘ Expected: 1 but was: 0
      ├─ testStaticInvalidJsonPayloadDataset ✘ Expected: 1 but was: 0
      ├─ testDynamicInvalidJsonTempTable ✘ Expected: 1 but was: 0
      └─ testStaticInvalidJsonTempTable ✘ Expected: 1 but was: 0

#4 Updated by Teodor Gorghe about 1 year ago

Status changed from New to WIP

Created task branch 10284a.

#5 Updated by Teodor Gorghe about 1 year ago

Status changed from WIP to Review
Assignee set to Teodor Gorghe
reviewer Constantin Asofiei added

Committed revision 16039 on task branch 10284a:
- READ-JSON error handling improvement.

#6 Updated by Teodor Gorghe about 1 year ago

% Done changed from 0 to 100

#7 Updated by Teodor Gorghe about 1 year ago

Status changed from Review to WIP
% Done changed from 100 to 50

#8 Updated by Constantin Asofiei about 1 year ago

Please add protection if the i.e. indexOf finds a char (is not negative), in all code which checks 'indexOf'.

#9 Updated by Teodor Gorghe about 1 year ago

Regarding for this task, I did changed from 100 to 50 percent because there are more cases when this message is checked on some tests.
Then, I have noticed that 4GL and the Jackson JSON parser throws JSON error at different locations, on more invalid JSON payloads. I don't have a solution for that just yet, but I don't think there is one.