Bug #10294: ProDataSet BufferImpl.synchronize(DataRelation) ArrayIndexOutOfBoundsException - Base Language - Golden Code Redmine

Bug #10294

« Previous | Next »

ProDataSet BufferImpl.synchronize(DataRelation) ArrayIndexOutOfBoundsException

Added by Teodor Gorghe about 1 year ago. Updated about 1 year ago.

Status:

Test

Priority:

Normal

Assignee:

Teodor Gorghe

Target version:

Start date:

Due date:

% Done:

100%

billable:

vendor_id:

GCD

case_num:

version_reported:

version_resolved:

reviewer:

Constantin Asofiei

production:

env_name:

topics:

Related issues

History

#1 Updated by Teodor Gorghe about 1 year ago

There is an issue of BufferImpl.synchronize(DataRelation), on a buffer from DATASET.
ABL Code:

BLOCK-LEVEL ON ERROR UNDO, THROW.

USING OpenEdge.Core.Assert FROM PROPATH.

CLASS tests.TestBufferAutosynchronize:
    DEFINE TEMP-TABLE tt1
        FIELD key1 AS INTEGER.

    DEFINE TEMP-TABLE tt2
        FIELD key2 AS INTEGER
        FIELD common_field AS RECID.

    DEFINE TEMP-TABLE tt3
        FIELD key3 AS INTEGER
        FIELD common_field AS RECID.

    DEFINE DATASET dsTest FOR tt1, tt2, tt3
        PARENT-ID-RELATION rel1 FOR tt1, tt2 PARENT-ID-FIELD common_field
        PARENT-ID-RELATION rel2 FOR tt2, tt3 PARENT-ID-FIELD common_field.

    @Test.
    METHOD PUBLIC VOID TestBufferRelease():
        DATASET dsTest:EMPTY-DATASET().

        CREATE tt2.
        BUFFER tt2:AUTO-SYNCHRONIZE = TRUE.
        RELEASE tt2. /* FWD throws java.lang.ArrayIndexOutOfBoundsException: Index 0 out of bounds for length 0 */
    END METHOD.
END CLASS.

Test log Test log

╷
├─ JUnit Jupiter ✔
├─ JUnit Vintage ✔
├─ JUnit Platform Suite ✔
└─ FWD Test ✔
   └─ tests.TestBufferAutosynchronize ✔
      └─ testBufferRelease ✘ invoke() of program tests.TestBufferAutosynchronize failed

Failures (1):
  FWD Test:tests.TestBufferAutosynchronize:testBufferRelease
    MethodSource [className = 'com.goldencode.testcases.tests.TestBufferAutosynchronize', methodName = 'testBufferRelease', methodParameterTypes = '']
    => java.lang.RuntimeException: invoke() of program tests.TestBufferAutosynchronize failed
       com.goldencode.p2j.util.ControlFlowOps.invokeError(ControlFlowOps.java:8546)
       com.goldencode.p2j.util.ControlFlowOps.invokeLegacyMethod(ControlFlowOps.java:5269)
       com.goldencode.p2j.util.ControlFlowOps.invokeLegacyMethod(ControlFlowOps.java:5157)
       com.goldencode.p2j.util.ObjectOps.invoke(ObjectOps.java:4902)
       com.goldencode.p2j.util.ObjectOps.invokeStandalone(ObjectOps.java:2712)
       [...]
     Caused by: java.lang.reflect.InvocationTargetException
       java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
       java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
       java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
       java.base/java.lang.reflect.Method.invoke(Method.java:569)
       com.goldencode.p2j.util.ControlFlowOps$InternalEntryCaller.invokeImpl(ControlFlowOps.java:9759)
       [...]
     Caused by: java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
       com.goldencode.p2j.util.TransactionManager.abnormalEnd(TransactionManager.java:6140)
       com.goldencode.p2j.util.TransactionManager$TransactionHelper.abnormalEnd(TransactionManager.java:9654)
       com.goldencode.p2j.util.BlockManager.topLevelBlock(BlockManager.java:9283)
       com.goldencode.p2j.util.BlockManager.internalProcedure(BlockManager.java:906)
       com.goldencode.p2j.util.BlockManager.internalProcedure(BlockManager.java:879)
       [...]
     Caused by: java.lang.reflect.InvocationTargetException
       java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
       java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
       java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
       java.base/java.lang.reflect.Method.invoke(Method.java:569)
       com.goldencode.p2j.util.Utils.invoke(Utils.java:1725)
       [...]
     Caused by: java.lang.ArrayIndexOutOfBoundsException: Index 0 out of bounds for length 0
       com.goldencode.p2j.persist.BufferImpl.synchronize(BufferImpl.java:8814)
       com.goldencode.p2j.persist.BufferImpl.querySynchronize(BufferImpl.java:8658)
       com.goldencode.p2j.persist.RecordBuffer.release(RecordBuffer.java:9916)
       com.goldencode.p2j.persist.BufferImpl.release(BufferImpl.java:2291)
       com.goldencode.p2j.persist.BufferImpl.release(BufferImpl.java:2276)
       [...]

Currently, I need to do some research, how DATASET works on 4GL OE and more stuff about relationships/synchronization.

#3 Updated by Teodor Gorghe about 1 year ago

Assignee set to Teodor Gorghe
Status changed from New to WIP

Create task branch 10294a.

#4 Updated by Teodor Gorghe about 1 year ago

% Done changed from 0 to 100
Status changed from WIP to Review
reviewer Constantin Asofiei added

Committed revision 16052 on task branch 10294a:
- BufferImpl.synchronize(DataRelation) exception fix on PARENT-ID-RELATION.

Committed revision 16053 on task branch 10294a:
- The last solution was not good for a PARENT-ID-RELATION implementation. I think this one is good.

I need to do some additional testing on this with some standalone tests.

#5 Updated by Teodor Gorghe about 1 year ago

While testing the BUFFER:SYNCHRONIZE, I have come across with the following issue:
- when reading a ProDataSet using the READ-XML, the child does not receive the parent's RECID

ABL Code ABL Code

BLOCK-LEVEL ON ERROR UNDO, THROW.

USING OpenEdge.Core.Assert FROM PROPATH.

CLASS tests.TestBufferAutosynchronize:
    DEFINE TEMP-TABLE tt1
        FIELD key1 AS INTEGER.

    DEFINE TEMP-TABLE tt2
        FIELD key2 AS INTEGER
        FIELD common_field AS RECID.

    DEFINE TEMP-TABLE tt3
        FIELD key3 AS INTEGER
        FIELD common_field AS RECID.

    DEFINE DATASET dsTest FOR tt1, tt2, tt3
        PARENT-ID-RELATION rel1 FOR tt1, tt2 PARENT-ID-FIELD common_field
        PARENT-ID-RELATION rel2 FOR tt2, tt3 PARENT-ID-FIELD common_field.

    @Test.
    METHOD PUBLIC VOID TestBufferRelease():
        DATASET dsTest:EMPTY-DATASET().

        CREATE tt2.
        BUFFER tt2:AUTO-SYNCHRONIZE = TRUE.
        RELEASE tt2. /* FWD does not fail on this anymore */
    END METHOD.

    @Test.
    METHOD PUBLIC VOID TestBufferParentIdRelationSynchronization():
        DEFINE VARIABLE lcXMLData AS LONGCHAR NO-UNDO.
        DEFINE VARIABLE rId       AS RECID    NO-UNDO.

        lcXMLData = '<?xml version="1.0"?>' + CHR(10) +
                    '<dsTest>' + CHR(10) +
                    '  <tt1>' + CHR(10) +
                    '    <key1>10</key1>' + CHR(10) +
                    '    <tt2>' + CHR(10) +
                    '      <key2>101</key2>' + CHR(10) +
                    '      <tt3>' + CHR(10) +
                    '        <key3>1011</key3>' + CHR(10) +
                    '      </tt3>' + CHR(10) +
                    '    </tt2>' + CHR(10) +
                    '    <tt2>' + CHR(10) +
                    '      <key2>102</key2>' + CHR(10) +
                    '      <tt3>' + CHR(10) +
                    '        <key3>1021</key3>' + CHR(10) +
                    '      </tt3>' + CHR(10) +
                    '      <tt3>' + CHR(10) +
                    '        <key3>1022</key3>' + CHR(10) +
                    '      </tt3>' + CHR(10) +
                    '    </tt2>' + CHR(10) +
                    '  </tt1>' + CHR(10) +
                    '  <tt1>' + CHR(10) +
                    '    <key1>20</key1>' + CHR(10) +
                    '    <tt2>' + CHR(10) +
                    '      <key2>201</key2>' + CHR(10) +
                    '      <tt3>' + CHR(10) +
                    '        <key3>2011</key3>' + CHR(10) +
                    '      </tt3>' + CHR(10) +
                    '    </tt2>' + CHR(10) +
                    '  </tt1>' + CHR(10) +
                    '</dsTest>'.

        DATASET dsTest:EMPTY-DATASET ().
        DATASET dsTest:READ-XML("longchar", lcXMLData, "EMPTY", ?, ?).

        FIND FIRST tt2 WHERE tt2.key2 = 101 NO-ERROR.
        Assert:IsTrue(AVAILABLE tt2, "tt2 key2 not available 1").

        rId = tt2.common_field. /* Instead of the actual RECID from the parent, tt2.common_field is actually unknown. */
        FIND FIRST tt1 WHERE RECID(tt1) = rId NO-ERROR.
        Assert:IsTrue(AVAILABLE tt1, "tt1 key1 not available 1"). /* FWD fails here */

        FIND FIRST tt1 WHERE tt1.key1 = 20 NO-ERROR.
        Assert:IsTrue(AVAILABLE tt2, "tt2 key2 not available 2").

        BUFFER tt1:AUTO-SYNCHRONIZE = TRUE.
        tt2.common_field = rId.
        RELEASE tt1.

        FIND FIRST tt2 WHERE tt2.common_field = rId AND tt2.key2 = 101 NO-ERROR.
        Assert:IsTrue(AVAILABLE tt2, "tt2 key2 not available 3").
    END METHOD.
END CLASS.

#6 Updated by Greg Shah about 1 year ago

Related to Feature #9543: implement missing BUFFER attributes added

#7 Updated by Constantin Asofiei about 1 year ago

Are you working on the 10249-5 bug?

#8 Updated by Teodor Gorghe about 1 year ago

Right now, no. I am working on #10309.

#9 Updated by Constantin Asofiei about 1 year ago

Status changed from Review to Merge Pending

Please commit 10294a now.

#10 Updated by Teodor Gorghe about 1 year ago

Status changed from Merge Pending to Test

Branch 10294a was merged to trunk revision 16064 and archived.

#11 Updated by Paul Bodale 12 months ago

Related to Bug #10352: Fix READ-JSON dataset handle method's behaviour added

Also available in: Atom PDF

	Related to Database - Feature #9543: implement missing BUFFER attributes	Test
	Related to Base Language - Bug #10352: Fix READ-JSON dataset handle method's behaviour	Closed

Project

General

Profile

FWD » Core Development » Base Language

Issues

Custom queries