Project

General

Profile

Bug #10628

embedded mode loading indicator issue

Added by Greg Shah about 1 year ago. Updated about 1 year ago.

Status:
Test
Priority:
Normal
Assignee:
Sergey Ivanovskiy
Target version:
-
Start date:
Due date:
% Done:

100%

billable:
No
vendor_id:
GCD
case_num:
version_reported:
version_resolved:
reviewer:
Hynek Cihlar
production:
No
env_name:
topics:

hotel_gui_embedded_mode_loading_indicator_issue_20250926.png (1.03 MB) Greg Shah, 09/26/2025 03:20 PM

hotel_gui_embedded_mode_loading_indicator_issue_still_active_underneath_20250926.png (1.02 MB) Greg Shah, 09/26/2025 03:25 PM

hotel_gui_embedded_mode_loading_indicator_does_increase_20250926.png (1.02 MB) Greg Shah, 09/26/2025 03:47 PM

HotelGuiEmbeddedModeIndicator.mkv (3.09 MB) Sergey Ivanovskiy, 09/29/2025 05:19 AM

History

#1 Updated by Greg Shah about 1 year ago

Using trunk rev 16184, Hotel GUI embedded mode does not initialize properly. The iframe has a loading indicator that never finishes:

Can someone look into this issue?

#2 Updated by Greg Shah about 1 year ago

Weirdly, the window underneath is actually functional and responds to input:

#3 Updated by Greg Shah about 1 year ago

After 20 minutes, you can see the indicator increase.

#5 Updated by Constantin Asofiei about 1 year ago

Greg, the fix would be this:

=== modified file 'src/com/goldencode/p2j/ui/client/driver/web/res/p2j.socket.js'
--- old/src/com/goldencode/p2j/ui/client/driver/web/res/p2j.socket.js   2025-09-16 10:46:24 +0000
+++ new/src/com/goldencode/p2j/ui/client/driver/web/res/p2j.socket.js   2025-09-26 20:25:51 +0000
@@ -4781,7 +4781,7 @@
                   console.error(e);
                }
             }
-            if (!p2j.isGui && p2j.setLoadingCheckpoint)
+            if ((!p2j.isGui || p2j.embedded) && p2j.setLoadingCheckpoint)
             {
                p2j.setLoadingCheckpoint(100);
             }

Just a check in p2j.socket.js for embedded mode.

Sergey: this is from #10432.

#6 Updated by Greg Shah about 1 year ago

  • % Done changed from 0 to 100
  • Assignee set to Sergey Ivanovskiy
  • Status changed from New to Review
  • reviewer Hynek Cihlar added

That does indeed fix the issue.

Sergey: Please get this into a branch, reviewed, tested and merged ASAP. Also: Please update Open Regressions in FWD v4 with the details of this issue.

#7 Updated by Sergey Ivanovskiy about 1 year ago

OK. This issue looks unexpected because I definitely checked this issue and even checked the web:client:embedded initialization.

#8 Updated by Sergey Ivanovskiy about 1 year ago

Constantin Asofiei wrote:

Greg, the fix would be this:
[...]

Just a check in p2j.socket.js for embedded mode.

Sergey: this is from #10432.

Yes, this code should be in my changes but for some reason I missed them.

#9 Updated by Sergey Ivanovskiy about 1 year ago

10628a created with rev 16185. Open Regressions in FWD v4 list was updated with rev 16177 regression.
These changes can be merged into the trunk if there are no objections.

#10 Updated by Constantin Asofiei about 1 year ago

  • Status changed from Review to Merge Pending

Please merge now.

#11 Updated by Sergey Ivanovskiy about 1 year ago

OK. For my current version of embedded hotel gui the indicator page looks differently.

#12 Updated by Sergey Ivanovskiy about 1 year ago

  • Status changed from Merge Pending to Test

Branch 10628a was merged into trunk as rev. 16185 and archived.

Also available in: Atom PDF