Project

General

Profile

Bug #10732

Fix Stream.assignDatum to handle all possible BDT types

Added by Lorian Sandu 9 months ago. Updated 9 months ago.

Status:
New
Priority:
Normal
Assignee:
Lorian Sandu
Target version:
-
Start date:
Due date:
% Done:

0%

billable:
No
vendor_id:
GCD
case_num:
version_reported:
version_resolved:
reviewer:
production:
No
env_name:
topics:

History

#1 Updated by Lorian Sandu 9 months ago

From Greg in #10707-6 :

My concern is with the existing design.

  1. We don't handle all possible BDT types and that seems like it is just leaving latent bugs there to hit us later. I would expect us to have logic (even if it is just error processing) for handle, com-handle, object, recid, longchar and memptr.
  2. This logic should be encapsulated in a virtual method defined in BDT. It seems like we could implement BDT.assignDatum(String value, boolean empty, boolean iso) and call that on the passed-in var instance. My guess is that this logic is actually used in other places (maybe for data deserialization?) in OE and having such logic in the BDT hierarchy is a better place for it.

#3 Updated by Greg Shah 9 months ago

  • Assignee set to Lorian Sandu

Also available in: Atom PDF