Bug #10772
NUM-RESULTS on a FOR EACH query fails
100%
History
#1 Updated by Teodor Gorghe 9 months ago
- Priority changed from Normal to Low
#2 Updated by Teodor Gorghe 9 months ago
+ Added watchers
#3 Updated by Teodor Gorghe 6 months ago
- Assignee set to Teodor Gorghe
- Status changed from New to WIP
Created task branch 10772a.
#4 Updated by Teodor Gorghe 6 months ago
- % Done changed from 0 to 100
- Status changed from WIP to Review
Committed revision 16362 on task branch 10772a:
- Query which is not scrolling should not raise exception on NUM-RESULTS.
#5 Updated by Teodor Gorghe 6 months ago
- reviewer Ovidiu Maxiniuc added
#6 Updated by Ovidiu Maxiniuc 6 months ago
- Status changed from Review to Internal Test
Review of 10772a/r16362
Good job!
Sincerely, I do not recall of the change in AbstractQuery (although otherwise documented) the in 2272b. I agree with the changes, assuming the new values returned by QueryWrapper.getNumResults() are correct (they seem logical, nonetheless).
Let's do a quick local optimisation at the same time: please replace all integer constructors in QueryWrapper.getNumResults() method with integer.UNKNOWN constant and integer.of() lookup method. Thanks!
#7 Updated by Teodor Gorghe 6 months ago
Committed revision 16363 on task branch 10772a:
- Replaced new integer(...) with integer.of() lookup and integer.UNKNOWN.
#9 Updated by Teodor Gorghe 4 months ago
All testing was done and the branch is ready to be merged to trunk.