Project

General

Profile

Bug #10784

« Previous | Next »

FWD Analytics - Visualize Call Graph can't be used due to broken file paths

Added by Octavian Adrian Gavril 9 months ago. Updated 6 months ago.

Status:
Test
Priority:
Normal
Assignee:
Dănuț Filimon
Target version:
-
Start date:
Due date:
% Done:

100%

billable:
No
vendor_id:
GCD
case_num:
version_reported:
version_resolved:
trunk/16362
reviewer:
production:
No
env_name:
topics:

Related issues

Related to TRPL - Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverage it Review
Related to Conversion Tools - Bug #10919: the source/AST view is broken in the Analytics web UI Test

History

#1 Updated by Octavian Adrian Gavril 9 months ago

I attached the log that described the issue:

The file paths seem broken.

I think the reason why the file paths are broken is that here the absolute path is [p2j_home]/deploy/server/:

  public static String normalizeFilename(String home, String filename)
   {
      File   abnormal = new File(filename); 
      String absolute;

      try
      {
         // make best effort to clean up the path
         absolute = abnormal.getCanonicalPath();
      }
      catch (IOException exc)
      {
         // fallback plan if canonical doesn't work
         absolute = abnormal.getAbsolutePath();
      }

This was not an issue for full conversion because the paths are calculated when the absolute path is [p2_home].

This is calculated just once, when the "basepath" parameter is extracted from configuration file. But instead of returning "./abl/", it returns "./deploy/".

#2 Updated by Greg Shah 9 months ago

  • Related to Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverage it added

#3 Updated by Octavian Adrian Gavril 9 months ago

I found as a quick fix that we can change in p2j.cfg.xml the basepath from "./abl" into "${P2J_HOME}/abl" after we run ant clean callgraph:

=== modified file 'cfg/p2j.cfg.xml'
--- old/cfg/p2j.cfg.xml    2025-09-26 16:42:32 +0000
+++ new/cfg/p2j.cfg.xml    2025-10-30 07:22:30 +0000
@@ -13,7 +13,7 @@

       <!-- values from the original system on which Progress 4GL ran -->
       <parameter name="propath"          value="${P2J_HOME}:${P2J_HOME}/abl:${P2J_HOME}/abl/common" />
-      <parameter name="basepath"         value="./abl" />
+      <parameter name="basepath"         value="${P2J_HOME}/abl" />
       <parameter name="include-spec"     value="*.[fhi]" />

This breaks parsing, but you can use it during the report.sh execution to enable Visualize Call Graph.

#4 Updated by Greg Shah 9 months ago

Octavian Adrian Gavril wrote:

I found as a quick fix that

Clever. Let's consider this a temporary workaround.

#5 Updated by Dănuț Filimon 8 months ago

  • Related to Bug #10919: the source/AST view is broken in the Analytics web UI added

#6 Updated by Dănuț Filimon 6 months ago

  • version_resolved set to trunk/16362
  • Status changed from New to Test
  • Assignee set to Dănuț Filimon
  • % Done changed from 0 to 100

This issue was fixed in trunk/16362 (#10919).

Also available in: Atom PDF