FWD » Core Development » Base Language

As noted in the title, there is a flaw in handling of statements UNDO, RETURN ERROR <error> if this occurs in a CATCH block.

The testcase looks like this:

CLASS C1:
    METHOD PUBLIC VOID m1(...):

        DEFINE VARIABLE hBuffer AS HANDLE NO-UNDO.
        CREATE BUFFER hBuffer FOR TABLE "inexistent-table". // one example which causes the oError exception to be thrown

        CATCH oError AS Progress.Lang.SysError :
            UNDO, RETURN ERROR NEW E1(oError). // E1 inherits AppError
        END CATCH.  

    END METHOD.
END CLASS.

The problem is that, at the moment the NEW E1(oError) is returned, the current block (that is CATCH) is used inside undoReturnErrorTopLevel(), causing the transaction manager to get confused, a second rollback is attempted (for outer block). As result, the following lines are printed in server's log:

SEVERE | com.goldencode.p2j.util.TransactionManager | ThreadName:Conversation [00000031:bogus] | There is already a pending rollback. Pending cause unavailable.
SEVERE | com.goldencode.p2j.util.TransactionManager | ThreadName:Conversation [00000031:bogus] | There is already a pending rollback. Current cause unavailable.
SEVERE | com.goldencode.p2j.util.TransactionManager | ThreadName:Conversation [00000031:bogus] | Abnormal end; original error:
java.lang.IllegalStateException: There is already a pending rollback.
    at com.goldencode.p2j.util.TransactionManager.rollbackWorker(TransactionManager.java:4369)
    at com.goldencode.p2j.util.TransactionManager.rollback(TransactionManager.java:4247)
    at com.goldencode.p2j.util.TransactionManager$TransactionHelper.rollback(TransactionManager.java:8877)
    at com.goldencode.p2j.util.TransactionManager$TransactionHelper.rollback(TransactionManager.java:8838)
    at com.goldencode.p2j.util.BlockManager.undoLeave(BlockManager.java:7902)
    at com.goldencode.p2j.util.BlockManager.processLegacyError(BlockManager.java:12372)
    at com.goldencode.p2j.util.BlockManager.processBody(BlockManager.java:9746)
    at com.goldencode.p2j.util.BlockManager.topLevelBlock(BlockManager.java:9342)
    at com.goldencode.p2j.util.BlockManager.internalProcedure(BlockManager.java:911)
    at <customer code>

Interesting enough, replacing the CATCH block with:

        CATCH oError AS Progress.Lang.SysError :
            UNDO, THROW NEW E1(oError). // E1 inherits AppError
        END CATCH.

Branch 10831a was merged to trunk rev 16399 and archived.