Project

General

Profile

Support #10926

General clean-up of Theme

Added by Alexandru Lungu 8 months ago. Updated 8 months ago.

Status:
New
Priority:
Normal
Assignee:
-
Target version:
-
Start date:
Due date:
% Done:

0%

billable:
No
vendor_id:
GCD
case_num:
version_reported:
version_resolved:
reviewer:
production:
No
env_name:
topics:

Related issues

Related to User Interface - Feature #10848: custom theme improvements New
Related to Documentation - Support #10849: improve documentation on implementation of custom themes New

History

#1 Updated by Alexandru Lungu 8 months ago

I created this task to discuss all kind of things that are found through-out Theme implementation and seem to:
  • have little documentation
  • are deprecated
  • are unused
  • create ambiguity

My end game here: What should a theme responsible developer do to properly consider implement certain methods and honor different flags?

To start with:

  • drawButton:
    • keyPressed is redundant as its state can be transmitted through pressed. There is no need to distinguish key press (SPACE down) vs mouse press (left click down) in the theme. TODO
    • hasPrepackagedImages is unclear to me what is responsible of. What should a theme responsible developer do to properly consider the hasPrepackagedImages flag? TODO
    • useResolverColors seems quite peculiar. This transmits to the theme whether the theme colors or the resolved colors should be used. What does this even mean? TODO

I will constantly update this post until the Theme interface is clear enough in order to be documented for a theme developer to use.

#2 Updated by Alexandru Lungu 8 months ago

#3 Updated by Alexandru Lungu 8 months ago

  • Related to Support #10849: improve documentation on implementation of custom themes added

#4 Updated by Alexandru Lungu 8 months ago

  • Tracker changed from Bug to Support

#5 Updated by Alexandru Lungu 8 months ago

Added watchers.

Also available in: Atom PDF