FWD » Core Development » Runtime Infrastructure

For temp folder, FWD relies on JVM shutdown hooks executed on the FWD servers. Look how p2j.util.Utils.createDirectoryIfNotExist is used.

For FWD client brokers, the file system is not on the same machine. Thus, temp folders need to be managed on the remote side.

We need to also double-check if other file-system resources are managed by FWD server (like log files?).

Why should we manage temporarily folders?

Sergey Ivanovskiy wrote:

Why should we manage temporarily folders?

Each client in the legacy OE env runs on its own machine, thus has its own temp folder. In FWD, we ensure this by creating sub-folders under the JVM temp folder, using as name a UUID for that FWD client.

Currently, we have some JVM shutdown hooks to delete these temp folders when the FWD server shuts down. We need to ensure that the temp folders are managed by the FWD client, and also we do our best to remove the folder when the FWD client JVM shuts down. So, the problem we need to fix is when the FWd clients runs on a different machine than the FWD server.

The code is used by SESSION:TEMP-DIRECTORY. How should this property be retrieved for 4GL?
Our implementation looks like

   /**
    * Gets the name of the directory where temporary files are stored.
    * Corresponds with the SESSION:TEMP-DIRECTORY system handle attribute.
    *
    * @return  Name of temporary directory.
    */
   @Override
   public String getTempDirectory()
   {
      return Utils.getOrCreateDefaultFwdTemporaryDirectory();
   }

+ Constantin

Thank you, I should check this. Should we always return the client side directory for this session? If it is executed by the server, then it should delegate this task to the client.

Sergey, when I have worked on #10136, I have the similar question.
The reason why we should create the directory is that we don't exactly know the directory when starting the application.
We use some kind of structure like {TMP-DIR}/fwd{random digits}, where these random digits are being generated at runtime. {TMP-DIR} must be there.

Why we are using this structure: because we need to isolate the clients.

Of course, 4GL does not create the temp directories.

OK, but should we delegate to OSResourceManager.getInstance().getFileSystem().getTempDirectory()?

OK. Do not mind. I will fix this part.

Sergey, Teodor is correct, we need explicit temp sub-folder for each FWD client.

Also, using FileSystem resource is OK; and please make the changes in 11325a.

Committed revision 16495 (11325a) should fix the shutdown hook on exit by providing which the file system is used the server or client file system.

• I'm OK with the changes, but please rebase
• we also need to ensure when server-side filesystem is in use, the temp folder gets deleted on context cleanup - see the new ServerFileSystemDaemon.java in trunk; a ContextLocal.cleanup needs to be used to delete the temp folder.

Constantin, I am sorry for missed your note. Do we need to fallback to OrderedShutdownHooks.registerShutdownHook(1, deleteOnExitHook); in additional to ContextLocal.cleanup on the server side?

Constantin Asofiei wrote:

Sergey, review for 11325a rev 16495:

• I'm OK with the changes, but please rebase
• we also need to ensure when server-side filesystem is in use, the temp folder gets deleted on context cleanup - see the new ServerFileSystemDaemon.java in trunk; a ContextLocal.cleanup needs to be used to delete the temp folder.

Constantin, please review 16616(11325a).

I rebased 11325a rev 16625.

Rebased 11325a up to rev 16641.

During manual testing of large customers applications I observed that on soft logout the web client throws IllegalStateException

ShowHide

26/07/06 11:26:13.792+0300 |  SEVERE | com.goldencode.p2j.ui.client.driver.web.WatchdogTimer | PID:64017, ThreadName:watchdog, Session:00000116, User:bogus | System exit is scheduled
26/07/06 11:26:13.793+0300 | WARNING | org.eclipse.jetty.util.component.ContainerLifeCycle | PID:64017, ThreadName:JettyShutdownThread, Session:00000116, User:bogus | Unable to destroy
java.lang.IllegalStateException: STARTED
    at org.eclipse.jetty.server.Handler$Abstract.destroy(Handler.java:506)
    at org.eclipse.jetty.util.component.ContainerLifeCycle.destroy(ContainerLifeCycle.java:228)
    at org.eclipse.jetty.server.Handler$Abstract.destroy(Handler.java:507)
    at org.eclipse.jetty.util.thread.ShutdownThread.run(ShutdownThread.java:146)
26/07/06 11:26:13.794+0300 |    INFO | org.eclipse.jetty.server.AbstractConnector | PID:64017, ThreadName:main, Session:00000116, User:bogus | Stopped ServerConnector@4cee7fa0{SSL, (ssl, http/1.1)}{0.0.0.0:7449}

Main CHUI regression tests were passed with 2 known failed test cases.

CHUI regression tests were passed. Hotel Gui web client in the virtual desktop mode and in the embedded mode has no new regressions.
It seems that this branch can be merged into the trunk.