Bug #11381
trunk no longer generates OpenClient proxies either via conversion or GenerateLegacyProxyOpenClient
100%
Related issues
History
#1 Updated by Constantin Asofiei 3 months ago
Trunk no longer generates OpenClient proxies from .xpxg files, either via conversion or GenerateLegacyProxyOpenClient.
Danut: please link the related tasks.
#2 Updated by Dănuț Filimon 3 months ago
- Related to Feature #7180: create a centralized manager for the conversion list and per-file/project status and logging added
#3 Updated by Dănuț Filimon 3 months ago
- Status changed from New to WIP
- Assignee set to Dănuț Filimon
#4 Updated by Constantin Asofiei 3 months ago
- File p1.patch
added
Danut, see attached patch, it solves the case where the program is in a abl/ sub-folder (resolved via PROPATH) - please review it.
#5 Updated by Dănuț Filimon 3 months ago
Constantin Asofiei wrote:
Danut, see attached patch, it solves the case where the program is in a abl/ sub-folder (resolved via PROPATH) - please review it.
Yes, I've come to the same solution. But I'll also have to check why the .proxy.jast files are generated in the abl folder (this is what remains).
#6 Updated by Dănuț Filimon 3 months ago
- % Done changed from 0 to 90
- File 11381.patch
added - reviewer Constantin Asofiei added
Constantin, I posted this patch based on what you posted and the remaining problem from #11381-5. The proxies are generated properly now. I will have to create and commit the changes to a branch.
#7 Updated by Dănuț Filimon 3 months ago
Committed 11381a/16522. Committed the patch from #11381-6.
About the change from src/com/goldencode/p2j/convert/ConversionDriver.java where the absolute path was being used, I'd rather have the relative path checked because the conversion receives it first and then builds the absolute path. This also matches with the code from src/com/goldencode/p2j/convert/GenerateLegacyProxyOpenClient.java.
#8 Updated by Dănuț Filimon 3 months ago
- Status changed from WIP to Review
- % Done changed from 90 to 100
Constantin, there are a few additional changes to review in rules and src/com/goldencode/artifacts/ArtifactWorker.java.
#9 Updated by Constantin Asofiei 3 months ago
- Status changed from Review to Internal Test
Dănuț Filimon wrote:
Constantin, there are a few additional changes to review in
rulesandsrc/com/goldencode/artifacts/ArtifactWorker.java.
I'm OK with the changes.
#10 Updated by Constantin Asofiei 3 months ago
- Status changed from Internal Test to Merge Pending
Please merge to trunk now.
#11 Updated by Dănuț Filimon 3 months ago
- Status changed from Merge Pending to Test
- version_resolved set to trunk/16527
Branch 11381a was merged into trunk 16527 and archived.