Project

General

Profile

Bug #11443

Analytics is broken in trunk/16548

Added by Dănuț Filimon 3 months ago. Updated 3 months ago.

Status:
Test
Priority:
Normal
Assignee:
Dănuț Filimon
Target version:
-
Start date:
Due date:
% Done:

100%

billable:
No
vendor_id:
GCD
case_num:
version_reported:
trunk/16438
version_resolved:
trunk/16551
reviewer:
Greg Shah
production:
No
env_name:
topics:

Related issues

Related to Conversion Tools - Feature #7180: create a centralized manager for the conversion list and per-file/project status and logging Closed

History

#1 Updated by Dănuț Filimon 3 months ago

  • Status changed from New to WIP
  • Assignee set to Dănuț Filimon

From #7143-1927:

Analytics is broken in trunk rev 16548 (or earlier) based on testing Hotel GUI rev 451 using ant rpt. This is the failure (during report generation):

    [java] Caused by: com.goldencode.expr.ExpressionException: Expression error [type == prog.filename and !isAst(findFile(text))]
     [java]     at com.goldencode.expr.Expression.getCompiledInstance(Expression.java:695)
     [java]     at com.goldencode.expr.Expression.execute(Expression.java:387)
     [java]     at com.goldencode.p2j.pattern.AstSymbolResolver.execute(AstSymbolResolver.java:765)
     [java]     at com.goldencode.p2j.pattern.CommonAstSupport$Library.exec(CommonAstSupport.java:1975)
     [java]     at com.goldencode.expr.CE222.execute(Unknown Source)
     [java]     at com.goldencode.expr.Expression.execute(Expression.java:398)
     [java]     ... 16 more
     [java] Caused by: com.goldencode.expr.CompilerException: Error parsing expression
     [java]     at com.goldencode.expr.Compiler.process(Compiler.java:382)
     [java]     at com.goldencode.expr.Compiler.compile(Compiler.java:302)
     [java]     at com.goldencode.expr.Expression.getCompiledInstance(Expression.java:687)
     [java]     ... 21 more
     [java] Caused by: com.goldencode.expr.UnresolvedSymbolException: No function resolved for instance (null) and method (name == isAst, signature == ([class java.lang.String]))
     [java]     at com.goldencode.expr.ExpressionParser.method(ExpressionParser.java:2081)
     [java]     at com.goldencode.expr.ExpressionParser.primary_expr(ExpressionParser.java:847)
     [java]     at com.goldencode.expr.ExpressionParser.un_expr(ExpressionParser.java:1629)
     [java]     at com.goldencode.expr.ExpressionParser.prod_expr(ExpressionParser.java:1481)
     [java]     at com.goldencode.expr.ExpressionParser.sum_expr(ExpressionParser.java:1409)
     [java]     at com.goldencode.expr.ExpressionParser.shift_expr(ExpressionParser.java:1330)
     [java]     at com.goldencode.expr.ExpressionParser.compare_expr(ExpressionParser.java:1242)
     [java]     at com.goldencode.expr.ExpressionParser.equality_expr(ExpressionParser.java:1169)
     [java]     at com.goldencode.expr.ExpressionParser.bit_and_expr(ExpressionParser.java:1118)
     [java]     at com.goldencode.expr.ExpressionParser.bit_xor_expr(ExpressionParser.java:1073)
     [java]     at com.goldencode.expr.ExpressionParser.bit_or_expr(ExpressionParser.java:1028)
     [java]     at com.goldencode.expr.ExpressionParser.log_and_expr(ExpressionParser.java:993)
     [java]     at com.goldencode.expr.ExpressionParser.expr(ExpressionParser.java:931)
     [java]     at com.goldencode.expr.ExpressionParser.expression(ExpressionParser.java:680)
     [java]     at com.goldencode.expr.Compiler.parse(Compiler.java:486)
     [java]     at com.goldencode.expr.Compiler.process(Compiler.java:352)

I've updated the open regressions list accordingly.

https://proj.goldencode.com/projects/regression/wiki/Open_Regressions_in_FWD_v4#Open-Regressions

#2 Updated by Dănuț Filimon 3 months ago

  • Related to Feature #7180: create a centralized manager for the conversion list and per-file/project status and logging added

#3 Updated by Dănuț Filimon 3 months ago

  • version_reported set to trunk/16438
  • % Done changed from 0 to 100
  • Status changed from WIP to Review
  • reviewer Greg Shah added

Committed 11443a/16551. Fixed analytics, found usage of 'file' through ReportDefinition#multiplexExpr.

Greg, please review.

#4 Updated by Greg Shah 3 months ago

  • Status changed from Review to Internal Test

Code Review Task Branch 11443a Revision 16551

The changes are good. These are quite low risk. If reports work now, we can merge.

#5 Updated by Greg Shah 3 months ago

Please fix this javadoc issue:

.../src/com/goldencode/artifacts/ArtifactManager.java:242: warning: Tag @link: reference not found: #projectExtensions
    * @return  The {@link #projectExtensions} array.
                   ^

#6 Updated by Dănuț Filimon 3 months ago

  • Status changed from Internal Test to Merge Pending

Greg Shah wrote:

Code Review Task Branch 11443a Revision 16551

The changes are good. These are quite low risk. If reports work now, we can merge.

No issues with Hotel_GUI reports, I'll be merging right now.

#7 Updated by Dănuț Filimon 3 months ago

  • Status changed from Merge Pending to Test
  • version_resolved set to trunk/16551

Branch 11443a was merged into trunk as rev. 16551 and archived.

(I also fixed the javadoc)

Also available in: Atom PDF