Bug #11636: errors raised during evaluation of &IF expressions drop the entire &IF - Conversion Tools - Golden Code Redmine

Bug #11636

errors raised during evaluation of &IF expressions drop the entire &IF

Added by Constantin Asofiei 4 days ago. Updated 1 day ago.

Status:

New

Priority:

Normal

Assignee:

Target version:

Start date:

Due date:

% Done:

billable:

vendor_id:

GCD

case_num:

version_reported:

version_resolved:

reviewer:

production:

env_name:

topics:

4GL Preprocessor

Related issues

History

#1 Updated by Constantin Asofiei 4 days ago

Related to Support #6859: preprocessor tests added

#2 Updated by Constantin Asofiei 4 days ago

Errors in evaluation of a &IF expression drops the entire statement. See this:

message "before".

&IF integer("abc") = 1
&THEN message "must not emit - then". 
&ELSE message "must not emit - else".
&ENDIF

message "after".

FWD preprocesses as:

message "before".

message "must not emit - else".

message "after".

while OE emits this:

message "before".

message "after".

We need to explore other edge cases where errors can happen (like conditions on &elseif or any other statement which supports evaluating stuff).

#3 Updated by Greg Shah 4 days ago

topics 4GL Preprocessor added

Octavian: Please add this to our preproc tests.

#4 Updated by Octavian Adrian Gavril 1 day ago

Greg Shah wrote:

Octavian: Please add this to our preproc tests.

Sure. I'm currently working on it, but the Preprocessor_Testcases is no longer available. Does anyone know what happened? When I access https://proj.goldencode.com/projects/p2j/wiki/Preprocessor_Testcases, it looks like a new wiki page.

#5 Updated by Constantin Asofiei 1 day ago

Octavian Adrian Gavril wrote:

Greg Shah wrote:

Octavian: Please add this to our preproc tests.

Sure. I'm currently working on it, but the Preprocessor_Testcases is no longer available. Does anyone know what happened? When I access https://proj.goldencode.com/projects/p2j/wiki/Preprocessor_Testcases, it looks like a new wiki page.

It was moved to Preprocessor_Testcases - see #11258-163

#6 Updated by Octavian Adrian Gavril 1 day ago

Thanks! I've added the testcase as preprocessor_if_eval_error.xml in testcases/1852.

#7 Updated by Constantin Asofiei 1 day ago

Octavian Adrian Gavril wrote:

Thanks! I've added the testcase as preprocessor_if_eval_error.xml in testcases/1852.

We need to expand on this - use &ELSEIF, and any other preprocessor statement where an expression is evaluated.

#8 Updated by Octavian Adrian Gavril 1 day ago

Right. I expanded the cases where an expression evaluation is broken in a preprocessor statement. The initial version of the testcase looks like this: Show Hide

/* 
   Testing preprocessor evaluation errors.

   Context: If OE hits a runtime-style error while evaluating a condition 
   (like a bad cast in an &IF or &ELSEIF), it just drops the whole block silently. 
   We need to make sure FWD replicates this exact behavior.
*/

message "--- START OF TESTS ---".

/* 1. Bad &ELSEIF condition. 
   The first check is false, so it moves to the elseif and chokes on the bad integer cast. */
message "case 1 - before".

&IF 1 = 2
&THEN 
    message "case 1 - must not emit - then".
&ELSEIF integer("bad_string") = 1
&THEN 
    message "case 1 - must not emit - elseif".
&ELSE 
    message "case 1 - must not emit - else".
&ENDIF

message "case 1 - after".

/* 2. Divide by zero. Classic math error during compile-time evaluation. */
message "case 2 - before".

&IF (100 / 0) = 1
&THEN 
    message "case 2 - must not emit - then".
&ELSE 
    message "case 2 - must not emit - else".
&ENDIF

message "case 2 - after".

/* 3. Bad logical cast. Trying to force a random string into a boolean. */
message "case 3 - before".

&IF logical("not-a-bool")
&THEN 
    message "case 3 - must not emit - then".
&ELSEIF TRUE
&THEN
    message "case 3 - must not emit - elseif".
&ELSE 
    message "case 3 - must not emit - else".
&ENDIF

message "case 3 - after".

/* 4. Built-in function errors (e.g., passing a negative length to substring). */
message "case 4 - before".

&IF substring("test", 1, -5) = "t" 
&THEN 
    message "case 4 - must not emit - then".
&ELSE 
    message "case 4 - must not emit - else".
&ENDIF

message "case 4 - after".

/* 5. Handling the unknown (?) value. OE hates this in preprocessor conditions. */
message "case 5 - before".

&IF integer(?) = 1
&THEN 
    message "case 5 - must not emit - then".
&ELSE 
    message "case 5 - must not emit - else".
&ENDIF

message "case 5 - after".

/* 6. Nested blocks. 
   If an inner &IF crashes, it should drop the inner block but keep the outer one intact. */
message "case 6 - before".

&IF TRUE
&THEN 
    message "case 6 - outer then - MUST EMIT".

    &IF integer("nested_crash") = 1
    &THEN message "case 6 - inner then - must not emit".
    &ELSE message "case 6 - inner else - must not emit".
    &ENDIF

    message "case 6 - outer after inner - MUST EMIT".
&ELSE 
    message "case 6 - outer else - must not emit".
&ENDIF

message "case 6 - after".

message "--- ADVANCED TESTS ---".

/* 7. Hidden macro errors. 
   The crash is inside the scoped define, so it only blows up when expanded here. */
message "case 7 - before".

&SCOPED-DEFINE BAD_EXPRESSION integer("invalid") = 1

&IF {&BAD_EXPRESSION}
&THEN 
    message "case 7 - must not emit - then".
&ELSE 
    message "case 7 - must not emit - else".
&ENDIF

message "case 7 - after".

/* 8. Short-circuiting logic. 
   If OE short-circuits here, it completely ignores the crash on the right side of the OR. 
   FWD needs to match OE's parsing weirdness here. */
message "case 8 - before".

&IF TRUE OR (integer("crash") = 1)
&THEN 
    message "case 8 - then (OE might emit this if it short-circuits)".
&ELSE 
    message "case 8 - must not emit - else".
&ENDIF

message "case 8 - after".

/* 9. Mixing built-in preprocessor functions with a bad runtime cast. */
message "case 9 - before".

&SCOPED-DEFINE DUMMY_VAR 1

&IF DEFINED(DUMMY_VAR) > 0 AND integer("abc") = 1
&THEN 
    message "case 9 - must not emit - then".
&ELSE 
    message "case 9 - must not emit - else".
&ENDIF

message "case 9 - after".

/* 10. Type mismatch in string concatenation. */
message "case 10 - before".

&IF "String A" + integer("bad") = "String Abad" 
&THEN 
    message "case 10 - must not emit - then".
&ELSE 
    message "case 10 - must not emit - else".
&ENDIF

message "case 10 - after".

/* 11. Unresolved include arguments. 
   If {&UNDEFINED_ARG} resolves to nothing, it leaves behind malformed syntax. */
message "case 11 - before".

&IF integer("{&UNDEFINED_ARG}") = 1
&THEN
    message "case 11 - must not emit - then".
&ELSE
    message "case 11 - must not emit - else".
&ENDIF

message "case 11 - after".

/* 12. Negative test for &MESSAGE.
   &MESSAGE shouldn't evaluate anything—it just takes string literals. 
   FWD better not drop this just because the string looks like invalid ABL. */
message "case 12 - before".

&MESSAGE integer("abc") = 1

message "case 12 - after".

message "--- END OF TESTS ---".

This is committed in testcases/1853.

Also available in: Atom PDF

Project

General

Profile

FWD » Core Development » Conversion Tools

Issues

Custom queries