Bug #11714
Fix MANIFEST classpath for minimal FWD client distribution.
0%
History
#3 Updated by Teodor Gorghe 7 days ago
- File dist_fix.patch
added
Currently, we use build/lib/p2j.jar, which has the MANIFEST classpath, the union of all distributions (client, server, convert).
The issue is that, not all distributions resolve to the same dependency version. For example, on #11671, the commons-io dependency resolved to 2.20.0 for FWD client and to 2.22.0 for FWD server. The final result for union is 2.22.0, but the client distribution still used 2.20.0, which caused a runtime missing dependency error.
Attached the patch which generates p2j.jar for each distribution.
#4 Updated by Constantin Asofiei 7 days ago
- a single p2j.jar with the union classpath in the manifest
- lib.client, lib.server, etc all need to use the same versions of the jars
#5 Updated by Teodor Gorghe 7 days ago
Understood.
#7 Updated by Constantin Asofiei 6 days ago
Greg Shah wrote:
We do not want different p2j.jar for lib.client/server/etc. So:
Actually, as noted in #2158, #11362 and #11367 we do want to get to this. Is your concern a short term thing?
Greg, those are something else. The 'fat' jar must work with any sub-set of the jar libraries - client, server, convert. If we use the same jar name, it will just create confusion.
When we move to different FWD jars for different cases, then we will have fwd-openclient.jar, fwd-client.jar, fwd-server.jar, etc. I don't want to have the same p2j.jar with just the manifest changed. More, there are hard-coded cases in FWD where we look exactly for p2j.jar file on the classpath, so those will need to be addressed at some point, too.