FWD » Bugs

Eugenie: is this one of the tests where we captured the screen on P2J instead of 4GL?

Yes, this was introduced since baseline set *_160_20120810a based on the P2J output instead of pure 4GL. The creation date is 2012/08/04.

Sorry, I messed up old and new screens. This is not a regression, this is the desired behavior. "Print Loc" single-line label is correct because it is explicitly specified is so/pick04.p:

display ...
      it-req.print-facility-code         format "x(10)" column-label "Print Loc" 

Stanislav,

Thanks for the confirmation, I'm working on it.

The current conversion is:

...
pickBrwsTurnaroundNumberColumn.setLabel("Order #");
pickBrwsTurnaroundNumberColumn.setFormat(">>>>>>9");
pickBrws.addColumn(pickBrwsStatusColumn);
pickBrwsStatusColumn.setDataType("character");
pickBrwsStatusColumn.setForceLabel(true);
pickBrwsStatusColumn.setLabel("Stat");
pickBrwsStatusColumn.setFormat("x");
pickBrws.addColumn(pickBrwsPrintFacilityCodeColumn);
pickBrwsPrintFacilityCodeColumn.setDataType("character");
pickBrwsPrintFacilityCodeColumn.setFormat("x(10)");
pickBrwsPrintFacilityCodeColumn.setColumnLabel("Print Loc");
pickBrwsPrintFacilityCodeColumn.setLabel("Print Location");
pickBrwsPrintFacilityCodeColumn.setColumnLabel("Print!Loc");
pickBrws.addColumn(pickBrwsCancelDateColumn);
pickBrwsCancelDateColumn.setDataType("date");
pickBrwsCancelDateColumn.setForceLabel(true);
pickBrwsCancelDateColumn.setLabel("Last Update");
pickBrwsCancelDateColumn.setFormat("99/99/9999");
pickBrws.addColumn(pickBrwsExpr62Column);
pickBrwsExpr62Column.setDataType("character");
pickBrwsExpr62Column.setForceLabel(true);
pickBrwsExpr62Column.setLabel("Time");
pickBrws.addColumn(pickBrwsExpr63Column);
pickBrwsExpr63Column.setDataType("decimal");
pickBrwsExpr63Column.setFormat(">>>>>9");
pickBrwsExpr63Column.setFormatWidth(6);
pickBrwsExpr63Column.setLabel("Elapsed");
pickBrws.addColumn(pickBrwsFacilityCodeColumn);
pickBrwsFacilityCodeColumn.setDataType("character");
pickBrwsFacilityCodeColumn.setForceLabel(true);
pickBrwsFacilityCodeColumn.setLabel("Pickup Loc");
pickBrwsFacilityCodeColumn.setFormat("x(4)");
pickBrws.addColumn(pickBrwsExpr64Column);
pickBrwsExpr64Column.setDataType("character");
pickBrwsExpr64Column.setFormatWidth(1);
pickBrwsExpr64Column.setForceLabel(true);
pickBrwsExpr64Column.setLabel("C");
pickBrwsExpr64Column.setFormat("X");
pickBrws.addColumn(pickBrwsExpr65Column);
pickBrwsExpr65Column.setDataType("character");
pickBrwsExpr65Column.setFormatWidth(1);
pickBrwsExpr65Column.setForceLabel(true);
pickBrwsExpr65Column.setLabel("H");
pickBrwsExpr65Column.setFormat("!");
...

The source file so/pick04.p has changed at 2012/08/03 testcases. So we have the issue triggered by the P2J code change.

Eugenie,

If you compare the so/pick04.p program in staging and pending you will see that the staging version has the explicit label set to "Print Loc" at the frame definition, not "Print!Loc" (which comes from the field definition). So, with Stanislav's fix, P2J behaves correct, showing the explicit label and not the implicit label.

The converted code above:

...
pickBrwsPrintFacilityCodeColumn.setColumnLabel("Print Loc");
pickBrwsPrintFacilityCodeColumn.setLabel("Print Location");
pickBrwsPrintFacilityCodeColumn.setColumnLabel("Print!Loc");
...

Related to current staging version with explicit setting label to "Print Loc". I just said the code change in 4GL highlight the issue in our conversion/runtime. This is not a regression, just issue.

What are the next steps with this?

1. Is this already in staging?
2. Are the regression tests already properly updated to resolve this failure?
3. Did this pass regression testing with the updated baselines?

If the answer to all of the above is YES, then go ahead with check in and distribution.

The answer is yes to all questions, and the update is already in CVS and has been distributed by Stanislav.