FWD » Bugs

At this point SELECTION-LIST does not work at all. It fails to initialize. Affects MAJIC. Example of stacktrace:

Caused by: java.lang.NoSuchMethodException: com.goldencode.p2j.ui.chui.SelectionListBodyImpl.<init>(com.goldencode.p2j.ui.ComponentConfig)
at java.lang.Class.getConstructor0(Class.java:2706)
at java.lang.Class.getConstructor(Class.java:1657)
at com.goldencode.p2j.ui.chui.ChuiWidgetFactory.create(ChuiWidgetFactory.java:118)
at com.goldencode.p2j.ui.client.SelectionList.<init>(SelectionList.java:95)
at com.goldencode.p2j.ui.chui.SelectionListImpl.<init>(SelectionListImpl.java:35)
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
at com.goldencode.p2j.ui.chui.ChuiWidgetFactory.create(ChuiWidgetFactory.java:119)
at com.goldencode.p2j.ui.client.UiUtils.reconstructComponent(UiUtils.java:345)
at com.goldencode.p2j.ui.client.WidgetRegistry.reconstructWidget(WidgetRegistry.java:79)
at com.goldencode.p2j.ui.client.WidgetRegistry.pushDefinition(WidgetRegistry.java:180)
at com.goldencode.p2j.ui.chui.ThinClient$18.run(ThinClient.java:6286)
at com.goldencode.p2j.ui.chui.ThinClient.eventBracket(ThinClient.java:11212)
at com.goldencode.p2j.ui.chui.ThinClient.eventDrawingBracket(ThinClient.java:11161)
at com.goldencode.p2j.ui.chui.ThinClient.pushOneDef(ThinClient.java:6274)
at com.goldencode.p2j.ui.chui.ThinClient.pushScreenDefinition(ThinClient.java:6249)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at com.goldencode.p2j.util.MethodInvoker.invoke(MethodInvoker.java:76)
at com.goldencode.p2j.net.Dispatcher.processInbound(Dispatcher.java:675)
at com.goldencode.p2j.net.Conversation.block(Conversation.java:316)
at com.goldencode.p2j.net.Conversation.waitMessage(Conversation.java:254)
at com.goldencode.p2j.net.Queue.transactImpl(Queue.java:1107)
at com.goldencode.p2j.net.Queue.transact(Queue.java:575)
at com.goldencode.p2j.net.BaseSession.transact(BaseSession.java:178)
at com.goldencode.p2j.net.HighLevelObject.transact(HighLevelObject.java:163)
at com.goldencode.p2j.net.RemoteObject$RemoteAccess.invokeCore(RemoteObject.java:1406)
at com.goldencode.p2j.net.InvocationStub.invoke(InvocationStub.java:97)
at $Proxy3.standardEntry(Unknown Source)
at com.goldencode.p2j.main.ClientCore.start(ClientCore.java:214)
at com.goldencode.p2j.main.ClientCore.start(ClientCore.java:74)
at com.goldencode.p2j.main.ClientDriver.start(ClientDriver.java:223)
at com.goldencode.p2j.main.CommonDriver.process(CommonDriver.java:423)
at com.goldencode.p2j.main.ClientDriver.process(ClientDriver.java:115)
at com.goldencode.p2j.main.ClientDriver.main(ClientDriver.java:241)

The problem was about SelectionListBody c'tor which was called upon SelectionList creation. ChuiWidgetFactory takes ComponentConfig, not SelectionListConfig:

public SelectionList(ComponentConfig cfg)
{
      ...
      list = screen().getFactory().create(SelectionListBody.class, config);
      ...

Additionally, IS-SELECTED function was not working properly (ThinClient.java):

public int[] getSelection(int widgetId)
{
     ...
      //TODO: this looks like a bug, condition should be inverted!!!
      if (widget.config() instanceof ControlSetConfig)
         return null;

      ControlSetConfig config = widget.config();

      return config.getSelection();
}

New MAJIC regressions tests GC 62 and GC 63 has been added to the baseline set. They are initialization and selection tests for selection lists.