FWD » Core Development

A good source for the samples already exists in the testcases/uast directory.

The index_supplemental.zip file contains compiler cross reference listings for a number of test cases, which are based on the p2j_test schema (see testcases/uast/data/p2j_test.df). For each *.xrf file in that archive, a corresponding *.p program exists in the testcases/uast directory. These programs were the basis of determining the query sorting rules for P2J.

Again, the examples do not need to be exhaustive; we are just looking for a representative sampling to indicate the practical outcome of the index selection process in terms of converted code.

Excellent work so far. I've made some edits to the chapter, particularly in some of the example details, and I've checked it in again. However, some minor cleanup remains (see below).

First, some minor formatting/style issues...

Please capitalize all important words (i.e., all but articles like "a", "an", "the", etc.) in section headings. For instance, use:

Conversion Examples

instead of:

Conversion examples

Please use the "Teletype" style (from the "Character Styles" page of the "Styles and Formatting" dialog in LibreOffice) for inline references to language keywords or code. If in a table, use "Teletype Small".

Please use 2 spaces to separate sentences.

Always end a chapter with a manual page break. This is necessary when combining the chapters into a book.

In terms of content...

In the first example, the first line is:

[def-temp-table.i]

Is this a reference to the name of this include file?

The examples below that include a file as follows:

{person-temp-table.i}

...but this include file is never defined anywhere. I suspect it was meant to refer to the first snippet of code (with that [def-temp-table.i] line). If so, please indicate the name of the include file outside of the example. Something like:

The following examples will use the person temporary table, as defined in person-temp-table.i:

/* person-temp-table.i */
define temp-table person
       field site-id as integer
       field emp-num as integer
       field first-name as character
       field last-name as character 
       ...

Please remove example 16. It is confusing. 17 is enough to illustrate rule 8 (alphabetically first index), and it does so pretty cleanly. The remaining examples will need to be re-numbered, of course.

I agree with your inline comment that the last example can be removed.

I fixed example 10 and example 11 text and committed into bazaar.